[GitHub] [ignite] xtern commented on a diff in pull request #10145: IGNITE-17296 .NET: Platform service interceptor.

[GitBox <gi...@apache.org>]

xtern commented on code in PR #10145:
URL: https://github.com/apache/ignite/pull/10145#discussion_r921949033


##########
modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceConfiguration.cs:
##########
@@ -91,6 +100,11 @@ internal void Write(IBinaryRawWriter w)
                 w.WriteObject(NodeFilter);
             else
                 w.WriteObject<object>(null);
+            
+            if (Interceptors != null)
+                w.WriteCollection(Interceptors as ICollection);

Review Comment:
   @ptupitsyn, maybe i can just use writeObject/readObject instead of writeCollection/readCollection/etc? (It seems to work fine)
   
   I can't figure out how to add the suggested overload without duplicating code or converting from a generic collection to a non-generic one in BinaryWriter/BinaryUtils.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org