You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2009/07/28 09:13:01 UTC

svn commit: r798422 - /commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java

Author: ggregory
Date: Tue Jul 28 07:13:01 2009
New Revision: 798422

URL: http://svn.apache.org/viewvc?rev=798422&view=rev
Log:
Remove unnecessary code. Changed test from:
if ((to == -1) || (to == termnator)) {
to:
if (to == termnator) {
since we are guaranteed to find the separator because we have tested for its presence at the begining of the method.


Modified:
    commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java

Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java?rev=798422&r1=798421&r2=798422&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java (original)
+++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/net/RFC1522Codec.java Tue Jul 28 07:13:01 2009
@@ -121,7 +121,7 @@
         int termnator = text.length() - 2;
         int from = 2;
         int to = text.indexOf(SEP, from);
-        if ((to == -1) || (to == termnator)) {
+        if (to == termnator) {
             throw new DecoderException("RFC 1522 violation: charset token not found");
         }
         String charset = text.substring(from, to);