You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/26 11:18:07 UTC
[GitHub] [airflow] jbampton opened a new pull request #14479: Fix missing HTTPS on links
jbampton opened a new pull request #14479:
URL: https://github.com/apache/airflow/pull/14479
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14479: Fix missing HTTPS on link
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14479:
URL: https://github.com/apache/airflow/pull/14479#discussion_r583596241
##########
File path: README.md
##########
@@ -22,7 +22,7 @@
[](https://badge.fury.io/py/apache-airflow)
[](https://github.com/apache/airflow/actions)
[](https://codecov.io/github/apache/airflow?branch=master)
-[](http://www.apache.org/licenses/LICENSE-2.0.txt)
+[](http://www.apache.org/licenses/LICENSE-2.0.txt)
Review comment:
```suggestion
[](https://www.apache.org/licenses/LICENSE-2.0.txt)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14479: Fix missing HTTPS on links
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14479:
URL: https://github.com/apache/airflow/pull/14479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14479: Fix missing HTTPS on links
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14479:
URL: https://github.com/apache/airflow/pull/14479#discussion_r583586014
##########
File path: tests/providers/google/cloud/hooks/test_gcs.py
##########
@@ -55,7 +55,7 @@ def test_parse_gcs_url(self):
with pytest.raises(AirflowException):
gcs._parse_gcs_url('gs:/bucket/path/to/blob')
with pytest.raises(AirflowException):
- gcs._parse_gcs_url('http://google.com/aaa')
+ gcs._parse_gcs_url('https://google.com/aaa')
Review comment:
This does not matter at all -- it's in tests but well not an issue either
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org