You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by an...@apache.org on 2015/12/16 05:31:45 UTC
[1/2] libcloud git commit: Fixed error when proxy_url is None.
Repository: libcloud
Updated Branches:
refs/heads/trunk 3e85cf159 -> 66f161739
Fixed error when proxy_url is None.
Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/f755d559
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/f755d559
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/f755d559
Branch: refs/heads/trunk
Commit: f755d5597793bc8f3109f09e6b39c4ace2d740bf
Parents: 3e85cf1
Author: Juan Font Alonso <ju...@gmail.com>
Authored: Thu Dec 10 14:44:43 2015 +0100
Committer: anthony-shaw <an...@gmail.com>
Committed: Wed Dec 16 15:30:43 2015 +1100
----------------------------------------------------------------------
libcloud/compute/drivers/vcloud.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/libcloud/blob/f755d559/libcloud/compute/drivers/vcloud.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/vcloud.py b/libcloud/compute/drivers/vcloud.py
index efe33e4..caf462a 100644
--- a/libcloud/compute/drivers/vcloud.py
+++ b/libcloud/compute/drivers/vcloud.py
@@ -848,7 +848,8 @@ class VCloud_1_5_Connection(VCloudConnection):
'application/vnd.vmware.vcloud.orgList+xml')).get('href')
)
- self.connection.set_http_proxy(self.proxy_url)
+ if self.proxy_url:
+ self.connection.set_http_proxy(self.proxy_url)
self.connection.request(method='GET', url=org_list_url,
headers=self.add_default_headers({}))
body = ET.XML(self.connection.getresponse().read())
[2/2] libcloud git commit: Compare strictly to None
Posted by an...@apache.org.
Compare strictly to None
Follow the coding standards better by using a strict comparison to None.
Closes #657
Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/66f16173
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/66f16173
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/66f16173
Branch: refs/heads/trunk
Commit: 66f1617393904b7dd160a73df32acab71ba708cb
Parents: f755d55
Author: Juan Font <ju...@gmail.com>
Authored: Thu Dec 10 15:03:14 2015 +0100
Committer: anthony-shaw <an...@gmail.com>
Committed: Wed Dec 16 15:30:49 2015 +1100
----------------------------------------------------------------------
libcloud/compute/drivers/vcloud.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/libcloud/blob/66f16173/libcloud/compute/drivers/vcloud.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/vcloud.py b/libcloud/compute/drivers/vcloud.py
index caf462a..0d0f208 100644
--- a/libcloud/compute/drivers/vcloud.py
+++ b/libcloud/compute/drivers/vcloud.py
@@ -848,7 +848,7 @@ class VCloud_1_5_Connection(VCloudConnection):
'application/vnd.vmware.vcloud.orgList+xml')).get('href')
)
- if self.proxy_url:
+ if self.proxy_url is not None:
self.connection.set_http_proxy(self.proxy_url)
self.connection.request(method='GET', url=org_list_url,
headers=self.add_default_headers({}))