You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@usergrid.apache.org by to...@apache.org on 2014/11/12 00:04:10 UTC
[1/4] incubator-usergrid git commit: Fixes test setup. Tests still
broken
Repository: incubator-usergrid
Updated Branches:
refs/heads/es-type-updates-ryan-external 0fc8818b8 -> 12b502865
Fixes test setup. Tests still broken
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/8ae98f82
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/8ae98f82
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/8ae98f82
Branch: refs/heads/es-type-updates-ryan-external
Commit: 8ae98f82f87c2ee632de0de5436d7b29931b8294
Parents: 500a327
Author: Todd Nine <tn...@apigee.com>
Authored: Mon Nov 10 18:12:43 2014 -0700
Committer: Todd Nine <tn...@apigee.com>
Committed: Mon Nov 10 18:12:43 2014 -0700
----------------------------------------------------------------------
.../org/apache/usergrid/persistence/GeoIT.java | 25 +++++++-------------
1 file changed, 8 insertions(+), 17 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/8ae98f82/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java b/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
index e07eeda..7e4493c 100644
--- a/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
+++ b/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
@@ -52,10 +52,10 @@ public class GeoIT extends AbstractCoreIT {
public void testGeo() throws Exception {
LOG.info( "GeoIT.testGeo" );
- UUID applicationId = setup.createApplication( "testOrganization", "testGeo" );
- assertNotNull( applicationId );
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+
+
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
// create user at a location
@@ -212,10 +212,8 @@ public class GeoIT extends AbstractCoreIT {
@Test
public void testPointPaging() throws Exception {
- UUID applicationId = setup.createApplication( "testOrganization", "testPointPaging" );
- assertNotNull( applicationId );
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
// save objects in a diagonal line from -90 -180 to 90 180
@@ -276,10 +274,7 @@ public class GeoIT extends AbstractCoreIT {
@Test
public void testSamePointPaging() throws Exception {
- UUID applicationId = setup.createApplication( "testOrganization", "testSamePointPaging" );
- assertNotNull( applicationId );
-
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
// save objects in a diagonal line from -90 -180 to 90 180
@@ -326,10 +321,9 @@ public class GeoIT extends AbstractCoreIT {
@Test
public void testDistanceByLimit() throws Exception {
- UUID applicationId = setup.createApplication( "testOrganization", "testDistanceByLimit" );
- assertNotNull( applicationId );
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
// save objects in a diagonal line from -90 -180 to 90 180
@@ -445,10 +439,7 @@ public class GeoIT extends AbstractCoreIT {
@Test
public void testDenseSearch() throws Exception {
- UUID applicationId = setup.createApplication( "testOrganization", "testDenseSearch" );
- assertNotNull( applicationId );
-
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
// save objects in a diagonal line from -90 -180 to 90 180
[2/4] incubator-usergrid git commit: Merge branch
'es-type-updates-ryan-external' of
https://git-wip-us.apache.org/repos/asf/incubator-usergrid into
es-type-updates-ryan-external
Posted by to...@apache.org.
Merge branch 'es-type-updates-ryan-external' of https://git-wip-us.apache.org/repos/asf/incubator-usergrid into es-type-updates-ryan-external
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/de457e90
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/de457e90
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/de457e90
Branch: refs/heads/es-type-updates-ryan-external
Commit: de457e9026b7c92c697c6cb026c8554f16ebab92
Parents: 8ae98f8 0fc8818
Author: Todd Nine <tn...@apigee.com>
Authored: Tue Nov 11 09:16:45 2014 -0700
Committer: Todd Nine <tn...@apigee.com>
Committed: Tue Nov 11 09:16:45 2014 -0700
----------------------------------------------------------------------
.../apache/usergrid/rest/AbstractRestIT.java | 22 +-
.../apache/usergrid/rest/TestContextSetup.java | 10 +-
.../rest/management/OrganizationsIT.java | 328 +++++++++----------
.../usergrid/rest/test/security/TestUser.java | 3 +
4 files changed, 185 insertions(+), 178 deletions(-)
----------------------------------------------------------------------
[4/4] incubator-usergrid git commit: Cleaned up obscelete external
resources
Posted by to...@apache.org.
Cleaned up obscelete external resources
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/12b50286
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/12b50286
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/12b50286
Branch: refs/heads/es-type-updates-ryan-external
Commit: 12b502865fcd144a231ac3cf2d10b9f93c2248e8
Parents: 4164734
Author: Todd Nine <tn...@apigee.com>
Authored: Tue Nov 11 15:24:29 2014 -0700
Committer: Todd Nine <tn...@apigee.com>
Committed: Tue Nov 11 15:24:29 2014 -0700
----------------------------------------------------------------------
.../src/test/resources/usergrid-test.properties | 2 +-
.../usergrid/ConcurrentCoreIteratorITSuite.java | 2 +-
.../org/apache/usergrid/CoreITSetupImpl.java | 1 -
.../java/org/apache/usergrid/CoreITSuite.java | 2 +-
.../batch/job/AbstractSchedulerRuntimeIT.java | 6 +-
.../core/astyanax/ColumnNameIteratorTest.java | 21 ++--
.../MultiKeyColumnNameIteratorTest.java | 20 ++--
.../astyanax/MultiRowColumnIteratorTest.java | 20 ++--
.../core/cassandra/CassandraRule.java | 114 ------------------
.../persistence/core/test/ITRunner.java | 20 +---
.../graph/CommittedGraphManagerIT.java | 2 +-
.../persistence/graph/GraphManagerLoadTest.java | 4 +-
.../graph/GraphManagerShardConsistencyIT.java | 6 -
.../graph/GraphManagerShardingIT.java | 4 +-
.../graph/GraphManagerStressTest.java | 4 +-
.../graph/StorageGraphManagerIT.java | 2 +-
.../graph/guice/TestGraphModule.java | 2 +-
.../graph/impl/EdgeDeleteListenerTest.java | 6 +-
.../graph/impl/NodeDeleteListenerTest.java | 6 +-
.../graph/impl/stage/EdgeDeleteRepairTest.java | 4 +-
.../graph/impl/stage/EdgeMetaRepairTest.java | 6 +-
.../EdgeMetaDataSerializationProxyV2Test.java | 7 +-
.../EdgeMetaDataSerializationV1Test.java | 4 +-
.../EdgeMetaDataSerializationV2Test.java | 4 +-
.../EdgeSerializationChopTest.java | 4 +-
.../serialization/EdgeSerializationTest.java | 7 +-
.../serialization/NodeSerializationTest.java | 4 +-
.../PermanentSerializationTest.java | 2 +-
.../impl/shard/EdgeShardSerializationTest.java | 9 +-
.../NodeShardCounterSerializationTest.java | 8 +-
.../index/impl/CorePerformanceIT.java | 4 -
.../index/impl/ElasticSearchResource.java | 118 +------------------
.../impl/EntityConnectionIndexImplTest.java | 4 -
.../persistence/index/impl/EntityIndexTest.java | 6 +-
.../usergrid/launcher/EmbeddedServerHelper.java | 4 +-
35 files changed, 92 insertions(+), 347 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/config/src/test/resources/usergrid-test.properties
----------------------------------------------------------------------
diff --git a/stack/config/src/test/resources/usergrid-test.properties b/stack/config/src/test/resources/usergrid-test.properties
index cfa1f2f..5889625 100644
--- a/stack/config/src/test/resources/usergrid-test.properties
+++ b/stack/config/src/test/resources/usergrid-test.properties
@@ -59,7 +59,7 @@ cassandra.writecl=QUORUM
cassandra.lock.keyspace=Locks
elasticsearch.startup=external
-elasticsearch.cluster_name=test_cluster
+elasticsearch.cluster_name=usergrid
#Properties to control the number of buckets in the index.
usergrid.index.defaultbucketsize=20
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/core/src/test/java/org/apache/usergrid/ConcurrentCoreIteratorITSuite.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/ConcurrentCoreIteratorITSuite.java b/stack/core/src/test/java/org/apache/usergrid/ConcurrentCoreIteratorITSuite.java
index 273c6df..1312950 100644
--- a/stack/core/src/test/java/org/apache/usergrid/ConcurrentCoreIteratorITSuite.java
+++ b/stack/core/src/test/java/org/apache/usergrid/ConcurrentCoreIteratorITSuite.java
@@ -79,5 +79,5 @@ public class ConcurrentCoreIteratorITSuite {
public static CassandraResource cassandraResource = CassandraResource.newWithAvailablePorts( );
@ClassRule
- public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource().startEs();
+ public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource();
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/core/src/test/java/org/apache/usergrid/CoreITSetupImpl.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/CoreITSetupImpl.java b/stack/core/src/test/java/org/apache/usergrid/CoreITSetupImpl.java
index fbff413..b3cc046 100644
--- a/stack/core/src/test/java/org/apache/usergrid/CoreITSetupImpl.java
+++ b/stack/core/src/test/java/org/apache/usergrid/CoreITSetupImpl.java
@@ -80,7 +80,6 @@ public class CoreITSetupImpl implements CoreITSetup {
*/
protected void before( Description description ) throws Throwable {
LOG.info( "Setting up for {}", description.getDisplayName() );
- elasticSearchResource.startEs();
initialize();
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/core/src/test/java/org/apache/usergrid/CoreITSuite.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/CoreITSuite.java b/stack/core/src/test/java/org/apache/usergrid/CoreITSuite.java
index ccdcd98..ff06a80 100644
--- a/stack/core/src/test/java/org/apache/usergrid/CoreITSuite.java
+++ b/stack/core/src/test/java/org/apache/usergrid/CoreITSuite.java
@@ -51,7 +51,7 @@ public class CoreITSuite {
public static CassandraResource cassandraResource = CassandraResource.newWithAvailablePorts( );
@ClassRule
- public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource().startEs();
+ public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource();
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/core/src/test/java/org/apache/usergrid/batch/job/AbstractSchedulerRuntimeIT.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/batch/job/AbstractSchedulerRuntimeIT.java b/stack/core/src/test/java/org/apache/usergrid/batch/job/AbstractSchedulerRuntimeIT.java
index 5e7288b..cc31d2d 100644
--- a/stack/core/src/test/java/org/apache/usergrid/batch/job/AbstractSchedulerRuntimeIT.java
+++ b/stack/core/src/test/java/org/apache/usergrid/batch/job/AbstractSchedulerRuntimeIT.java
@@ -29,6 +29,7 @@ import org.apache.usergrid.persistence.index.impl.ElasticSearchResource;
import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
+import org.junit.ClassRule;
/**
@@ -42,8 +43,11 @@ public class AbstractSchedulerRuntimeIT {
protected static final String RUNLOOP_PROP = "usergrid.scheduler.job.interval";
protected static final String FAIL_PROP = "usergrid.scheduler.job.maxfail";
+ @ClassRule
public static CassandraResource cassandraResource = SchedulerITSuite.cassandraResource;
- public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource().startEs();
+
+ @ClassRule
+ public static ElasticSearchResource elasticSearchResource = new ElasticSearchResource();
private TestJobListener listener = new TestJobListener();
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/ColumnNameIteratorTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/ColumnNameIteratorTest.java b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/ColumnNameIteratorTest.java
index 2522f33..547c504 100644
--- a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/ColumnNameIteratorTest.java
+++ b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/ColumnNameIteratorTest.java
@@ -24,14 +24,18 @@ package org.apache.usergrid.persistence.core.astyanax;
import java.util.HashMap;
+import org.junit.Before;
import org.junit.BeforeClass;
-import org.junit.ClassRule;
import org.junit.Test;
+import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
+import org.apache.usergrid.persistence.core.guice.TestCommonModule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.model.util.UUIDGenerator;
+import com.google.inject.Inject;
import com.netflix.astyanax.Keyspace;
import com.netflix.astyanax.MutationBatch;
import com.netflix.astyanax.connectionpool.exceptions.ConnectionException;
@@ -46,11 +50,14 @@ import com.netflix.astyanax.util.RangeBuilder;
import static org.junit.Assert.assertEquals;
+
+@RunWith( ITRunner.class )
+@UseModules( TestCommonModule.class )
public class ColumnNameIteratorTest {
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
+ @Inject
+ public CassandraFig cassandraFig;
protected static Keyspace keyspace;
@@ -62,8 +69,8 @@ public class ColumnNameIteratorTest {
protected static final boolean TRUE = true;
- @BeforeClass
- public static void setup() throws ConnectionException {
+ @Before
+ public void setup() throws ConnectionException {
final CassandraConfig cassandraConfig = new CassandraConfig() {
@@ -87,7 +94,7 @@ public class ColumnNameIteratorTest {
AstyanaxKeyspaceProvider astyanaxKeyspaceProvider =
- new AstyanaxKeyspaceProvider( rule.getCassandraFig(), cassandraConfig );
+ new AstyanaxKeyspaceProvider( cassandraFig, cassandraConfig );
keyspace = astyanaxKeyspaceProvider.get();
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiKeyColumnNameIteratorTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiKeyColumnNameIteratorTest.java b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiKeyColumnNameIteratorTest.java
index 61b9e54..a96db39 100644
--- a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiKeyColumnNameIteratorTest.java
+++ b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiKeyColumnNameIteratorTest.java
@@ -26,14 +26,18 @@ import java.util.Arrays;
import java.util.Comparator;
import java.util.HashMap;
+import org.junit.Before;
import org.junit.BeforeClass;
-import org.junit.ClassRule;
import org.junit.Test;
+import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
+import org.apache.usergrid.persistence.core.guice.TestCommonModule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.model.util.UUIDGenerator;
+import com.google.inject.Inject;
import com.netflix.astyanax.Keyspace;
import com.netflix.astyanax.MutationBatch;
import com.netflix.astyanax.connectionpool.exceptions.ConnectionException;
@@ -52,10 +56,12 @@ import rx.functions.Func1;
import static org.junit.Assert.assertEquals;
+@RunWith( ITRunner.class )
+@UseModules( TestCommonModule.class )
public class MultiKeyColumnNameIteratorTest {
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
+ @Inject
+ public CassandraFig cassandraFig;
protected static Keyspace keyspace;
@@ -67,8 +73,8 @@ public class MultiKeyColumnNameIteratorTest {
protected static final boolean TRUE = true;
- @BeforeClass
- public static void setup() throws ConnectionException {
+ @Before
+ public void setup() throws ConnectionException {
final CassandraConfig cassandraConfig = new CassandraConfig() {
@@ -92,7 +98,7 @@ public class MultiKeyColumnNameIteratorTest {
AstyanaxKeyspaceProvider astyanaxKeyspaceProvider =
- new AstyanaxKeyspaceProvider( rule.getCassandraFig(), cassandraConfig );
+ new AstyanaxKeyspaceProvider( cassandraFig, cassandraConfig );
keyspace = astyanaxKeyspaceProvider.get();
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiRowColumnIteratorTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiRowColumnIteratorTest.java b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiRowColumnIteratorTest.java
index 04039e4..4530d4b 100644
--- a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiRowColumnIteratorTest.java
+++ b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/astyanax/MultiRowColumnIteratorTest.java
@@ -28,14 +28,18 @@ import java.util.Comparator;
import java.util.HashMap;
import java.util.concurrent.CountDownLatch;
+import org.junit.Before;
import org.junit.BeforeClass;
-import org.junit.ClassRule;
import org.junit.Test;
+import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
+import org.apache.usergrid.persistence.core.guice.TestCommonModule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.model.util.UUIDGenerator;
+import com.google.inject.Inject;
import com.netflix.astyanax.Keyspace;
import com.netflix.astyanax.MutationBatch;
import com.netflix.astyanax.connectionpool.exceptions.ConnectionException;
@@ -55,10 +59,12 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+@RunWith( ITRunner.class )
+@UseModules( TestCommonModule.class )
public class MultiRowColumnIteratorTest {
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
+ @Inject
+ public CassandraFig cassandraFig;
protected static Keyspace keyspace;
@@ -70,8 +76,8 @@ public class MultiRowColumnIteratorTest {
protected static final boolean TRUE = true;
- @BeforeClass
- public static void setup() throws ConnectionException {
+ @Before
+ public void setup() throws ConnectionException {
final CassandraConfig cassandraConfig = new CassandraConfig() {
@@ -95,7 +101,7 @@ public class MultiRowColumnIteratorTest {
AstyanaxKeyspaceProvider astyanaxKeyspaceProvider =
- new AstyanaxKeyspaceProvider( rule.getCassandraFig(), cassandraConfig );
+ new AstyanaxKeyspaceProvider( cassandraFig, cassandraConfig );
keyspace = astyanaxKeyspaceProvider.get();
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/cassandra/CassandraRule.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/cassandra/CassandraRule.java b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/cassandra/CassandraRule.java
deleted file mode 100644
index 68a56e4..0000000
--- a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/cassandra/CassandraRule.java
+++ /dev/null
@@ -1,114 +0,0 @@
-package org.apache.usergrid.persistence.core.cassandra;
-
-
-import com.google.common.io.Files;
-import com.google.inject.Guice;
-import com.google.inject.Injector;
-import com.netflix.astyanax.test.EmbeddedCassandra;
-import com.netflix.config.ConfigurationManager;
-
-import java.io.File;
-import java.io.IOException;
-import org.apache.cassandra.io.util.FileUtils;
-import org.apache.usergrid.persistence.core.astyanax.CassandraFig;
-import org.apache.usergrid.persistence.core.util.AvailablePortFinder;
-import org.safehaus.guicyfig.Env;
-import org.safehaus.guicyfig.EnvironResource;
-import org.safehaus.guicyfig.GuicyFigModule;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-
-/**
- * @TODO - I wanted this in the test module but unfortunately that will create a circular dep
- * due to the inclusion of the MigrationManager
- */
-public class CassandraRule extends EnvironResource {
- private static final Logger LOG = LoggerFactory.getLogger( CassandraRule.class );
-
- private static final Object mutex = new Object();
-
- private static EmbeddedCassandra cass;
-
- private static boolean started = false;
-
- private final CassandraFig cassandraFig;
-
- static{
- ConfigurationManager.getDeploymentContext().setDeploymentEnvironment( "UNIT" );
- try {
- ConfigurationManager.loadCascadedPropertiesFromResources( "usergrid" );
- }
- catch ( IOException e ) {
- throw new RuntimeException(e);
- }
- }
-
- public CassandraRule() {
- super( Env.UNIT );
-
- Injector injector = Guice.createInjector( new GuicyFigModule( CassandraFig.class ) );
- cassandraFig = injector.getInstance( CassandraFig.class );
- }
-
-
- /**
- * Get the cassandra fig
- * @return
- */
- public CassandraFig getCassandraFig(){
- return cassandraFig;
- }
-
- @Override
- public void before() throws Throwable {
-
- if ( !cassandraFig.isEmbedded()) {
- LOG.info("Using external Cassandra");
- return;
- }
-
- if ( started ) {
- return;
- }
-
- synchronized ( mutex ) {
-
- //second into mutex
- if(started){
- return;
- }
-
- File dataDir = Files.createTempDir();
- dataDir.deleteOnExit();
-
- //cleanup before we run, shouldn't be necessary, but had the directory exist during JVM kill
- if( dataDir.exists() ) {
- FileUtils.deleteRecursive( dataDir );
- }
-
- try {
- LOG.info( "Starting cassandra" );
-
- cass = new EmbeddedCassandra( dataDir, "Usergrid", 9160,
- AvailablePortFinder.getNextAvailable() );
- cass.start();
-
- LOG.info( "Cassandra boostrapped" );
-
- started = true;
- }
- catch ( IOException e ) {
- throw new RuntimeException( "Unable to start cassandra", e );
- }
- }
- }
-
-
- @Override
- protected void after() {
-
- //TODO TN. this should only really happen when we shut down
-// cass.stop();
- }
-}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/test/ITRunner.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/test/ITRunner.java b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/test/ITRunner.java
index 1a800ad..82587fd 100644
--- a/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/test/ITRunner.java
+++ b/stack/corepersistence/common/src/test/java/org/apache/usergrid/persistence/core/test/ITRunner.java
@@ -27,8 +27,6 @@ import org.junit.runners.model.FrameworkMethod;
import org.junit.runners.model.InitializationError;
import org.junit.runners.model.Statement;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
-
import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
@@ -36,25 +34,11 @@ import com.google.inject.Module;
/**
- * Run jukito with cassandra
+ * Run guice and inject it into our tests
*/
-public class ITRunner extends BlockJUnit4ClassRunner {// extends JukitoRunner {
-
- //this is fugly, but we have no other way to start cassandra before the jukito runner
- static{
- CassandraRule rule = new CassandraRule();
-
- try {
- rule.before();
- }
- catch ( Throwable throwable ) {
- //super nasty, but we need to bail if this happens
- throwable.printStackTrace();
- System.exit( -1 );
- }
+public class ITRunner extends BlockJUnit4ClassRunner {
- }
private Injector injector;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/CommittedGraphManagerIT.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/CommittedGraphManagerIT.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/CommittedGraphManagerIT.java
index fa366ad..b471119 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/CommittedGraphManagerIT.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/CommittedGraphManagerIT.java
@@ -21,10 +21,10 @@
package org.apache.usergrid.persistence.graph;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.model.entity.Id;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerLoadTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerLoadTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerLoadTest.java
index c312714..916bdaa 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerLoadTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerLoadTest.java
@@ -29,7 +29,6 @@ import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
@@ -41,9 +40,10 @@ import org.slf4j.LoggerFactory;
import org.apache.commons.lang3.time.StopWatch;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.core.scope.ApplicationScopeImpl;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.impl.SimpleSearchByEdgeType;
import org.apache.usergrid.persistence.model.entity.Id;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardConsistencyIT.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardConsistencyIT.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardConsistencyIT.java
index a748c05..0f25537 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardConsistencyIT.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardConsistencyIT.java
@@ -41,13 +41,11 @@ import javax.annotation.Nullable;
import org.junit.After;
import org.junit.Before;
-import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
import org.apache.usergrid.persistence.core.migration.schema.MigrationException;
import org.apache.usergrid.persistence.core.migration.schema.MigrationManager;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
@@ -85,10 +83,6 @@ import static org.junit.Assert.fail;
public class GraphManagerShardConsistencyIT {
private static final Logger log = LoggerFactory.getLogger( GraphManagerShardConsistencyIT.class );
-
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
-
private static final MetricRegistry registry = new MetricRegistry();
private static final Meter writeMeter = registry.meter( "writeThroughput" );
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardingIT.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardingIT.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardingIT.java
index e6231e0..dfda4b1 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardingIT.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerShardingIT.java
@@ -23,7 +23,6 @@ package org.apache.usergrid.persistence.graph;
import java.util.concurrent.TimeoutException;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
@@ -31,9 +30,10 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.core.scope.ApplicationScopeImpl;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.serialization.impl.shard.DirectedEdgeMeta;
import org.apache.usergrid.persistence.graph.serialization.impl.shard.NodeShardApproximation;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerStressTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerStressTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerStressTest.java
index 0ed0492..7b912a0 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerStressTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/GraphManagerStressTest.java
@@ -23,7 +23,6 @@ import java.util.HashSet;
import java.util.Set;
import java.util.concurrent.CountDownLatch;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
@@ -35,8 +34,9 @@ import org.slf4j.LoggerFactory;
import org.apache.commons.lang3.time.StopWatch;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.impl.SimpleSearchByEdgeType;
import org.apache.usergrid.persistence.model.entity.Id;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/StorageGraphManagerIT.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/StorageGraphManagerIT.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/StorageGraphManagerIT.java
index cb9726d..6f3d388 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/StorageGraphManagerIT.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/StorageGraphManagerIT.java
@@ -23,13 +23,13 @@ package org.apache.usergrid.persistence.graph;
import java.util.concurrent.atomic.AtomicInteger;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.runner.RunWith;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.impl.GraphManagerImpl;
import org.apache.usergrid.persistence.model.entity.Id;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/guice/TestGraphModule.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/guice/TestGraphModule.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/guice/TestGraphModule.java
index bbcfa6e..87a0f6c 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/guice/TestGraphModule.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/guice/TestGraphModule.java
@@ -19,8 +19,8 @@
package org.apache.usergrid.persistence.graph.guice;
-import org.apache.usergrid.persistence.core.guice.TestModule;
import org.apache.usergrid.persistence.core.guice.CommonModule;
+import org.apache.usergrid.persistence.core.guice.TestModule;
/**
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/EdgeDeleteListenerTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/EdgeDeleteListenerTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/EdgeDeleteListenerTest.java
index 0a1fe52..f5e9dc8 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/EdgeDeleteListenerTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/EdgeDeleteListenerTest.java
@@ -24,8 +24,6 @@ package org.apache.usergrid.persistence.graph.impl;
import java.util.Iterator;
import java.util.UUID;
-import org.apache.usergrid.persistence.core.guice.ProxyImpl;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
@@ -34,8 +32,10 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.guice.ProxyImpl;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.GraphFig;
import org.apache.usergrid.persistence.graph.GraphManagerFactory;
import org.apache.usergrid.persistence.graph.MarkedEdge;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/NodeDeleteListenerTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/NodeDeleteListenerTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/NodeDeleteListenerTest.java
index f325620..aa5ae5f 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/NodeDeleteListenerTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/NodeDeleteListenerTest.java
@@ -22,8 +22,6 @@ package org.apache.usergrid.persistence.graph.impl;
import java.util.Iterator;
import java.util.UUID;
-import org.apache.usergrid.persistence.core.guice.ProxyImpl;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
@@ -33,8 +31,10 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.guice.ProxyImpl;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.Edge;
import org.apache.usergrid.persistence.graph.GraphFig;
import org.apache.usergrid.persistence.graph.GraphManager;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeDeleteRepairTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeDeleteRepairTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeDeleteRepairTest.java
index 1f300b1..d27aca7 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeDeleteRepairTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeDeleteRepairTest.java
@@ -22,7 +22,6 @@ package org.apache.usergrid.persistence.graph.impl.stage;
import java.util.Iterator;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
@@ -31,8 +30,9 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.MarkedEdge;
import org.apache.usergrid.persistence.graph.SearchByEdgeType;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeMetaRepairTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeMetaRepairTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeMetaRepairTest.java
index f4711d3..156d1d0 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeMetaRepairTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/impl/stage/EdgeMetaRepairTest.java
@@ -24,16 +24,16 @@ import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;
-import org.apache.usergrid.persistence.core.guice.ProxyImpl;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.guice.ProxyImpl;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.GraphFig;
import org.apache.usergrid.persistence.graph.MarkedEdge;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationProxyV2Test.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationProxyV2Test.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationProxyV2Test.java
index 2661c19..ea03b44 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationProxyV2Test.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationProxyV2Test.java
@@ -22,15 +22,14 @@
package org.apache.usergrid.persistence.graph.serialization;
-import org.apache.usergrid.persistence.core.migration.data.MigrationInfoSerialization;
-import org.apache.usergrid.persistence.core.test.UseModules;
-
import org.junit.After;
import org.junit.Before;
import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.guice.ProxyImpl;
+import org.apache.usergrid.persistence.core.migration.data.MigrationInfoSerialization;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.serialization.impl.EdgeMetadataSerializationProxyImpl;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV1Test.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV1Test.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV1Test.java
index 66a0902..068b27a 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV1Test.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV1Test.java
@@ -39,11 +39,11 @@ package org.apache.usergrid.persistence.graph.serialization;/*
*/
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.guice.PreviousImpl;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.serialization.impl.EdgeMetadataSerializationV1Impl;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV2Test.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV2Test.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV2Test.java
index db41059..1fba055 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV2Test.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeMetaDataSerializationV2Test.java
@@ -22,11 +22,11 @@
package org.apache.usergrid.persistence.graph.serialization;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.runner.RunWith;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.guice.CurrentImpl;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.serialization.impl.EdgeMetadataSerializationV2Impl;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationChopTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationChopTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationChopTest.java
index b4e5241..9dd362f 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationChopTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationChopTest.java
@@ -22,15 +22,15 @@ package org.apache.usergrid.persistence.graph.serialization;
import java.util.Iterator;
import java.util.UUID;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.MarkedEdge;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.model.entity.Id;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationTest.java
index 161df44..69d0a20 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/EdgeSerializationTest.java
@@ -26,7 +26,6 @@ import java.util.Set;
import java.util.UUID;
import org.junit.Before;
-import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
@@ -34,7 +33,6 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.graph.Edge;
import org.apache.usergrid.persistence.graph.GraphFig;
@@ -72,14 +70,11 @@ import static org.mockito.Mockito.when;
*
*
*/
+
public abstract class EdgeSerializationTest {
private static final Logger log = LoggerFactory.getLogger( EdgeSerializationTest.class );
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
-
-
@Inject
@Rule
public MigrationManagerRule migrationManagerRule;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/NodeSerializationTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/NodeSerializationTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/NodeSerializationTest.java
index 0736209..2391192 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/NodeSerializationTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/NodeSerializationTest.java
@@ -22,15 +22,15 @@ package org.apache.usergrid.persistence.graph.serialization;
import java.util.Arrays;
import java.util.Map;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.model.entity.Id;
import org.apache.usergrid.persistence.model.util.UUIDGenerator;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/PermanentSerializationTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/PermanentSerializationTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/PermanentSerializationTest.java
index 9fb40ca..d850f76 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/PermanentSerializationTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/PermanentSerializationTest.java
@@ -20,10 +20,10 @@
package org.apache.usergrid.persistence.graph.serialization;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import com.google.inject.Inject;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/EdgeShardSerializationTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/EdgeShardSerializationTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/EdgeShardSerializationTest.java
index 133571a..cdac709 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/EdgeShardSerializationTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/EdgeShardSerializationTest.java
@@ -22,17 +22,15 @@ package org.apache.usergrid.persistence.graph.serialization.impl.shard;
import java.util.Iterator;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
-import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.model.entity.Id;
import org.apache.usergrid.persistence.model.util.UUIDGenerator;
@@ -53,9 +51,6 @@ import static org.mockito.Mockito.when;
@UseModules({ TestGraphModule.class })
public class EdgeShardSerializationTest {
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
-
@Inject
@Rule
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/count/NodeShardCounterSerializationTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/count/NodeShardCounterSerializationTest.java b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/count/NodeShardCounterSerializationTest.java
index a7a281c..a443086 100644
--- a/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/count/NodeShardCounterSerializationTest.java
+++ b/stack/corepersistence/graph/src/test/java/org/apache/usergrid/persistence/graph/serialization/impl/shard/count/NodeShardCounterSerializationTest.java
@@ -19,7 +19,6 @@
package org.apache.usergrid.persistence.graph.serialization.impl.shard.count;
-import org.apache.usergrid.persistence.core.test.UseModules;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Rule;
@@ -29,9 +28,9 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
-import org.apache.usergrid.persistence.core.test.ITRunner;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.core.test.ITRunner;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.graph.GraphFig;
import org.apache.usergrid.persistence.graph.guice.TestGraphModule;
import org.apache.usergrid.persistence.graph.serialization.EdgeSerialization;
@@ -56,9 +55,6 @@ public class NodeShardCounterSerializationTest {
private static final Logger log = LoggerFactory.getLogger( NodeShardCounterSerializationTest.class );
- @ClassRule
- public static CassandraRule rule = new CassandraRule();
-
@Inject
@Rule
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/CorePerformanceIT.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/CorePerformanceIT.java b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/CorePerformanceIT.java
index 2f71e2e..6d09ccb 100644
--- a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/CorePerformanceIT.java
+++ b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/CorePerformanceIT.java
@@ -38,7 +38,6 @@ import org.apache.usergrid.persistence.collection.CollectionScope;
import org.apache.usergrid.persistence.collection.EntityCollectionManager;
import org.apache.usergrid.persistence.collection.EntityCollectionManagerFactory;
import org.apache.usergrid.persistence.collection.impl.CollectionScopeImpl;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.core.scope.ApplicationScopeImpl;
import org.apache.usergrid.persistence.index.EntityIndex;
@@ -72,9 +71,6 @@ public class CorePerformanceIT extends BaseIT {
@ClassRule
public static ElasticSearchResource es = new ElasticSearchResource();
- @ClassRule
- public static CassandraRule cass = new CassandraRule();
-
// max entities we will write and read
static int maxEntities = 10; // TODO: make this configurable when you add Chop
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/ElasticSearchResource.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/ElasticSearchResource.java b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/ElasticSearchResource.java
index 661547a..1f04303 100644
--- a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/ElasticSearchResource.java
+++ b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/ElasticSearchResource.java
@@ -45,14 +45,10 @@ import com.google.inject.Injector;
public class ElasticSearchResource extends EnvironResource {
- private static final Logger log = LoggerFactory.getLogger( ElasticSearchResource.class );
-
- private static Node node;
private static int port;
private static String host;
-
- private static boolean externalElasticSearch = false;
+
@@ -64,8 +60,6 @@ public class ElasticSearchResource extends EnvironResource {
host=(String)props.getProperty( "elasticsearch.host", "127.0.0.1" );
port=Integer.valueOf(props.getProperty( "elasticsearch.port", "9300" )).intValue();
String forkString = props.getProperty("elasticsearch.startup", "external");
- externalElasticSearch = "external".equals( forkString );
-
} catch (Exception ex) {
throw new RuntimeException("Error getting properties", ex);
}
@@ -74,14 +68,8 @@ public class ElasticSearchResource extends EnvironResource {
@Override
protected void before() throws Throwable {
- if(externalElasticSearch){
System.setProperty( IndexFig.ELASTICSEARCH_HOSTS, host );
- System.setProperty( IndexFig.ELASTICSEARCH_PORT, port+"" );
-
- }else{
- startEs();
- }
- }
+ System.setProperty( IndexFig.ELASTICSEARCH_PORT, port+"" ); }
@@ -91,106 +79,4 @@ public class ElasticSearchResource extends EnvironResource {
}
- public synchronized ElasticSearchResource startEs(){
-
-//
-// if ( node != null ) {
-// return this;
-// }
-//
-//
-// //override the system properties in the Archiaus env
-// port = AvailablePortFinder.getNextAvailable( 9300 );
-//
-// final String host = "127.0.0.1";
-// System.setProperty( IndexFig.ELASTICSEARCH_HOSTS, host );
-// System.setProperty( IndexFig.ELASTICSEARCH_PORT, port + "" );
-//
-// //we have to create this AFTER we set our system properties, or they won't get picked upt
-// Injector injector = Guice.createInjector( new GuicyFigModule( IndexFig.class ) );
-// IndexFig indexFig = injector.getInstance( IndexFig.class );
-//
-//
-// final String clusterName = indexFig.getClusterName();
-//
-// File tempDir;
-// try {
-// tempDir = getTempDirectory();
-// }
-// catch ( Exception ex ) {
-// throw new RuntimeException( "Fatal error unable to create temp dir, start embedded ElasticSearch", ex );
-// }
-//
-//
-// Settings settings = ImmutableSettings.settingsBuilder()
-// .put("cluster.name", clusterName)
-// .put("network.publish_host", host)
-// .put("transport.tcp.port", port)
-// .put("discovery.zen.ping.multicast.enabled", "false")
-// .put("node.http.enabled", false)
-// .put("path.logs", tempDir.toString())
-// .put("path.data", tempDir.toString())
-// .put("index.store.type", "default")
-// .put("index.number_of_shards", 1)
-// .put("index.number_of_replicas", 1)
-// .build();
-//
-//
-// log.info( "-----------------------------------------------------------------------" );
-// log.info( "Starting ElasticSearch embedded server settings: \n" + settings.getAsMap() );
-// log.info( "-----------------------------------------------------------------------" );
-//
-//
-// node = NodeBuilder.nodeBuilder().settings( settings ).clusterName( indexFig.getClusterName() ).client( false ).data( true ).build().start();
-//
-// Runtime.getRuntime().addShutdownHook( new Thread() {
-// @Override
-// public void run() {
-// shutdown();
-// }
-// } );
-//
-// return this;
- return this;
- }
-
-
- public static void shutdown() {
- if(!externalElasticSearch){
- node.stop();
- }
- }
-
-
-
-
- /**
- * Uses a project.properties file that Maven does substitution on to to replace the value of a property with the
- * path to the Maven build directory (a.k.a. target). It then uses this path to generate a random String which it
- * uses to append a path component to so a unique directory is selected. If already present it's deleted, then the
- * directory is created.
- *
- * @return a unique temporary directory
- *
- * @throws java.io.IOException if we cannot access the properties file
- */
- public static File getTempDirectory() throws IOException {
- File tmpdir;
- Properties props = new Properties();
- props.load( ClassLoader.getSystemResourceAsStream( "project.properties" ) );
- File basedir = new File( ( String ) props.get( "target.directory" ) );
- String comp = RandomStringUtils.randomAlphanumeric( 7 );
- tmpdir = new File( basedir, comp );
-
- if ( tmpdir.exists() ) {
- log.info( "Deleting directory: {}", tmpdir );
- FileUtils.forceDelete( tmpdir );
- }
- else {
- log.info( "Creating temporary directory: {}", tmpdir );
- FileUtils.forceMkdir( tmpdir );
- }
-
- return tmpdir;
- }
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityConnectionIndexImplTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityConnectionIndexImplTest.java b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityConnectionIndexImplTest.java
index d2423bb..20dcbde 100644
--- a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityConnectionIndexImplTest.java
+++ b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityConnectionIndexImplTest.java
@@ -21,16 +21,12 @@ package org.apache.usergrid.persistence.index.impl;
import java.io.IOException;
import java.util.HashMap;
-import org.junit.ClassRule;
-import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
import org.apache.usergrid.persistence.collection.util.EntityUtils;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.core.scope.ApplicationScopeImpl;
import org.apache.usergrid.persistence.core.test.UseModules;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityIndexTest.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityIndexTest.java b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityIndexTest.java
index 72058ff..2b9ea62 100644
--- a/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityIndexTest.java
+++ b/stack/corepersistence/queryindex/src/test/java/org/apache/usergrid/persistence/index/impl/EntityIndexTest.java
@@ -25,9 +25,6 @@ import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
-import org.apache.usergrid.persistence.core.test.UseModules;
-import org.junit.ClassRule;
-import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.slf4j.Logger;
@@ -35,11 +32,10 @@ import org.slf4j.LoggerFactory;
import org.apache.commons.lang3.time.StopWatch;
-import org.apache.usergrid.persistence.collection.guice.MigrationManagerRule;
import org.apache.usergrid.persistence.collection.util.EntityUtils;
-import org.apache.usergrid.persistence.core.cassandra.CassandraRule;
import org.apache.usergrid.persistence.core.scope.ApplicationScope;
import org.apache.usergrid.persistence.core.scope.ApplicationScopeImpl;
+import org.apache.usergrid.persistence.core.test.UseModules;
import org.apache.usergrid.persistence.core.util.Health;
import org.apache.usergrid.persistence.index.EntityIndex;
import org.apache.usergrid.persistence.index.EntityIndexBatch;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/12b50286/stack/launcher/src/main/java/org/apache/usergrid/launcher/EmbeddedServerHelper.java
----------------------------------------------------------------------
diff --git a/stack/launcher/src/main/java/org/apache/usergrid/launcher/EmbeddedServerHelper.java b/stack/launcher/src/main/java/org/apache/usergrid/launcher/EmbeddedServerHelper.java
index c7669d8..b3b72c2 100644
--- a/stack/launcher/src/main/java/org/apache/usergrid/launcher/EmbeddedServerHelper.java
+++ b/stack/launcher/src/main/java/org/apache/usergrid/launcher/EmbeddedServerHelper.java
@@ -68,7 +68,7 @@ public class EmbeddedServerHelper {
log.info( "Starting executor" );
- executor.execute( new CassandraRunner() );
+ executor.execute( new ITRunner() );
log.info( "Started executor" );
}
else {
@@ -180,7 +180,7 @@ public class EmbeddedServerHelper {
}
- class CassandraRunner implements Runnable {
+ class ITRunner implements Runnable {
@Override
public void run() {
[3/4] incubator-usergrid git commit: Fixed GeoIT.
Posted by to...@apache.org.
Fixed GeoIT.
Cleaned up Query class
Harded search methods. Input validation was not done to ensure we have minimum data to execute queries.
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/41647349
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/41647349
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/41647349
Branch: refs/heads/es-type-updates-ryan-external
Commit: 41647349fe9735108a8ae99ca95d9c4448df9d30
Parents: de457e9
Author: Todd Nine <tn...@apigee.com>
Authored: Tue Nov 11 14:42:15 2014 -0700
Committer: Todd Nine <tn...@apigee.com>
Committed: Tue Nov 11 14:42:15 2014 -0700
----------------------------------------------------------------------
.../corepersistence/CpRelationManager.java | 19 +++--
.../corepersistence/util/CpNamingUtils.java | 2 +-
.../cassandra/RelationManagerImpl.java | 18 ++---
.../org/apache/usergrid/persistence/GeoIT.java | 9 +--
.../apache/usergrid/persistence/QueryTest.java | 15 ++++
stack/corepersistence/pom.xml | 2 +-
.../usergrid/persistence/index/SearchTypes.java | 21 ++++-
.../index/impl/EsEntityIndexImpl.java | 26 ++++--
.../usergrid/persistence/index/query/Query.java | 84 +++++++++++---------
stack/pom.xml | 7 --
stack/test-utils/pom.xml | 5 --
11 files changed, 125 insertions(+), 83 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/core/src/main/java/org/apache/usergrid/corepersistence/CpRelationManager.java
----------------------------------------------------------------------
diff --git a/stack/core/src/main/java/org/apache/usergrid/corepersistence/CpRelationManager.java b/stack/core/src/main/java/org/apache/usergrid/corepersistence/CpRelationManager.java
index 561c269..9a729b8 100644
--- a/stack/core/src/main/java/org/apache/usergrid/corepersistence/CpRelationManager.java
+++ b/stack/core/src/main/java/org/apache/usergrid/corepersistence/CpRelationManager.java
@@ -106,6 +106,7 @@ import org.apache.usergrid.utils.IndexUtils;
import org.apache.usergrid.utils.MapUtils;
import org.apache.usergrid.utils.UUIDUtils;
+import com.google.common.base.Preconditions;
import com.yammer.metrics.annotation.Metered;
import me.prettyprint.hector.api.Keyspace;
@@ -418,7 +419,7 @@ public class CpRelationManager implements RelationManager {
}
else {
- String connName = CpNamingUtils.getCollectionName( edge.getType() );
+ String connName = CpNamingUtils.getConnectionType( edge.getType() );
indexScope =
new IndexScopeImpl( new SimpleId( sourceEntity.getUuid(), sourceEntity.getType() ),
CpNamingUtils.getConnectionScopeName( connName ) );
@@ -1432,14 +1433,20 @@ public class CpRelationManager implements RelationManager {
@Override
public Results searchConnectedEntities( Query query ) throws Exception {
- if ( query == null ) {
- query = new Query();
- }
+ Preconditions.checkNotNull(query, "query cannot be null");
+
+ final String connection = query.getConnectionType();
+
+ Preconditions.checkNotNull( connection, "connection must be specified" );
+
+// if ( query == null ) {
+// query = new Query();
+// }
headEntity = em.validate( headEntity );
final IndexScope indexScope = new IndexScopeImpl( cpHeadEntity.getId(),
- CpNamingUtils.getConnectionScopeName( query.getConnectionType() ) );
+ CpNamingUtils.getConnectionScopeName( connection ) );
final SearchTypes searchTypes = SearchTypes.fromNullableTypes( query.getEntityType() );
@@ -1452,7 +1459,7 @@ public class CpRelationManager implements RelationManager {
query = adjustQuery( query );
CandidateResults crs = ei.search( indexScope, searchTypes, query );
- return buildConnectionResults( query, crs, query.getConnectionType() );
+ return buildConnectionResults( query, crs, connection );
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/core/src/main/java/org/apache/usergrid/corepersistence/util/CpNamingUtils.java
----------------------------------------------------------------------
diff --git a/stack/core/src/main/java/org/apache/usergrid/corepersistence/util/CpNamingUtils.java b/stack/core/src/main/java/org/apache/usergrid/corepersistence/util/CpNamingUtils.java
index cf27203..9154752 100644
--- a/stack/core/src/main/java/org/apache/usergrid/corepersistence/util/CpNamingUtils.java
+++ b/stack/core/src/main/java/org/apache/usergrid/corepersistence/util/CpNamingUtils.java
@@ -66,7 +66,7 @@ public class CpNamingUtils {
}
- static public String getConnectionType( String edgeType ) {
+ static public String getConnectionType( String edgeType ) {
String[] parts = edgeType.split( "\\|" );
return parts[1];
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/core/src/main/java/org/apache/usergrid/persistence/cassandra/RelationManagerImpl.java
----------------------------------------------------------------------
diff --git a/stack/core/src/main/java/org/apache/usergrid/persistence/cassandra/RelationManagerImpl.java b/stack/core/src/main/java/org/apache/usergrid/persistence/cassandra/RelationManagerImpl.java
index 53bef80..be84176 100644
--- a/stack/core/src/main/java/org/apache/usergrid/persistence/cassandra/RelationManagerImpl.java
+++ b/stack/core/src/main/java/org/apache/usergrid/persistence/cassandra/RelationManagerImpl.java
@@ -80,11 +80,9 @@ import org.apache.usergrid.persistence.schema.CollectionInfo;
import org.apache.usergrid.utils.IndexUtils;
import org.apache.usergrid.utils.MapUtils;
+import com.google.common.base.Preconditions;
import com.yammer.metrics.annotation.Metered;
-import me.prettyprint.cassandra.serializers.ByteBufferSerializer;
-import me.prettyprint.cassandra.serializers.StringSerializer;
-import me.prettyprint.cassandra.serializers.UUIDSerializer;
import me.prettyprint.hector.api.Keyspace;
import me.prettyprint.hector.api.beans.DynamicComposite;
import me.prettyprint.hector.api.beans.HColumn;
@@ -139,7 +137,7 @@ import static org.apache.usergrid.utils.InflectionUtils.singularize;
import static org.apache.usergrid.utils.MapUtils.addMapSet;
import static org.apache.usergrid.utils.UUIDUtils.getTimestampInMicros;
import static org.apache.usergrid.utils.UUIDUtils.newTimeUUID;
-import static org.apache.usergrid.persistence.cassandra.Serializers.*;
+
import org.apache.usergrid.persistence.entities.Application;
import org.apache.usergrid.persistence.index.query.Query.Level;
@@ -2037,12 +2035,14 @@ public class RelationManagerImpl implements RelationManager {
@Metered(group = "core", name = "RelationManager_searchConnectedEntities")
public Results searchConnectedEntities( Query query ) throws Exception {
- if ( query == null ) {
- query = new Query();
- }
+ Preconditions.checkNotNull(query, "Query must not be null");
+
+
+ final String connectedEntityType = query.getEntityType();
+ final String connectionType = query.getConnectionType();
- String connectedEntityType = query.getEntityType();
- String connectionType = query.getConnectionType();
+ Preconditions.checkNotNull( connectedEntityType, "entityType must not be null" );
+ Preconditions.checkNotNull( connectionType, "connectionType must not be null" );
headEntity = em.validate( headEntity );
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java b/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
index 7e4493c..39e39b2 100644
--- a/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
+++ b/stack/core/src/test/java/org/apache/usergrid/persistence/GeoIT.java
@@ -200,11 +200,11 @@ public class GeoIT extends AbstractCoreIT {
em.refreshIndex();
emSearchResults = em.searchConnectedEntities( user,
- Query.fromQL( "location within 2000 of 37.776753, -122.407846" ) );
+ Query.fromQL( "location within 2000 of 37.776753, -122.407846" ).setConnectionType( "likes" ) );
assertEquals( 1, emSearchResults.size() );
emSearchResults = em.searchConnectedEntities( user,
- Query.fromQL( "location within 1000 of 37.776753, -122.407846" ) );
+ Query.fromQL( "location within 1000 of 37.776753, -122.407846" ).setConnectionType( "likes" ) );
assertEquals( 0, emSearchResults.size() );
}
@@ -380,10 +380,7 @@ public class GeoIT extends AbstractCoreIT {
@Test
public void testGeoWithIntersection() throws Exception {
- UUID applicationId = setup.createApplication( "testOrganization", "testGeoWithIntersection" );
- assertNotNull( applicationId );
-
- EntityManager em = setup.getEmf().getEntityManager( applicationId );
+ EntityManager em = app.getEntityManager();
assertNotNull( em );
int size = 100;
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/core/src/test/java/org/apache/usergrid/persistence/QueryTest.java
----------------------------------------------------------------------
diff --git a/stack/core/src/test/java/org/apache/usergrid/persistence/QueryTest.java b/stack/core/src/test/java/org/apache/usergrid/persistence/QueryTest.java
index 42489c3..e8cb7d4 100644
--- a/stack/core/src/test/java/org/apache/usergrid/persistence/QueryTest.java
+++ b/stack/core/src/test/java/org/apache/usergrid/persistence/QueryTest.java
@@ -128,6 +128,21 @@ public class QueryTest {
assertEquals( 5, ( ( LongLiteral ) equal.getLiteral() ).getValue().intValue() );
}
+ @Test
+ public void withinDistanceCorrect(){
+ final Query query = Query.fromQL( "location within 2000 of 37.776753, -122.407846" );
+
+ WithinOperand withinOperand = ( WithinOperand ) query.getRootOperand();
+
+ final float distance = withinOperand.getDistance().getFloatValue();
+ final float lat = withinOperand.getLatitude().getFloatValue();
+ final float lon = withinOperand.getLongitude().getFloatValue();
+
+ assertEquals( 2000f, distance, 0f );
+ assertEquals( 37.776753f, lat, 0f );
+ assertEquals( -122.407846f, lon, 0f );
+ }
+
@Test
public void testCodeEquals() {
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/corepersistence/pom.xml
----------------------------------------------------------------------
diff --git a/stack/corepersistence/pom.xml b/stack/corepersistence/pom.xml
index 9bd53fa..b44fca7 100644
--- a/stack/corepersistence/pom.xml
+++ b/stack/corepersistence/pom.xml
@@ -59,7 +59,7 @@ limitations under the License.
<commons.collections.version>3.2.1</commons.collections.version>
<commons.io.version>2.4</commons.io.version>
<commons.lang.version>3.1</commons.lang.version>
- <elasticsearch.version>1.3.2</elasticsearch.version>
+ <elasticsearch.version>1.4.0</elasticsearch.version>
<fasterxml-uuid.version>3.1.3</fasterxml-uuid.version>
<guava.version>15.0</guava.version>
<guice.version>4.0-beta5</guice.version>
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/SearchTypes.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/SearchTypes.java b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/SearchTypes.java
index b3eace5..35b3a8b 100644
--- a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/SearchTypes.java
+++ b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/SearchTypes.java
@@ -69,7 +69,7 @@ public class SearchTypes {
*/
public static SearchTypes fromNullableTypes(final String... types){
- if(types == null || types.length == 0){
+ if(isEmpty(types) ){
return allTypes();
}
@@ -77,6 +77,25 @@ public class SearchTypes {
}
+ /**
+ * Return true if the array is empty, or it's elements contain a null
+ * @param input
+ * @return
+ */
+ private static boolean isEmpty(final String[] input){
+ if(input == null || input.length == 0){
+ return true;
+ }
+
+ for(int i = 0; i < input.length; i ++){
+ if(input[i] == null){
+ return true;
+ }
+ }
+
+ return false;
+ }
+
@Override
public boolean equals( final Object o ) {
if ( this == o ) {
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/EsEntityIndexImpl.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/EsEntityIndexImpl.java b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/EsEntityIndexImpl.java
index cb56c7d..a2c3090 100644
--- a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/EsEntityIndexImpl.java
+++ b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/EsEntityIndexImpl.java
@@ -59,6 +59,7 @@ import org.apache.usergrid.persistence.index.EntityIndexBatch;
import org.apache.usergrid.persistence.index.IndexFig;
import org.apache.usergrid.persistence.index.IndexScope;
import org.apache.usergrid.persistence.index.SearchTypes;
+import org.apache.usergrid.persistence.index.exceptions.IndexException;
import org.apache.usergrid.persistence.index.query.CandidateResult;
import org.apache.usergrid.persistence.index.query.CandidateResults;
import org.apache.usergrid.persistence.index.query.Query;
@@ -217,6 +218,12 @@ public class EsEntityIndexImpl implements EntityIndex {
.setTemplate( config.getIndexPrefix() + "*" ).addMapping( "_default_",
xcb ) // set mapping as the default for all types
.execute().actionGet();
+
+ if(!pitr.isAcknowledged()){
+ throw new IndexException( "Unable to create default mappings" );
+ }
+
+
}
@@ -242,12 +249,6 @@ public class EsEntityIndexImpl implements EntityIndex {
.setScroll( cursorTimeout + "m" ).setQuery( qb );
- if ( logger.isDebugEnabled() ) {
- logger.debug( "Searching index {}\n scope{} \n type {}\n query {} limit {}", new Object[] {
- this.indexName, context, entityTypes, qb.toString().replace( "\n", " " ), query.getLimit()
- } );
- }
-
final FilterBuilder fb = query.createFilterBuilder();
@@ -296,11 +297,20 @@ public class EsEntityIndexImpl implements EntityIndex {
logger.debug( " Sort: {} order by {}", booleanFieldName, order.toString() );
}
+
+
+ if ( logger.isDebugEnabled() ) {
+ logger.debug( "Searching index {}\n scope{} \n type {}\n query {} ", new Object[] {
+ this.indexName, context, entityTypes, srb
+ } );
+ }
+
+
try {
searchResponse = srb.execute().actionGet();
}
catch ( Throwable t ) {
- logger.error( "Unable to communicate with elasticsearch" );
+ logger.error( "Unable to communicate with elasticsearch", t );
failureMonitor.fail( "Unable to execute batch", t );
throw t;
}
@@ -325,7 +335,7 @@ public class EsEntityIndexImpl implements EntityIndex {
searchResponse = ssrb.execute().actionGet();
}
catch ( Throwable t ) {
- logger.error( "Unable to communicate with elasticsearch" );
+ logger.error( "Unable to communicate with elasticsearch", t );
failureMonitor.fail( "Unable to execute batch", t );
throw t;
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/query/Query.java
----------------------------------------------------------------------
diff --git a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/query/Query.java b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/query/Query.java
index 07bee44..a057b02 100644
--- a/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/query/Query.java
+++ b/stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/query/Query.java
@@ -91,7 +91,7 @@ public class Query {
private Map<String, String> selectAssignments = new LinkedHashMap<String, String>();
private boolean mergeSelectResults = false;
private Level level = Level.ALL_PROPERTIES;
- private String connection;
+ private String connectionType;
private List<String> permissions;
private boolean reversed;
private boolean reversedSet = false;
@@ -125,7 +125,7 @@ public class Query {
? new LinkedHashMap<String, String>( q.selectAssignments ) : null;
mergeSelectResults = q.mergeSelectResults;
//level = q.level;
- connection = q.connection;
+ connectionType = q.connectionType;
permissions = q.permissions != null ? new ArrayList<String>( q.permissions ) : null;
reversed = q.reversed;
reversedSet = q.reversedSet;
@@ -143,41 +143,47 @@ public class Query {
}
- public QueryBuilder createQueryBuilder(final String context) {
-
-
- QueryBuilder queryBuilder;
-
-
- /**
- * Add our filter for context to our query for fast execution. Fast because it utilizes bitsets
- * internally. See this post for more detail.
- * http://www.elasticsearch.org/blog/all-about-elasticsearch-filter-bitsets/
- */
-
+ public QueryBuilder createQueryBuilder( final String context ) {
+ QueryBuilder queryBuilder = null;
//we have a root operand. Translate our AST into an ES search
if ( getRootOperand() != null ) {
+ //In the case of geo only queries, this will return null into the query builder. Once we start
+ //using tiles, we won't need this check any longer, since a geo query will return a tile query + post filter
QueryVisitor v = new EsQueryVistor();
+
try {
getRootOperand().visit( v );
-
- } catch ( IndexException ex ) {
+ }
+ catch ( IndexException ex ) {
throw new RuntimeException( "Error building ElasticSearch query", ex );
}
- // TODO evaluate performance when it's an all query. Do we need to put the context term first for performance?
- queryBuilder = QueryBuilders.boolQuery().must( v.getQueryBuilder() )
- .must( QueryBuilders.termQuery( IndexingUtils.ENTITY_CONTEXT_FIELDNAME, context ) );
- }
+
+ queryBuilder = v.getQueryBuilder();
+ }
+
+
+ /**
+ * Add our filter for context to our query for fast execution. Fast because it utilizes bitsets
+ * internally. See this post for more detail.
+ * http://www.elasticsearch.org/blog/all-about-elasticsearch-filter-bitsets/
+ */
+
+
+ // TODO evaluate performance when it's an all query. Do we need to put the context term first for performance?
+ if ( queryBuilder != null ) {
+ queryBuilder = QueryBuilders.boolQuery().must( queryBuilder ).must( QueryBuilders
+ .termQuery( IndexingUtils.ENTITY_CONTEXT_FIELDNAME, context ) );
+ }
//nothing was specified ensure we specify the context in the search
- else {
+ else {
queryBuilder = QueryBuilders.termQuery( IndexingUtils.ENTITY_CONTEXT_FIELDNAME, context );
- }
+ }
return queryBuilder;
}
@@ -283,7 +289,7 @@ public class Query {
String ql = QueryUtils.queryStrFrom( params );
String type = ListUtils.first( params.get( "type" ) );
Boolean reversed = ListUtils.firstBoolean( params.get( "reversed" ) );
- String connection = ListUtils.first( params.get( "connection" ) );
+ String connection = ListUtils.first( params.get( "connectionType" ) );
UUID start = ListUtils.firstUuid( params.get( "start" ) );
String cursor = ListUtils.first( params.get( "cursor" ) );
Integer limit = ListUtils.firstInteger( params.get( "limit" ) );
@@ -563,17 +569,6 @@ public class Query {
this.type = type;
}
-
- public String getConnectionType() {
- return connection;
- }
-
-
- public void setConnectionType( String connection ) {
- this.connection = connection;
- }
-
-
public List<String> getPermissions() {
return permissions;
}
@@ -1373,18 +1368,29 @@ public class Query {
}
- public void setQl( String ql ) {
+ public Query setQl( String ql ) {
this.ql = ql;
+ return this;
}
- public List<Identifier> getIdentifiers() {
- return identifiers;
+ /**
+ * Get the connection type
+ * @return
+ */
+ public String getConnectionType() {
+ return connectionType;
}
- public String getConnection() {
- return connection;
+ /**
+ * Set the connection type
+ * @param connection
+ * @return
+ */
+ public Query setConnectionType( final String connection ) {
+ this.connectionType = connection;
+ return this;
}
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/pom.xml
----------------------------------------------------------------------
diff --git a/stack/pom.xml b/stack/pom.xml
index ff70076..5a7bdd3 100644
--- a/stack/pom.xml
+++ b/stack/pom.xml
@@ -115,7 +115,6 @@
<tomcat-version>7.0.52</tomcat-version>
<antlr.version>3.4</antlr.version>
<tika.version>1.4</tika.version>
- <elasticsearch.version>1.3.2</elasticsearch.version>
<mockito.version>1.10.8</mockito.version>
<usergrid.it.forkCount>3</usergrid.it.forkCount>
@@ -1428,12 +1427,6 @@
</dependency>
<dependency>
- <groupId>org.elasticsearch</groupId>
- <artifactId>elasticsearch</artifactId>
- <version>${elasticsearch.version}</version>
- </dependency>
-
- <dependency>
<groupId>com.relayrides</groupId>
<artifactId>pushy</artifactId>
<!-- The sha in the version is the git commit used in this build. Check out the pushy source, then this commit to build the library locally -->
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/41647349/stack/test-utils/pom.xml
----------------------------------------------------------------------
diff --git a/stack/test-utils/pom.xml b/stack/test-utils/pom.xml
index f8e618d..96685f7 100644
--- a/stack/test-utils/pom.xml
+++ b/stack/test-utils/pom.xml
@@ -251,11 +251,6 @@
</dependency>
<dependency>
- <groupId>org.elasticsearch</groupId>
- <artifactId>elasticsearch</artifactId>
- </dependency>
-
- <dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-core</artifactId>
</dependency>