You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Jiajie Zhong <zh...@hotmail.com> on 2020/03/03 16:49:04 UTC
Re: [Proposal] Component changes for Apache Airflow
Hey guys, sad to said that we have some similar component in JIRA now, such as `db` vs `database`, or `test` vs `flaky_test`, or `executor` vs `executor-kubernetes`.
Should we combine them, and limit fix the component to avoid regression?
Best Wish
— Jiajie
Re: [Proposal] Component changes for Apache Airflow
Posted by Aizhamal Nurmamat kyzy <ai...@apache.org>.
Please, disregard the link in my previous email that was added accidentally
:/
On Tue, Mar 3, 2020, 10:27 AM Aizhamal Nurmamat kyzy <ai...@apache.org>
wrote:
> Thank you for spotting it, Jiajie! We should definitely combine them, and
> remove duplicates.
>
> My guess is that the new components were added accidentally by committers
> / pmc members in the bug-creating screen. It seems one can create a
> component by pressing enter twice on the new component.
>
> If possible, we should adopt the following processes:
> 1) To create a new component, we'll ask people to request them in dev@
> <https://www.google.com/url?q=https://moma.corp.google.com/person/dev&sa=D&source=hangouts&ust=1583346187841000&usg=AFQjCNH821B7rN08r_gvPLpngTYliYhZFA> and
> have pmc votes
> 2) Remove the ability to create them from the bug-creating screen
>
>
>
>
> On Tue, Mar 3, 2020 at 8:49 AM Jiajie Zhong <zh...@hotmail.com>
> wrote:
>
>> Hey guys, sad to said that we have some similar component in JIRA now,
>> such as `db` vs `database`, or `test` vs `flaky_test`, or `executor` vs
>> `executor-kubernetes`.
>>
>> Should we combine them, and limit fix the component to avoid regression?
>>
>> Best Wish
>> — Jiajie
>>
>>
Re: [Proposal] Component changes for Apache Airflow
Posted by Aizhamal Nurmamat kyzy <ai...@apache.org>.
Agree, we need to adopt more careful and thoughtful processes among PMC
around creating new components.
When the new component is created, it is also worth sharing its description
with the rest of the community on the dev list, so more of us are aware of
it and we can label issues more accurately.
On Tue, Mar 10, 2020 at 5:32 AM Jarek Potiuk <Ja...@polidea.com>
wrote:
> Agree. I think I created some of them without realising they are created
> automatically. Being more careful should be enough. We can always do such
> cleanups periodically. I think being able to add components as we need them
> is important - as we might have new components added (for example soon we
> will have backend credentials likely - they deserve their own component)
>
> J.
>
>
> On Tue, Mar 10, 2020 at 1:23 PM Ash Berlin-Taylor <as...@apache.org> wrote:
>
> > Not really a fan of removing admin as that limits other operations we can
> > do elsewhere -- it's not the end of the world if we get new components
> > created. We should just ask the PMC members to be careful/thoughtful when
> > they create components.
> >
> > And `executor` vs `executor-kubernetes` makes sense for instance -- the
> > Kube executor is it's own "beast" (not to mention there are 50+ tickets
> > assigned to that, so it's not a one off.)
> > -ash
> > On Mar 10 2020, at 12:00 am, Aizhamal Nurmamat kyzy <aizhamal@apache.org
> >
> > wrote:
> > > Seems the new components were created by the folks who had Project
> Admin
> > permissions: in our case all of the PMC have that permission [1]. One
> > solution is to remove PMC from project admins and establish a process of
> > "requesting creation of new components" in the dev list. I think it is
> > necessary, because it will be only harder to keep track of PMCs creating
> > new components on the go. WDYT? Any other alternatives? [1]
> >
> https://community.atlassian.com/t5/Jira-Software-questions/How-can-I-restrict-users-ability-to-create-new-Components-while/qaq-p/993348
> > On Tue, Mar 3, 2020 at 5:49 PM Jiajie Zhong wrote: > I'm not quick
> familiar
> > with JIRA, but after we remove the ability to > create them from the
> > bug-creating screen, > > Do we could avoid someone create components by
> > accident? > > > Best Wish > — Jiajie
> >
> >
>
> --
>
> Jarek Potiuk
> Polidea <https://www.polidea.com/> | Principal Software Engineer
>
> M: +48 660 796 129 <+48%20660%20796%20129> <+48660796129
> <+48%20660%20796%20129>>
> [image: Polidea] <https://www.polidea.com/>
>
Re: [Proposal] Component changes for Apache Airflow
Posted by Jarek Potiuk <Ja...@polidea.com>.
Agree. I think I created some of them without realising they are created
automatically. Being more careful should be enough. We can always do such
cleanups periodically. I think being able to add components as we need them
is important - as we might have new components added (for example soon we
will have backend credentials likely - they deserve their own component)
J.
On Tue, Mar 10, 2020 at 1:23 PM Ash Berlin-Taylor <as...@apache.org> wrote:
> Not really a fan of removing admin as that limits other operations we can
> do elsewhere -- it's not the end of the world if we get new components
> created. We should just ask the PMC members to be careful/thoughtful when
> they create components.
>
> And `executor` vs `executor-kubernetes` makes sense for instance -- the
> Kube executor is it's own "beast" (not to mention there are 50+ tickets
> assigned to that, so it's not a one off.)
> -ash
> On Mar 10 2020, at 12:00 am, Aizhamal Nurmamat kyzy <ai...@apache.org>
> wrote:
> > Seems the new components were created by the folks who had Project Admin
> permissions: in our case all of the PMC have that permission [1]. One
> solution is to remove PMC from project admins and establish a process of
> "requesting creation of new components" in the dev list. I think it is
> necessary, because it will be only harder to keep track of PMCs creating
> new components on the go. WDYT? Any other alternatives? [1]
> https://community.atlassian.com/t5/Jira-Software-questions/How-can-I-restrict-users-ability-to-create-new-Components-while/qaq-p/993348
> On Tue, Mar 3, 2020 at 5:49 PM Jiajie Zhong wrote: > I'm not quick familiar
> with JIRA, but after we remove the ability to > create them from the
> bug-creating screen, > > Do we could avoid someone create components by
> accident? > > > Best Wish > — Jiajie
>
>
--
Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer
M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>
Re: [Proposal] Component changes for Apache Airflow
Posted by Ash Berlin-Taylor <as...@apache.org>.
Not really a fan of removing admin as that limits other operations we can do elsewhere -- it's not the end of the world if we get new components created. We should just ask the PMC members to be careful/thoughtful when they create components.
And `executor` vs `executor-kubernetes` makes sense for instance -- the Kube executor is it's own "beast" (not to mention there are 50+ tickets assigned to that, so it's not a one off.)
-ash
On Mar 10 2020, at 12:00 am, Aizhamal Nurmamat kyzy <ai...@apache.org> wrote:
> Seems the new components were created by the folks who had Project Admin permissions: in our case all of the PMC have that permission [1]. One solution is to remove PMC from project admins and establish a process of "requesting creation of new components" in the dev list. I think it is necessary, because it will be only harder to keep track of PMCs creating new components on the go. WDYT? Any other alternatives? [1] https://community.atlassian.com/t5/Jira-Software-questions/How-can-I-restrict-users-ability-to-create-new-Components-while/qaq-p/993348 On Tue, Mar 3, 2020 at 5:49 PM Jiajie Zhong wrote: > I'm not quick familiar with JIRA, but after we remove the ability to > create them from the bug-creating screen, > > Do we could avoid someone create components by accident? > > > Best Wish > — Jiajie
Re: [Proposal] Component changes for Apache Airflow
Posted by Aizhamal Nurmamat kyzy <ai...@apache.org>.
Seems the new components were created by the folks who had Project Admin
permissions: in our case all of the PMC have that permission [1].
One solution is to remove PMC from project admins and establish a process
of "requesting creation of new components" in the dev list. I think it is
necessary, because it will be only harder to keep track of PMCs creating
new components on the go.
WDYT? Any other alternatives?
[1]
https://community.atlassian.com/t5/Jira-Software-questions/How-can-I-restrict-users-ability-to-create-new-Components-while/qaq-p/993348
On Tue, Mar 3, 2020 at 5:49 PM Jiajie Zhong <zh...@hotmail.com>
wrote:
> I'm not quick familiar with JIRA, but after we remove the ability to
> create them from the bug-creating screen,
>
> Do we could avoid someone create components by accident?
>
>
> Best Wish
> — Jiajie
Re: [Proposal] Component changes for Apache Airflow
Posted by Jiajie Zhong <zh...@hotmail.com>.
I'm not quick familiar with JIRA, but after we remove the ability to create them from the bug-creating screen,
Do we could avoid someone create components by accident?
Best Wish
— Jiajie
Re: [Proposal] Component changes for Apache Airflow
Posted by Aizhamal Nurmamat kyzy <ai...@apache.org>.
Thank you for spotting it, Jiajie! We should definitely combine them, and
remove duplicates.
My guess is that the new components were added accidentally by committers /
pmc members in the bug-creating screen. It seems one can create a component
by pressing enter twice on the new component.
If possible, we should adopt the following processes:
1) To create a new component, we'll ask people to request them in dev@
<https://www.google.com/url?q=https://moma.corp.google.com/person/dev&sa=D&source=hangouts&ust=1583346187841000&usg=AFQjCNH821B7rN08r_gvPLpngTYliYhZFA>
and
have pmc votes
2) Remove the ability to create them from the bug-creating screen
On Tue, Mar 3, 2020 at 8:49 AM Jiajie Zhong <zh...@hotmail.com>
wrote:
> Hey guys, sad to said that we have some similar component in JIRA now,
> such as `db` vs `database`, or `test` vs `flaky_test`, or `executor` vs
> `executor-kubernetes`.
>
> Should we combine them, and limit fix the component to avoid regression?
>
> Best Wish
> — Jiajie
>
>