Re: Review Request 30421: RU YARN related pre-upgrade check UI shows unclear message

[Nate Cole <nc...@hortonworks.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30421/#review70582
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 29, 2015, 1:03 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30421/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 1:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9405
>     https://issues.apache.org/jira/browse/AMBARI-9405
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> we have to do 3 things for all the checks:
> a) give list of services wherever relevant e.g. if Hive is in MM, say so
> b) give list of hosts wherever relevant e.g. if Host A does not have the new version installed, list host A
> c) if a property is not set, give the name of the property(e.g. yarn.resourcemanager.work-preserving-recovery.enabled ), what to set it to(e.g. true), where to set it from (e.g. yarn-site.xml).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java f49e666 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java 917cbac 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java ba5e804 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 53e628c 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java 1bea93c 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java 332b58a 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java ceb61ad 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java a4a18e6 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java f9249b2 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/GroupServiceTest.java 68ee4a5 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30421/diff/
> 
> 
> Testing
> -------
> 
> In progress (only texts were corrected, shouldn't cause any failures)
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>