You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/11/30 09:01:21 UTC
[jira] [Commented] (RATIS-161) gRPC Log appender should check if
the appended request size is less than max message size of the server
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272398#comment-16272398 ]
Hadoop QA commented on RATIS-161:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 15s{color} | {color:orange} root: The patch generated 5 new + 66 unchanged - 1 fixed = 71 total (was 67) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 22s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 7s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 40s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftReconfigurationWithGRpc |
| | ratis.hadooprpc.TestRaftWithHadoopRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-11-30 |
| JIRA Issue | RATIS-161 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12899967/RATIS-161.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 19022bbd7607 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / 874e48b |
| Default Java | 1.8.0_151 |
| checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/49/artifact/out/diff-checkstyle-root.txt |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/49/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/49/testReport/ |
| modules | C: ratis-server ratis-grpc U: . |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/49/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> gRPC Log appender should check if the appended request size is less than max message size of the server
> -------------------------------------------------------------------------------------------------------
>
> Key: RATIS-161
> URL: https://issues.apache.org/jira/browse/RATIS-161
> Project: Ratis
> Issue Type: Bug
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Attachments: RATIS-161.001.patch
>
>
> RATIS-133 add a check to the raft client to ensure that server doesn't receive messages which are greater than maxMessageSize. However GRPCLogAppender can append entries to the server and these entries can be greater than the max message size. This jira will add a check to GRPCLogAppender as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)