[GitHub] [incubator-superset] jdbertron commented on a change in pull request #7417: Fix migration metadata lock on ab_view_menu

[GitBox <gi...@apache.org>]

jdbertron commented on a change in pull request #7417: Fix migration metadata lock on ab_view_menu
URL: https://github.com/apache/incubator-superset/pull/7417#discussion_r280609651
 
 

 ##########
 File path: superset/__init__.py
 ##########
 @@ -196,40 +196,41 @@ def index(self):
          not FAB's security manager.
          See [4565] in UPDATING.md""")
 
-appbuilder = AppBuilder(
-    app,
-    db.session,
-    base_template='superset/base.html',
-    indexview=MyIndexView,
-    security_manager_class=custom_sm,
-    update_perms=get_update_perms_flag(),
-)
+with app.app_context():
 
 Review comment:
   We had the same issue if the ConnectorRegistry stuff wasn't included because it starts a bunch of sa.listen() on sqlatables. Are you sure ?  I'll re-test on my end as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org