You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/17 08:57:17 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request #4351: AWS : make passing s3WriteTags example engine agnostic
singhpk234 opened a new pull request #4351:
URL: https://github.com/apache/iceberg/pull/4351
make the example in java doc of s3WriteTagPrefix engine agnostic.
earlier suggestion : https://github.com/apache/iceberg/pull/4334#discussion_r828195275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #4351: AWS : make passing s3WriteTags javaDoc example engine agnostic
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #4351:
URL: https://github.com/apache/iceberg/pull/4351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #4351: AWS : make passing s3WriteTags javaDoc example engine agnostic
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #4351:
URL: https://github.com/apache/iceberg/pull/4351#discussion_r830152385
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -240,7 +240,7 @@
* <p>
* For more details, see https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
* <p>
- * Example in Spark: --conf spark.sql.catalog.my_catalog.s3.write.tags.my_key=my_val
+ * Example : s3.write.tags.my_key=my_val
Review comment:
nit: extra space before `:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a change in pull request #4351: AWS : make passing s3WriteTags javaDoc example engine agnostic
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on a change in pull request #4351:
URL: https://github.com/apache/iceberg/pull/4351#discussion_r830211968
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -240,7 +240,7 @@
* <p>
* For more details, see https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
* <p>
- * Example in Spark: --conf spark.sql.catalog.my_catalog.s3.write.tags.my_key=my_val
+ * Example : s3.write.tags.my_key=my_val
Review comment:
done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org