You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/04 20:49:55 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1124: HBASE-23792
[Flakey Test]
TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
ndimiduk opened a new pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124
1. Survive flakey rerunning by converting the static BeforeClass stuff
into instance-level Before.
2. Break the test method into two, one for running over each of the
snapshot manifest versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1124:
HBASE-23792 [Flakey Test]
TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124#discussion_r374993219
##########
File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotNoCluster.java
##########
@@ -67,29 +64,29 @@ public static void setUpBaseConf(Configuration conf) {
conf.set(HConstants.HBASE_DIR, testDir.toString());
}
- @BeforeClass
- public static void setUpBeforeClass() throws Exception {
+ @Before
+ public void setUpBefore() throws Exception {
// Make sure testDir is on LocalFileSystem
- testDir = TEST_UTIL.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
- fs = testDir.getFileSystem(TEST_UTIL.getConfiguration());
+ testDir = testUtil.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
Review comment:
`testUtil.getDataTestDir()` will generate a path with a random UUID, so by getting a fresh instance of `testUtil`, I get an isolated path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1124: HBASE-23792 [Flakey
Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1124: HBASE-23792 [Flakey
Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124#issuecomment-582142668
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 24s | master passed |
| +1 :green_heart: | compile | 0m 32s | master passed |
| +1 :green_heart: | checkstyle | 0m 22s | master passed |
| +1 :green_heart: | shadedjars | 5m 26s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 20s | master passed |
| +0 :ok: | spotbugs | 0m 57s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 0m 55s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | the patch passed |
| +1 :green_heart: | compile | 0m 31s | the patch passed |
| +1 :green_heart: | javac | 0m 31s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 19s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 16s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 18m 14s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 20s | the patch passed |
| +1 :green_heart: | findbugs | 1m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 21m 59s | hbase-mapreduce in the patch passed. |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 76m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1124/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1124 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux eca441a96517 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1124/out/precommit/personality/provided.sh |
| git revision | master / 1cacf27d5c |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1124/1/testReport/ |
| Max. process+thread count | 5286 (vs. ulimit of 10000) |
| modules | C: hbase-mapreduce U: hbase-mapreduce |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1124/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1124:
HBASE-23792 [Flakey Test]
TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1124: HBASE-23792 [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
URL: https://github.com/apache/hbase/pull/1124#discussion_r374926733
##########
File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotNoCluster.java
##########
@@ -67,29 +64,29 @@ public static void setUpBaseConf(Configuration conf) {
conf.set(HConstants.HBASE_DIR, testDir.toString());
}
- @BeforeClass
- public static void setUpBeforeClass() throws Exception {
+ @Before
+ public void setUpBefore() throws Exception {
// Make sure testDir is on LocalFileSystem
- testDir = TEST_UTIL.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
- fs = testDir.getFileSystem(TEST_UTIL.getConfiguration());
+ testDir = testUtil.getDataTestDir().makeQualified(URI.create("file:///"), new Path("/"));
Review comment:
Isolate more by getting method name into path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services