You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/11 05:07:10 UTC
[GitHub] [flink] biyuhao opened a new pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
biyuhao opened a new pull request #18322:
URL: https://github.com/apache/flink/pull/18322
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Update Chinese version document of Elasticsearch sink interface related to [FLINK-24326](https://issues.apache.org/jira/browse/FLINK-24326) (#17930)
## Brief change log
- Translate `docs/content.zh/docs/connectors/datastream/elasticsearch.md`
- Translate `docs/content.zh/docs/connectors/table/elasticsearch.md`
- Trivial fix of `docs/content/docs/connectors/datastream/elasticsearch.md`
## Verifying this change
This is a document update.
Please build docs locally to verify document content and syntax.
```
cd docs
./build_docs.sh -p
```
Then you can preview `http://localhost:1313` in the local browser.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "1014288944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* bc03961d8630702f3709d74c07684083c812c99c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1014288944
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 280f073dec75735ba97cdc12cb61f9de2b00a31e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271)
* bc03961d8630702f3709d74c07684083c812c99c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
JingGe commented on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1014381255
@fapaul Would you like to merge this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
* 280f073dec75735ba97cdc12cb61f9de2b00a31e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
* 280f073dec75735ba97cdc12cb61f9de2b00a31e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "1014288944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* bc03961d8630702f3709d74c07684083c812c99c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "1014288944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* bc03961d8630702f3709d74c07684083c812c99c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] biyuhao commented on a change in pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
biyuhao commented on a change in pull request #18322:
URL: https://github.com/apache/flink/pull/18322#discussion_r784942409
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -40,16 +40,12 @@ under the License.
</tr>
</thead>
<tbody>
- <tr>
- <td>5.x</td>
- <td>{{< artifact flink-connector-elasticsearch5 >}}</td>
- </tr>
<tr>
<td>6.x</td>
<td>{{< artifact flink-connector-elasticsearch6 >}}</td>
</tr>
<tr>
- <td>7 及更高版本</td>
+ <td>7.x</td>
Review comment:
sorry, forgot to mention that it comes from FLINK-25189
thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009604792
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 310b62a595a1af2d091b6a0f2e8fc137460b92e7 (Tue Jan 11 05:10:17 UTC 2022)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a change in pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
JingGe commented on a change in pull request #18322:
URL: https://github.com/apache/flink/pull/18322#discussion_r784252017
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -294,131 +210,163 @@ input.addSink(esSinkBuilder.build)
### Elasticsearch Sinks 和容错
-启用 Flink checkpoint 后，Flink Elasticsearch Sink 保证至少一次将操作请求发送到 Elasticsearch 集群。
+默认情况下，Flink Elasticsearch Sink 不会提供任何传递健壮性的保障。
+用户可以通过配置自行启用 Elasticsearch sink 的 at-least-once 语义。
Review comment:
```suggestion
用户可以选择启用 Elasticsearch sink 的 at-least-once 语义。
```
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -40,16 +40,12 @@ under the License.
</tr>
</thead>
<tbody>
- <tr>
- <td>5.x</td>
- <td>{{< artifact flink-connector-elasticsearch5 >}}</td>
- </tr>
<tr>
<td>6.x</td>
Review comment:
```suggestion
<td><= 6.3.1</td>
```
##########
File path: docs/content.zh/docs/connectors/table/elasticsearch.md
##########
@@ -192,31 +177,24 @@ CREATE TABLE myUserTable (
<tr>
<td><h5>sink.bulk-flush.backoff.max-retries</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">8</td>
+ <td style="word-wrap: break-word;">(none)</td>
<td>Integer</td>
<td>最大回退重试次数。</td>
</tr>
<tr>
<td><h5>sink.bulk-flush.backoff.delay</h5></td>
<td>可选</td>
- <td style="word-wrap: break-word;">50ms</td>
+ <td style="word-wrap: break-word;">(none)</td>
<td>Duration</td>
<td>每次回退尝试之间的延迟。对于 <code>CONSTANT</code> 回退策略，该值是每次重试之间的延迟。对于 <code>EXPONENTIAL</code> 回退策略，该值是初始的延迟。</td>
Review comment:
```suggestion
<td>每次退避尝试之间的延迟。对于 <code>CONSTANT</code> 退避策略，该值是每次重试之间的延迟。对于 <code>EXPONENTIAL</code> 退避策略，该值是初始的延迟。</td>
```
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -40,16 +40,12 @@ under the License.
</tr>
</thead>
<tbody>
- <tr>
- <td>5.x</td>
- <td>{{< artifact flink-connector-elasticsearch5 >}}</td>
- </tr>
<tr>
<td>6.x</td>
<td>{{< artifact flink-connector-elasticsearch6 >}}</td>
</tr>
<tr>
- <td>7 及更高版本</td>
+ <td>7.x</td>
Review comment:
```suggestion
<td><= 7.5.1</td>
```
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -294,131 +210,163 @@ input.addSink(esSinkBuilder.build)
### Elasticsearch Sinks 和容错
-启用 Flink checkpoint 后，Flink Elasticsearch Sink 保证至少一次将操作请求发送到 Elasticsearch 集群。
+默认情况下，Flink Elasticsearch Sink 不会提供任何传递健壮性的保障。
+用户可以通过配置自行启用 Elasticsearch sink 的 at-least-once 语义。
+
+启用 Flink checkpoint 后，Flink Elasticsearch Sink 可以保证至少一次将操作请求发送到 Elasticsearch 集群。
Review comment:
```suggestion
通过启用 Flink checkpoint ，Flink Elasticsearch Sink 可以保证至少一次将操作请求发送到 Elasticsearch 集群。
```
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -294,131 +210,163 @@ input.addSink(esSinkBuilder.build)
### Elasticsearch Sinks 和容错
-启用 Flink checkpoint 后，Flink Elasticsearch Sink 保证至少一次将操作请求发送到 Elasticsearch 集群。
+默认情况下，Flink Elasticsearch Sink 不会提供任何传递健壮性的保障。
+用户可以通过配置自行启用 Elasticsearch sink 的 at-least-once 语义。
+
+启用 Flink checkpoint 后，Flink Elasticsearch Sink 可以保证至少一次将操作请求发送到 Elasticsearch 集群。
这是通过在进行 checkpoint 时等待 `BulkProcessor` 中所有挂起的操作请求来实现。
这有效地保证了在触发 checkpoint 之前所有的请求被 Elasticsearch 成功确认，然后继续处理发送到 sink 的记录。
关于 checkpoint 和容错的更多详细信息，请参见[容错文档]({{< ref "docs/learn-flink/fault_tolerance" >}})。
-要使用具有容错特性的 Elasticsearch Sinks，需要在执行环境中启用作业拓扑的 checkpoint：
+要使用具有容错特性的 Elasticsearch Sinks，需要配置启用 at-least-once 分发并且在执行环境中启用作业拓扑的 checkpoint：
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+Elasticsearch 6:
```java
final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.enableCheckpointing(5000); // 每 5000 毫秒执行一次 checkpoint
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
+```
+
+Elasticsearch 7:
+```java
+final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // 每 5000 毫秒执行一次 checkpoint
+
+Elasticsearch7SinkBuilder sinkBuilder = new Elasticsearch7SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
```
{{< /tab >}}
{{< tab "Scala" >}}
+Elasticsearch 6:
```scala
val env = StreamExecutionEnvironment.getExecutionEnvironment()
env.enableCheckpointing(5000) // 每 5000 毫秒执行一次 checkpoint
+
+val sinkBuilder = new Elasticsearch6SinkBuilder[String]
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+```
+
+Elasticsearch 7:
+```scala
+val env = StreamExecutionEnvironment.getExecutionEnvironment()
+env.enableCheckpointing(5000) // 每 5000 毫秒执行一次 checkpoint
+
+val sinkBuilder = new Elasticsearch7SinkBuilder[String]
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
```
{{< /tab >}}
{{< /tabs >}}
-<p style="border-radius: 5px; padding: 5px" class="bg-danger">
-<b>注意</b>：如果用户愿意，可以通过在创建的
-<b> ElasticsearchSink </b>上调用 <b>disableFlushOnCheckpoint()</b> 来禁用刷新。请注意，
- 这实质上意味着 sink 将不再提供任何可靠的交付保证，即使启用了作业拓扑的 checkpoint。
-</p>
-
### 处理失败的 Elasticsearch 请求
Elasticsearch 操作请求可能由于多种原因而失败，包括节点队列容量暂时已满或者要被索引的文档格式错误。
-Flink Elasticsearch Sink 允许用户通过简单地实现一个 `ActionRequestFailureHandler` 并将其提供给构造函数来指定如何处理失败的请求。
+Flink Elasticsearch Sink 允许用户通过通过指定一个退避策略来重试请求。
下面是一个例子：
{{< tabs "ddb958b3-5dd5-476e-b946-ace3335628b2" >}}
{{< tab "Java" >}}
+Elasticsearch 6:
+```java
+DataStream<String> input = ...;
+
+input.sinkTo(
+ new Elasticsearch6SinkBuilder<String>()
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build());
+```
+
+Elasticsearch 7:
```java
DataStream<String> input = ...;
-input.addSink(new ElasticsearchSink<>(
- config, transportAddresses,
- new ElasticsearchSinkFunction<String>() {...},
- new ActionRequestFailureHandler() {
- @Override
- void onFailure(ActionRequest action,
- Throwable failure,
- int restStatusCode,
- RequestIndexer indexer) throw Throwable {
-
- if (ExceptionUtils.findThrowable(failure, EsRejectedExecutionException.class).isPresent()) {
- // 队列已满；重新添加文档进行索引
- indexer.add(action);
- } else if (ExceptionUtils.findThrowable(failure, ElasticsearchParseException.class).isPresent()) {
- // 文档格式错误；简单地删除请求避免 sink 失败
- } else {
- // 对于所有其他失败的请求，失败的 sink
- // 这里的失败只是简单的重新抛出，但用户也可以选择抛出自定义异常
- throw failure;
- }
- }
-}));
+input.sinkTo(
+ new Elasticsearch7SinkBuilder<String>()
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build());
```
{{< /tab >}}
{{< tab "Scala" >}}
+Elasticsearch 6:
```scala
val input: DataStream[String] = ...
-input.addSink(new ElasticsearchSink(
- config, transportAddresses,
- new ElasticsearchSinkFunction[String] {...},
- new ActionRequestFailureHandler {
- @throws(classOf[Throwable])
- override def onFailure(ActionRequest action,
- Throwable failure,
- int restStatusCode,
- RequestIndexer indexer) {
-
- if (ExceptionUtils.findThrowable(failure, EsRejectedExecutionException.class).isPresent()) {
- // 队列已满；重新添加文档进行索引
- indexer.add(action)
- } else if (ExceptionUtils.findThrowable(failure, ElasticsearchParseException.class).isPresent()) {
- // 文档格式错误；简单地删除请求避免 sink 失败
- } else {
- // 对于所有其他失败的请求，失败的 sink
- // 这里的失败只是简单的重新抛出，但用户也可以选择抛出自定义异常
- throw failure
- }
- }
-}))
+input.sinkTo(
+ new Elasticsearch6SinkBuilder[String]
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build())
```
-{{< /tab >}}
-{{< /tabs >}}
-上面的示例 sink 重新添加由于队列容量已满而失败的请求，同时丢弃文档格式错误的请求，而不会使 sink 失败。
-对于其它故障，sink 将会失败。如果未向构造器提供一个 `ActionRequestFailureHandler`，那么任何类型的错误都会导致 sink 失败。
+Elasticsearch 7:
+```scala
+val input: DataStream[String] = ...
-注意，`onFailure` 仅在 `BulkProcessor` 内部完成所有延迟重试后仍发生故障时被调用。
-默认情况下，`BulkProcessor` 最多重试 8 次，两次重试之间的等待时间呈指数增长。有关 `BulkProcessor` 内部行为以及如何配置它的更多信息，请参阅以下部分。
+input.sinkTo(
+ new Elasticsearch7SinkBuilder[String]
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build())
+```
+{{< /tab >}}
+{{< /tabs >}}
-默认情况下，如果未提供失败处理程序，那么 sink 使用 `NoOpFailureHandler` 来简单处理所有的异常。
-连接器还提供了一个 `RetryRejectedExecutionFailureHandler` 实现，它总是重新添加由于队列容量已满导致失败的请求。
+上面的示例 sink 重新添加由于资源受限（例如：队列容量已满）而失败的请求。对于其它类型的故障，例如文档格式错误，sink 将会失败。
+如若未设置 BulkFlushBackoffStrategy (或者 `FlushBackoffType.NONE`)，那么任何类型的错误都会导致 sink 失败。
<p style="border-radius: 5px; padding: 5px" class="bg-danger">
<b>重要提示</b>：在失败时将请求重新添加回内部 <b>BulkProcessor</b> 会导致更长的 checkpoint，因为在进行 checkpoint 时，sink 还需要等待重新添加的请求被刷新。
-例如，当使用 <b>RetryRejectedExecutionFailureHandler</b> 时，
-checkpoint 需要等到 Elasticsearch 节点队列有足够的容量来处理所有挂起的请求。
-这也就意味着如果重新添加的请求永远不成功，checkpoint 也将永远不会完成。
+例如，当使用 <b>FlushBackoffType.EXPONENTIAL</b> 时，
+checkpoint 会进行等待直到 Elasticsearch 节点队列有足够的容量来处理所有挂起的请求，或者达到最大重试次数。
Review comment:
```suggestion
checkpoint 会进行等待，直到 Elasticsearch 节点队列有足够的容量来处理所有挂起的请求，或者达到最大重试次数。
```
##########
File path: docs/content.zh/docs/connectors/datastream/elasticsearch.md
##########
@@ -294,131 +210,163 @@ input.addSink(esSinkBuilder.build)
### Elasticsearch Sinks 和容错
-启用 Flink checkpoint 后，Flink Elasticsearch Sink 保证至少一次将操作请求发送到 Elasticsearch 集群。
+默认情况下，Flink Elasticsearch Sink 不会提供任何传递健壮性的保障。
+用户可以通过配置自行启用 Elasticsearch sink 的 at-least-once 语义。
+
+启用 Flink checkpoint 后，Flink Elasticsearch Sink 可以保证至少一次将操作请求发送到 Elasticsearch 集群。
这是通过在进行 checkpoint 时等待 `BulkProcessor` 中所有挂起的操作请求来实现。
这有效地保证了在触发 checkpoint 之前所有的请求被 Elasticsearch 成功确认，然后继续处理发送到 sink 的记录。
关于 checkpoint 和容错的更多详细信息，请参见[容错文档]({{< ref "docs/learn-flink/fault_tolerance" >}})。
-要使用具有容错特性的 Elasticsearch Sinks，需要在执行环境中启用作业拓扑的 checkpoint：
+要使用具有容错特性的 Elasticsearch Sinks，需要配置启用 at-least-once 分发并且在执行环境中启用作业拓扑的 checkpoint：
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+Elasticsearch 6:
```java
final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.enableCheckpointing(5000); // 每 5000 毫秒执行一次 checkpoint
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
+```
+
+Elasticsearch 7:
+```java
+final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // 每 5000 毫秒执行一次 checkpoint
+
+Elasticsearch7SinkBuilder sinkBuilder = new Elasticsearch7SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
```
{{< /tab >}}
{{< tab "Scala" >}}
+Elasticsearch 6:
```scala
val env = StreamExecutionEnvironment.getExecutionEnvironment()
env.enableCheckpointing(5000) // 每 5000 毫秒执行一次 checkpoint
+
+val sinkBuilder = new Elasticsearch6SinkBuilder[String]
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+```
+
+Elasticsearch 7:
+```scala
+val env = StreamExecutionEnvironment.getExecutionEnvironment()
+env.enableCheckpointing(5000) // 每 5000 毫秒执行一次 checkpoint
+
+val sinkBuilder = new Elasticsearch7SinkBuilder[String]
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
```
{{< /tab >}}
{{< /tabs >}}
-<p style="border-radius: 5px; padding: 5px" class="bg-danger">
-<b>注意</b>：如果用户愿意，可以通过在创建的
-<b> ElasticsearchSink </b>上调用 <b>disableFlushOnCheckpoint()</b> 来禁用刷新。请注意，
- 这实质上意味着 sink 将不再提供任何可靠的交付保证，即使启用了作业拓扑的 checkpoint。
-</p>
-
### 处理失败的 Elasticsearch 请求
Elasticsearch 操作请求可能由于多种原因而失败，包括节点队列容量暂时已满或者要被索引的文档格式错误。
-Flink Elasticsearch Sink 允许用户通过简单地实现一个 `ActionRequestFailureHandler` 并将其提供给构造函数来指定如何处理失败的请求。
+Flink Elasticsearch Sink 允许用户通过通过指定一个退避策略来重试请求。
下面是一个例子：
{{< tabs "ddb958b3-5dd5-476e-b946-ace3335628b2" >}}
{{< tab "Java" >}}
+Elasticsearch 6:
+```java
+DataStream<String> input = ...;
+
+input.sinkTo(
+ new Elasticsearch6SinkBuilder<String>()
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build());
+```
+
+Elasticsearch 7:
```java
DataStream<String> input = ...;
-input.addSink(new ElasticsearchSink<>(
- config, transportAddresses,
- new ElasticsearchSinkFunction<String>() {...},
- new ActionRequestFailureHandler() {
- @Override
- void onFailure(ActionRequest action,
- Throwable failure,
- int restStatusCode,
- RequestIndexer indexer) throw Throwable {
-
- if (ExceptionUtils.findThrowable(failure, EsRejectedExecutionException.class).isPresent()) {
- // 队列已满；重新添加文档进行索引
- indexer.add(action);
- } else if (ExceptionUtils.findThrowable(failure, ElasticsearchParseException.class).isPresent()) {
- // 文档格式错误；简单地删除请求避免 sink 失败
- } else {
- // 对于所有其他失败的请求，失败的 sink
- // 这里的失败只是简单的重新抛出，但用户也可以选择抛出自定义异常
- throw failure;
- }
- }
-}));
+input.sinkTo(
+ new Elasticsearch7SinkBuilder<String>()
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build());
```
{{< /tab >}}
{{< tab "Scala" >}}
+Elasticsearch 6:
```scala
val input: DataStream[String] = ...
-input.addSink(new ElasticsearchSink(
- config, transportAddresses,
- new ElasticsearchSinkFunction[String] {...},
- new ActionRequestFailureHandler {
- @throws(classOf[Throwable])
- override def onFailure(ActionRequest action,
- Throwable failure,
- int restStatusCode,
- RequestIndexer indexer) {
-
- if (ExceptionUtils.findThrowable(failure, EsRejectedExecutionException.class).isPresent()) {
- // 队列已满；重新添加文档进行索引
- indexer.add(action)
- } else if (ExceptionUtils.findThrowable(failure, ElasticsearchParseException.class).isPresent()) {
- // 文档格式错误；简单地删除请求避免 sink 失败
- } else {
- // 对于所有其他失败的请求，失败的 sink
- // 这里的失败只是简单的重新抛出，但用户也可以选择抛出自定义异常
- throw failure
- }
- }
-}))
+input.sinkTo(
+ new Elasticsearch6SinkBuilder[String]
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build())
```
-{{< /tab >}}
-{{< /tabs >}}
-上面的示例 sink 重新添加由于队列容量已满而失败的请求，同时丢弃文档格式错误的请求，而不会使 sink 失败。
-对于其它故障，sink 将会失败。如果未向构造器提供一个 `ActionRequestFailureHandler`，那么任何类型的错误都会导致 sink 失败。
+Elasticsearch 7:
+```scala
+val input: DataStream[String] = ...
-注意，`onFailure` 仅在 `BulkProcessor` 内部完成所有延迟重试后仍发生故障时被调用。
-默认情况下，`BulkProcessor` 最多重试 8 次，两次重试之间的等待时间呈指数增长。有关 `BulkProcessor` 内部行为以及如何配置它的更多信息，请参阅以下部分。
+input.sinkTo(
+ new Elasticsearch7SinkBuilder[String]
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter((element: String, context: SinkWriter.Context, indexer: RequestIndexer) =>
+ indexer.add(createIndexRequest(element)))
+ // 这里启用了一个指数退避重试策略，初始延迟为 1000 毫秒且最大重试次数为 5
+ .setBulkFlushBackoffStrategy(FlushBackoffType.EXPONENTIAL, 5, 1000)
+ .build())
+```
+{{< /tab >}}
+{{< /tabs >}}
-默认情况下，如果未提供失败处理程序，那么 sink 使用 `NoOpFailureHandler` 来简单处理所有的异常。
-连接器还提供了一个 `RetryRejectedExecutionFailureHandler` 实现，它总是重新添加由于队列容量已满导致失败的请求。
+上面的示例 sink 重新添加由于资源受限（例如：队列容量已满）而失败的请求。对于其它类型的故障，例如文档格式错误，sink 将会失败。
+如若未设置 BulkFlushBackoffStrategy (或者 `FlushBackoffType.NONE`)，那么任何类型的错误都会导致 sink 失败。
<p style="border-radius: 5px; padding: 5px" class="bg-danger">
<b>重要提示</b>：在失败时将请求重新添加回内部 <b>BulkProcessor</b> 会导致更长的 checkpoint，因为在进行 checkpoint 时，sink 还需要等待重新添加的请求被刷新。
-例如，当使用 <b>RetryRejectedExecutionFailureHandler</b> 时，
-checkpoint 需要等到 Elasticsearch 节点队列有足够的容量来处理所有挂起的请求。
-这也就意味着如果重新添加的请求永远不成功，checkpoint 也将永远不会完成。
+例如，当使用 <b>FlushBackoffType.EXPONENTIAL</b> 时，
+checkpoint 会进行等待直到 Elasticsearch 节点队列有足够的容量来处理所有挂起的请求，或者达到最大重试次数。
</p>
### 配置内部批量处理器
-通过在提供的 `Map<String, String>` 中设置以下值，内部 `BulkProcessor` 可以进一步配置其如何刷新缓存操作请求的行为：
+通过使用以下在 Elasticsearch6SinkBuilder 中提供的方法，可以进一步配置内部的 `BulkProcessor` 关于其如何刷新缓存操作请求的行为：
- * **bulk.flush.max.actions**：刷新前最大缓存的操作数。
- * **bulk.flush.max.size.mb**：刷新前最大缓存的数据量（以兆字节为单位）。
- * **bulk.flush.interval.ms**：刷新的时间间隔（不论缓存操作的数量或大小如何）。
+ * **setBulkFlushMaxActions(int numMaxActions)**：刷新前最大缓存的操作数。
+ * **setBulkFlushMaxSizeMb(int maxSizeMb)**：刷新前最大缓存的数据量（以兆字节为单位）。
+ * **setBulkFlushInterval(long intervalMillis)**：刷新的时间间隔（不论缓存操作的数量或大小如何）。
-对于 2.x 及以上版本，还支持配置如何重试临时请求错误：
+还支持配置如何对暂时性请求错误进行重试：
- * **bulk.flush.backoff.enable**：如果一个或多个请求由于临时的 `EsRejectedExecutionException` 而失败，是否为刷新执行带有延迟的重试操作。
- * **bulk.flush.backoff.type**：延迟重试的类型，`CONSTANT` 或者 `EXPONENTIAL`。
- * **bulk.flush.backoff.delay**：延迟重试的时间间隔。对于常量延迟来说，此值是每次重试间的间隔。对于指数延迟来说，此值是延迟的初始值。
- * **bulk.flush.backoff.retries**：延迟重试次数。
+ * **setBulkFlushBackoffStrategy(FlushBackoffType flushBackoffType, int maxRetries, long delayMillis)**：延迟重试的类型，`CONSTANT` 或者 `EXPONENTIAL`，延迟重试次数，延迟重试的时间间隔。
Review comment:
```suggestion
* **setBulkFlushBackoffStrategy(FlushBackoffType flushBackoffType, int maxRetries, long delayMillis)**：退避延迟的类型，`CONSTANT` 或者 `EXPONENTIAL`，退避重试次数，退避重试的时间间隔。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 280f073dec75735ba97cdc12cb61f9de2b00a31e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18322:
URL: https://github.com/apache/flink/pull/18322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] biyuhao commented on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
biyuhao commented on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009711047
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 310b62a595a1af2d091b6a0f2e8fc137460b92e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc03961d8630702f3709d74c07684083c812c99c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18322: [FLINK-25589][docs][connectors] Update Chinese version of Elasticsearch connector docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18322:
URL: https://github.com/apache/flink/pull/18322#issuecomment-1009605866
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"triggerType" : "PUSH"
}, {
"hash" : "310b62a595a1af2d091b6a0f2e8fc137460b92e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29216",
"triggerID" : "1009711047",
"triggerType" : "MANUAL"
}, {
"hash" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271",
"triggerID" : "280f073dec75735ba97cdc12cb61f9de2b00a31e",
"triggerType" : "PUSH"
}, {
"hash" : "bc03961d8630702f3709d74c07684083c812c99c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457",
"triggerID" : "bc03961d8630702f3709d74c07684083c812c99c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 280f073dec75735ba97cdc12cb61f9de2b00a31e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29271)
* bc03961d8630702f3709d74c07684083c812c99c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29457)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org