You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jg...@apache.org on 2018/03/19 20:30:19 UTC
[kafka] branch trunk updated: MINOR: KafkaFutureImpl#addWaiter
should be protected (#4734)
This is an automated email from the ASF dual-hosted git repository.
jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 27bb3cc MINOR: KafkaFutureImpl#addWaiter should be protected (#4734)
27bb3cc is described below
commit 27bb3ccaceae52c730b2c02d72c63a84060966f1
Author: Colin Patrick McCabe <co...@cmccabe.xyz>
AuthorDate: Mon Mar 19 13:30:13 2018 -0700
MINOR: KafkaFutureImpl#addWaiter should be protected (#4734)
KafkaFutureImpl#addWaiter should be protected, just like KafkaFuture#addWaiter. As described in KIP-218, whenComplete is the public API, not addWaiter.
---
.../main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java b/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
index 049ed49..b1e5b6d 100644
--- a/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
+++ b/clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java
@@ -192,7 +192,7 @@ public class KafkaFutureImpl<T> extends KafkaFuture<T> {
return future;
}
- public synchronized void addWaiter(BiConsumer<? super T, ? super Throwable> action) {
+ protected synchronized void addWaiter(BiConsumer<? super T, ? super Throwable> action) {
if (exception != null) {
action.accept(null, exception);
} else if (done) {
--
To stop receiving notification emails like this one, please contact
jgus@apache.org.