You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/20 06:28:42 UTC

[GitHub] [pulsar] Jason918 commented on pull request #14759: [enh][broker] Support dynamic update between non-zero values of brokerPublisherThrottlingTickTimeMillis

Jason918 commented on pull request #14759:
URL: https://github.com/apache/pulsar/pull/14759#issuecomment-1073178046


   > Overall looks good to me. Currently, the test only covers `PublishRateLimiterMonitor `. Could we add a test to verify dynamic update values of `brokerPublisherThrottlingTickTimeMillis` using the BrokerService to make sure the BrokerService works fine?
   
   @RobertIndie 
   Added unit test org.apache.pulsar.broker.service.BrokerServiceTest#testDynamicBrokerPublisherThrottlingTickTimeMillis PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org