You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/02/27 04:29:58 UTC
[jira] Resolved: (NET-289) StackOverflowError in Threader
[ https://issues.apache.org/jira/browse/NET-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-289.
----------------------
Resolution: Fixed
Fix Version/s: 3.0
> StackOverflowError in Threader
> ------------------------------
>
> Key: NET-289
> URL: https://issues.apache.org/jira/browse/NET-289
> Project: Commons Net
> Issue Type: Bug
> Components: NNTP
> Reporter: Luc Claes
> Priority: Minor
> Fix For: 3.0
>
>
> The loop detection code in Threader.buildContainer() is currently:
> // Link references together in the order they appear in the References: header,
> // IF they dont have a have a parent already &&
> // IF it will not cause a circular reference
> if ((parentRef != null)
> && (ref.parent == null)
> && (parentRef != ref)
> && !(parentRef.findChild(ref))) {
> // Link ref into the parent's child list
> Deep circular references where 'parentRef' is already a child of 'ref' and ref is the root container are possible.
> The test should be:
> if ((parentRef != null)
> && (ref.parent == null)
> && (parentRef != ref)
> && !(ref.findChild(parentRef))) {
> // Link ref into the parent's child list
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira