You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/12/23 10:48:09 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2525: Activate GitHub Actions on all PRs and on push
eolivelli opened a new pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525
### Motivation
Currently we are not running PR validation for Pull Requests against release branches (as branch-4.12).
Also we are not running tests on master branch and we do not have Jenkins anymore
### Changes
- Enable PR validation for pull requests against all release branches
- Enable GitHub actions on "push"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on a change in pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525#discussion_r547898504
##########
File path: .github/workflows/compatibility-check-java8.yml
##########
@@ -20,9 +20,11 @@
name: Compatibility Check Java8
on:
+ push;
Review comment:
looks like a typo. `;` -> `:`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525#discussion_r547959108
##########
File path: .github/workflows/compatibility-check-java8.yml
##########
@@ -20,9 +20,11 @@
name: Compatibility Check Java8
on:
+ push;
Review comment:
thanks @lhotari
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525#issuecomment-750473595
@sijie can you please help merging this patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Ghatage merged pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
Ghatage merged pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525#issuecomment-750127846
@lhotari can you please take a look ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Ghatage commented on pull request #2525: Activate GitHub Actions on all PRs and on push
Posted by GitBox <gi...@apache.org>.
Ghatage commented on pull request #2525:
URL: https://github.com/apache/bookkeeper/pull/2525#issuecomment-750482476
Big man might be busy, I gotchu @eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org