Re: Review Request 18600: Allowed replicated log to do auto initialization.

[Jie Yu <yu...@gmail.com>]

> On March 27, 2014, 11:38 p.m., Ben Mahler wrote:
> > src/log/log.hpp, line 193
> > <https://reviews.apache.org/r/18600/diff/8/?file=525771#file525771line193>
> >
> >     Can you update the documentation?
> >     
> >     I'm a bit hesitant about having an implicit 'auto-initialize=false', since it's less usable (from a developer/operator perspective). Maybe we should default to 'true' or require it to be specified?
> >     
> >     Up to you if you want to preserve the old API.

Yeah, let's preserve the old API in this patch, having another patch for changing the default.


> On March 27, 2014, 11:38 p.m., Ben Mahler wrote:
> > src/log/recover.cpp, lines 237-238
> > <https://reviews.apache.org/r/18600/diff/8/?file=525774#file525774line237>
> >
> >     Would you mind re-ordering to add EMPTY + STARTING just so that it matches your comments above? Ditto below for STARTING + VOTING.

Done.


> On March 27, 2014, 11:38 p.m., Ben Mahler wrote:
> > src/log/recover.cpp, lines 363-365
> > <https://reviews.apache.org/r/18600/diff/8/?file=525774#file525774line363>
> >
> >     Maybe we should make the transition to VOTING more explicit in the comment here?
> >     
> >     "If auto-initialization is enabled, all replicas will first go into STARTING status. Once *all* replicas have transitioned out of EMPTY status, the replicas will go into VOTING status."

Done.


> On March 27, 2014, 11:38 p.m., Ben Mahler wrote:
> > src/log/recover.cpp, line 430
> > <https://reviews.apache.org/r/18600/diff/8/?file=525774#file525774line430>
> >
> >     "re-running"?

Done.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18600/#review38826
-----------------------------------------------------------


On March 17, 2014, 11:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18600/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 11:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-984
>     https://issues.apache.org/jira/browse/MESOS-984
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/log.hpp c2cb6cf 
>   src/log/log.cpp d9b2687 
>   src/log/recover.hpp 634bc06 
>   src/log/recover.cpp 688da5f 
>   src/tests/log_tests.cpp b368cde 
> 
> Diff: https://reviews.apache.org/r/18600/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>