You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/17 07:00:40 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #10080: chore: [logging] add selected tab name into perf logging

graceguo-supercat opened a new pull request #10080:
URL: https://github.com/apache/incubator-superset/pull/10080


   ### SUMMARY
   Add extra data into dashboard perf logging:
   - log target tab name when user switch dashboard tab
   - dashboard initial bootstrap data length
   
   
   ### TEST PLAN
   sample log data:
   <img width="941" alt="Screen Shot 2020-06-16 at 11 59 13 PM" src="https://user-images.githubusercontent.com/27990562/84865681-7ae3fc80-b02d-11ea-9927-ac1bedd2b659.png">
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10080: chore: [logging] add selected tab name into perf logging

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10080:
URL: https://github.com/apache/incubator-superset/pull/10080#issuecomment-647637451


   Here is a sample dashboard which airbnb is building, to show Superset usage and stats. These information will help dashboard owners see how viewers explore his dashboard:
   ![screencapture-superset-d-musta-ch-superset-dashboard-14268-2020-06-22-09_38_15](https://user-images.githubusercontent.com/27990562/85312808-3660c280-b46c-11ea-847a-0842e3f8fab0.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on pull request #10080: chore: [logging] add selected tab name into perf logging

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10080:
URL: https://github.com/apache/incubator-superset/pull/10080#issuecomment-647317114


   Could you provide more context on why is this information useful and how can it be used to improve Superset?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #10080: chore: [logging] add selected tab name into perf logging

Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #10080:
URL: https://github.com/apache/incubator-superset/pull/10080#issuecomment-647637451


   - bootstrap data size is used to track and understand initial page load duration
   
   - Here is a sample dashboard which airbnb is building, to show Superset usage and stats. These information will help dashboard owners see how viewers explore his dashboard:
   ![screencapture-superset-d-musta-ch-superset-dashboard-14268-2020-06-22-09_38_15](https://user-images.githubusercontent.com/27990562/85312808-3660c280-b46c-11ea-847a-0842e3f8fab0.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] graceguo-supercat merged pull request #10080: chore: [logging] add selected tab name into perf logging

Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #10080:
URL: https://github.com/apache/incubator-superset/pull/10080


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org