You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/11/30 21:27:17 UTC

[superset] 01/02: remove styles from renderCell

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch grid-improv
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 4d01abb904fabeabe976979672c16698dba8ec5a
Author: hughhhh <hu...@gmail.com>
AuthorDate: Sun Nov 28 19:50:34 2021 -0800

    remove styles from renderCell
---
 .../src/components/FilterableTable/FilterableTable.tsx  | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
index 9714907..d8313b6 100644
--- a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
+++ b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
@@ -426,22 +426,9 @@ export default class FilterableTable extends PureComponent<
   }) {
     const columnKey = this.props.orderedColumnKeys[columnIndex];
     const cellData = this.list[rowIndex][columnKey];
-    const cellText = this.getCellContent({ cellData, columnKey });
-    const content =
-      cellData === null ? <i className="text-muted">{cellText}</i> : cellText;
     const cellNode = (
-      <div
-        key={key}
-        style={{
-          ...style,
-          top:
-            typeof style.top === 'number'
-              ? style.top - GRID_POSITION_ADJUSTMENT
-              : style.top,
-        }}
-        className={`grid-cell ${this.rowClassName({ index: rowIndex })}`}
-      >
-        <div css={{ width: 'inherit' }}>{content}</div>
+      <div key={key} style={style}>
+        {this.getCellContent({ cellData, columnKey })}
       </div>
     );