You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/08 11:33:04 UTC

[GitHub] [calcite] NobiGo commented on a change in pull request #2633: [CALCITE-4851] Build gives lots of 'Execution optimizations have been disabled' warnings

NobiGo commented on a change in pull request #2633:
URL: https://github.com/apache/calcite/pull/2633#discussion_r764784331



##########
File path: babel/build.gradle.kts
##########
@@ -52,6 +52,14 @@ val javaCCMain by tasks.registering(org.apache.calcite.buildtools.javacc.JavaCCT
     packageName.set("org.apache.calcite.sql.parser.babel")
 }
 
+tasks.autostyleJavaCheck {
+    dependsOn(javaCCMain)
+}
+
+tasks.checkstyleMain {
+    dependsOn(javaCCMain)
+}

Review comment:
       > This would break in case `-PskipCheckstyle` or `-PskipAutostyle`. Something like https://github.com/apache/jmeter/blob/0938f50e15cc62e2de645b823def881364e64b78/src/core/build.gradle.kts#L145-L160 might do.
   
   done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org