You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by ky...@apache.org on 2018/12/21 08:06:39 UTC

[incubator-weex] branch master updated: [WEEX][Android] When LoadMoreOffset Not Set Load More Function Not Fired (#1949)

This is an automated email from the ASF dual-hosted git repository.

kyork pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-weex.git


The following commit(s) were added to refs/heads/master by this push:
     new c9b1c7f  [WEEX][Android] When LoadMoreOffset Not Set  Load More Function Not Fired (#1949)
c9b1c7f is described below

commit c9b1c7fd3a33b8bb693c7c6fd75108a4a9165610
Author: codefurture <gu...@163.com>
AuthorDate: Fri Dec 21 16:06:35 2018 +0800

    [WEEX][Android] When LoadMoreOffset Not Set  Load More Function Not Fired (#1949)
    
    * [WEEX][Android] When LoadMoreOffset Not Set  Load More Function Not Fired
---
 .../java/com/taobao/weex/ui/component/list/BasicListComponent.java     | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index b3546d1..3d7393f 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -1218,8 +1218,7 @@ public abstract class BasicListComponent<T extends ViewGroup & ListComponentView
       }
       float offsetParsed = WXViewUtils.getRealPxByWidth(Integer.parseInt(offset),getInstance().getInstanceViewPortWidth());
 
-      if (offScreenY < offsetParsed) {
-
+      if (offScreenY <= offsetParsed && getEvents().contains(Constants.Event.LOADMORE)) {
         if (mListCellCount != mChildren.size()
             || mForceLoadmoreNextTime) {
           fireEvent(Constants.Event.LOADMORE);