You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "anujphadke (Code Review)" <ge...@cloudera.org> on 2017/06/01 05:43:25 UTC
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
anujphadke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7038
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
---
M testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_nested_types.py
M tests/query_test/test_queries.py
3 files changed, 33 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/7038/1
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7038/3/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:
Line 264: BIGINT, STRING
nit: lower case types as well
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7038/3/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:
Line 264: bigint, string
> nit: lower case types as well
Done
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Change looks good, my only question is whether we need the test coverage. It looks like the tests are not redundant with other tests.
http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test
File testdata/workloads/functional-query/queries/QueryTest/subplans.test:
Line 229: 16
> These tests have not been running for a while.
It looks like the things you fixed were invalid beforehand (unquoted strings, wrong # of types).
It looks like Alex added the tests so he may know whether this is missing coverage or whether the nested types tests cover this.
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7038/2/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:
Line 257: SELECT count(okey), opriority
please make the casing of these new tests consistent with the others in this file
Line 331: ---- RESULTS: VERIFY_IS_EQUAL_SORTED
remove the "VERIFY_IS_EQUAL_SORTED" part since it's not needed here
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test
File testdata/workloads/functional-query/queries/QueryTest/subplans.test:
Line 229: 16
These tests have not been running for a while.
I am not sure if this test has regressed or the data has changed?
Does anyone how do I check what the correct result is?
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7038/2/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:
Line 257: select count(okey), opriority
> please make the casing of these new tests consistent with the others in thi
Done
Line 331: ---- RESULTS:
> remove the "VERIFY_IS_EQUAL_SORTED" part since it's not needed here
Done
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 4: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/696/
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7038
to look at the new patch set (#3).
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
D testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_queries.py
3 files changed, 44 insertions(+), 236 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/7038/3
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7038
to look at the new patch set (#5).
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
D testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_queries.py
3 files changed, 34 insertions(+), 239 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/7038/5
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7038
to look at the new patch set (#4).
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
D testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_queries.py
3 files changed, 47 insertions(+), 239 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/7038/4
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7038
to look at the new patch set (#2).
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
D testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_queries.py
3 files changed, 44 insertions(+), 236 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/7038/2
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
IMPALA-5400: Execute tests in subplans.test
This change executes the tests added to subplans.test and removes
a test which incorrectly references subplannull_data.test (a file
which does not exist)
Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Reviewed-on: http://gerrit.cloudera.org:8080/7038
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
D testdata/workloads/functional-query/queries/QueryTest/subplans.test
M tests/query_test/test_queries.py
3 files changed, 34 insertions(+), 239 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 5:
Removing the test that failed.
Raised a JIRA to track it -
https://issues.apache.org/jira/browse/IMPALA-5438
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/698/
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/696/
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 2:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test
File testdata/workloads/functional-query/queries/QueryTest/subplans.test:
Line 1
> Let's merge these tests into nested-types-subplan.test. I'll add comments w
Done
Line 3
> Merge into nested-types-subplan.test
Impala-5438 will add a new test.
Line 36
> Remove. Already covered in nested-types-subplan.test
Done
Line 50
> Remove. Already covered in nested-types-subplan.test
Done
Line 63
> Remove. Already covered in nested-types-subplan.test
Done
Line 87
> Remove. Already covered in nested-types-subplan.test
Done
Line 110
> Remove. Already covered in nested-types-subplan.test
Done
Line 124
> Remove. Already covered in nested-types-subplan.test
Done
Line 137
> Remove. Already covered in nested-types-subplan.test
Done
Line 158
> Remove. Already covered in nested-types-subplan.test
Done
Line 171
> Remove. Already covered in nested-types-subplan.test
Done
Line 188
> Merge into nested-types-subplan.test
Done
Line 205
> Merge into nested-types-subplan.test
Done
Line 219
> Merge into nested-types-subplan.test
Done
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5400: Execute tests in subplans.test
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5400: Execute tests in subplans.test
......................................................................
Patch Set 1:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/7038/1/testdata/workloads/functional-query/queries/QueryTest/subplans.test
File testdata/workloads/functional-query/queries/QueryTest/subplans.test:
Line 1: ====
Let's merge these tests into nested-types-subplan.test. I'll add comments whether a test should be merged or removed due to duplicate coverage.
For the tests to be merged, please don't just append them at the end, but look for the appropriate place. The tests in nested-types-subplan.test try to systematically cover all exec nodes inside a subplan.
Line 3: # Test a union inside a subplan with some constant operands.
Merge into nested-types-subplan.test
Line 36: # Test an order by + limit (topn node) inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 50: # Test a select node inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 63: # Test an analytic function that requires a sort inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 87: # Test an analytic function that does not require a sort inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 110: # Test a non-grouping aggregation inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 124: SELECT c_custkey, avg(maxp)
Remove. Already covered in nested-types-subplan.test
Line 137: # Test a grouping aggregation inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 158: # Test a join inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 171: # Test a self-join inside a subplan.
Remove. Already covered in nested-types-subplan.test
Line 188: # Test a left outer join inside a subplan.
Merge into nested-types-subplan.test
Line 205: # Test a right outer join inside a subplan.
Merge into nested-types-subplan.test
Line 219: # IMPALA-2368: Test nested subplans with a non-trivial plan tree.
Merge into nested-types-subplan.test
--
To view, visit http://gerrit.cloudera.org:8080/7038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b4f47553fb8f5fe3425cde2e0bcb3245c39b91
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes