You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/03/31 09:06:27 UTC

[jira] Created: (SOLR-1857) cleanup and sync analysis with lucene trunk

cleanup and sync analysis with lucene trunk
-------------------------------------------

                 Key: SOLR-1857
                 URL: https://issues.apache.org/jira/browse/SOLR-1857
             Project: Solr
          Issue Type: Task
          Components: Schema and Analysis
    Affects Versions: 3.1
            Reporter: Robert Muir
             Fix For: 3.1


Solr works on the lucene trunk, but uses a lot of deprecated APIs.
Additionally two factories are missing, the Keyword and StemmerOverride filters.
The code can be improved with 3.x's generics support, removing casts, etc.
Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1857) cleanup and sync analysis with lucene trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852079#action_12852079 ] 

Robert Muir commented on SOLR-1857:
-----------------------------------

if no one objects, I would like to commit in a day or two. If anyone wants to review, thats great... i know its large...

> cleanup and sync analysis with lucene trunk
> -------------------------------------------
>
>                 Key: SOLR-1857
>                 URL: https://issues.apache.org/jira/browse/SOLR-1857
>             Project: Solr
>          Issue Type: Task
>          Components: Schema and Analysis
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1
>
>         Attachments: SOLR-1857.patch
>
>
> Solr works on the lucene trunk, but uses a lot of deprecated APIs.
> Additionally two factories are missing, the Keyword and StemmerOverride filters.
> The code can be improved with 3.x's generics support, removing casts, etc.
> Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1857) cleanup and sync analysis with lucene trunk

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852094#action_12852094 ] 

Yonik Seeley commented on SOLR-1857:
------------------------------------

I just did a 5 min review, not line-by-line, but seems fine in general.

> cleanup and sync analysis with lucene trunk
> -------------------------------------------
>
>                 Key: SOLR-1857
>                 URL: https://issues.apache.org/jira/browse/SOLR-1857
>             Project: Solr
>          Issue Type: Task
>          Components: Schema and Analysis
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1
>
>         Attachments: SOLR-1857.patch
>
>
> Solr works on the lucene trunk, but uses a lot of deprecated APIs.
> Additionally two factories are missing, the Keyword and StemmerOverride filters.
> The code can be improved with 3.x's generics support, removing casts, etc.
> Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-1857) cleanup and sync analysis with lucene trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir reassigned SOLR-1857:
---------------------------------

    Assignee: Robert Muir

> cleanup and sync analysis with lucene trunk
> -------------------------------------------
>
>                 Key: SOLR-1857
>                 URL: https://issues.apache.org/jira/browse/SOLR-1857
>             Project: Solr
>          Issue Type: Task
>          Components: Schema and Analysis
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1
>
>         Attachments: SOLR-1857.patch
>
>
> Solr works on the lucene trunk, but uses a lot of deprecated APIs.
> Additionally two factories are missing, the Keyword and StemmerOverride filters.
> The code can be improved with 3.x's generics support, removing casts, etc.
> Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1857) cleanup and sync analysis with lucene trunk

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated SOLR-1857:
------------------------------

    Attachment: SOLR-1857.patch

attached is a regrettably large patch to sync us up, and clean things up a bit.

this removes all use of deprecated lucene APIs, except via things that are now deprecated in Solr itself.

All tests pass.

> cleanup and sync analysis with lucene trunk
> -------------------------------------------
>
>                 Key: SOLR-1857
>                 URL: https://issues.apache.org/jira/browse/SOLR-1857
>             Project: Solr
>          Issue Type: Task
>          Components: Schema and Analysis
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>             Fix For: 3.1
>
>         Attachments: SOLR-1857.patch
>
>
> Solr works on the lucene trunk, but uses a lot of deprecated APIs.
> Additionally two factories are missing, the Keyword and StemmerOverride filters.
> The code can be improved with 3.x's generics support, removing casts, etc.
> Finally there is some code duplication with lucene, and some cleanup (such as deprecating factories for stuff thats deprecated in trunk).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.