You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/24 11:19:27 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5666: [HUDI-3193] Decouple hudi-aws from hudi-client-common

xushiyan commented on code in PR #5666:
URL: https://github.com/apache/hudi/pull/5666#discussion_r880378853


##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AwsGlueCatalogSyncTool.java:
##########
@@ -65,6 +63,56 @@ public static void main(String[] args) {
     FileSystem fs = FSUtils.getFs(cfg.basePath, new Configuration());
     HiveConf hiveConf = new HiveConf();
     hiveConf.addResource(fs.getConf());
-    new AwsGlueCatalogSyncTool(cfg, hiveConf, fs).syncHoodieTable();
+    AwsGlueCatalogSyncTool.newBuilder()

Review Comment:
   the builder pattern is good. but do you need it be in this PR? i was only expecting pom.xml changes :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org