[GitHub] [lucene] msokolov edited a comment on pull request #238: LUCENE-10016: add support for Knnvector index and query to the demo

[GitBox <gi...@apache.org>]

msokolov edited a comment on pull request #238:
URL: https://github.com/apache/lucene/pull/238#issuecomment-894794744


   I'm open to moving the `KnnVectorDictFilter` somewhere else, maybe sandbox is appropriate, but I do we want to keep `demo` dependencies minimal?
   
   @mocobeta  your idea for a more standalone demo is intriguing; I struggled a bit with how to provide meaningful vectors without dumping in a huge amount of data. So what I did was to take the GloVe vectors and join with the terms that occur in the demo documents. So what we're doing here is different from the benchmarks since we're redistributing (a portion of) the GloVe data, unlike benchmarks which requires the user to download the wikipedia data (or does it for them). Re: licensing. I'm happy to do whatever is right; thought I'd err on the side of caution and provide some attribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org