[GitHub] [lucene-solr] epugh commented on pull request #2643: SOLR-9359 Make Config API work for warming queries

[GitBox <gi...@apache.org>]

epugh commented on pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1048668234


   I like what this does, but I totally agree about all the `getClass()`/`instanceof` stuff!   I wonder if burying all that logic into a method with a name like `normalizeArgsToQueries()` or maybe just `bewareHereBeDragons()` ;-) might help someone understand that this logic is odd....     
   
   Is there a way to reduce the complexity of `NamedLists` and `ArrayLists` and the variation in the JSON structure????   
   
   Do we have a test that at least demonstrates the fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org