You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@jakarta.apache.org by sebb <se...@gmail.com> on 2007/11/24 23:45:15 UTC

[VOTE] JMeter 2.3.1RC1

I've created JMeter 2.3.1 RC1 in the directory:

http://people.apache.org/~sebb/jmeter-2.3.1/dist

Site/Docs are here:
http://people.apache.org/~sebb/jmeter-2.3.1/docs

Tag:
http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1

Keys are here:
http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
also
http://www.apache.org/dist/jakarta/jmeter/KEYS

All feedback (and votes!) welcome.

[ ]+1 - the release candidate is OK
[ ]-1 - there is a problem (please indicate what it is)

The vote will remain open for at least 72 hours.

If the vote passes, the intention is to create a formal 2.3.1 release
from the RC1 tag.

Here's my:

+1

sebb AT apache DOT org

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
For additional commands, e-mail: general-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 27/11/2007, sebb <se...@gmail.com> wrote:
> On 27/11/2007, Rahul Akolkar <ra...@gmail.com> wrote:
> > +1
>
> Thanks!
>
> > Nits:
> >  * Expected the source distro to just build (setup is odd, as Hen has
> > commented in more detail)
>
> As mentioned in my reply to him, the 3rd party libraries are very large.
>
> >  * Jar file names are odd (for example, IMO,
> > apache-jmeter-core-n.n.jar is better than ApacheJMeter_core.jar)
>
> OK, I'll fix that for the next release.

Tried changing the names, but that caused several scripts to stop working.

Since users may also have their own scripts which refer to at least
some of the jars directly, a name change here is not trivial - unlike
say for most libraries where the name is irrelevant.

The jars all contain manifests with the version details in them, so it
is possible to find out their versions.

> >  * README file, licensing and legal issues section, third list item is
> > "lib/LICENSE*" but should be "LICENSE(*).txt" or some such instead
>
> Good catch - they were moved from lib; README should have been updated.
>
> > -Rahul
> >
> >
> > On 11/24/07, sebb <se...@gmail.com> wrote:
> > > I've created JMeter 2.3.1 RC1 in the directory:
> > >
> > > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> > >
> > > Site/Docs are here:
> > > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> > >
> > > Tag:
> > > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> > >
> > > Keys are here:
> > > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > > also
> > > http://www.apache.org/dist/jakarta/jmeter/KEYS
> > >
> > > All feedback (and votes!) welcome.
> > >
> > > [ ]+1 - the release candidate is OK
> > > [ ]-1 - there is a problem (please indicate what it is)
> > >
> > > The vote will remain open for at least 72 hours.
> > >
> > > If the vote passes, the intention is to create a formal 2.3.1 release
> > > from the RC1 tag.
> > >
> > > Here's my:
> > >
> > > +1
> > >
> > > sebb AT apache DOT org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 27/11/2007, Rahul Akolkar <ra...@gmail.com> wrote:
> +1

Thanks!

> Nits:
>  * Expected the source distro to just build (setup is odd, as Hen has
> commented in more detail)

As mentioned in my reply to him, the 3rd party libraries are very large.

>  * Jar file names are odd (for example, IMO,
> apache-jmeter-core-n.n.jar is better than ApacheJMeter_core.jar)

OK, I'll fix that for the next release.

>  * README file, licensing and legal issues section, third list item is
> "lib/LICENSE*" but should be "LICENSE(*).txt" or some such instead

Good catch - they were moved from lib; README should have been updated.

> -Rahul
>
>
> On 11/24/07, sebb <se...@gmail.com> wrote:
> > I've created JMeter 2.3.1 RC1 in the directory:
> >
> > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> >
> > Site/Docs are here:
> > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> >
> > Tag:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> >
> > Keys are here:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > also
> > http://www.apache.org/dist/jakarta/jmeter/KEYS
> >
> > All feedback (and votes!) welcome.
> >
> > [ ]+1 - the release candidate is OK
> > [ ]-1 - there is a problem (please indicate what it is)
> >
> > The vote will remain open for at least 72 hours.
> >
> > If the vote passes, the intention is to create a formal 2.3.1 release
> > from the RC1 tag.
> >
> > Here's my:
> >
> > +1
> >
> > sebb AT apache DOT org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by Rahul Akolkar <ra...@gmail.com>.
+1

Nits:
 * Expected the source distro to just build (setup is odd, as Hen has
commented in more detail)
 * Jar file names are odd (for example, IMO,
apache-jmeter-core-n.n.jar is better than ApacheJMeter_core.jar)
 * README file, licensing and legal issues section, third list item is
"lib/LICENSE*" but should be "LICENSE(*).txt" or some such instead

-Rahul


On 11/24/07, sebb <se...@gmail.com> wrote:
> I've created JMeter 2.3.1 RC1 in the directory:
>
> http://people.apache.org/~sebb/jmeter-2.3.1/dist
>
> Site/Docs are here:
> http://people.apache.org/~sebb/jmeter-2.3.1/docs
>
> Tag:
> http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
>
> Keys are here:
> http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> also
> http://www.apache.org/dist/jakarta/jmeter/KEYS
>
> All feedback (and votes!) welcome.
>
> [ ]+1 - the release candidate is OK
> [ ]-1 - there is a problem (please indicate what it is)
>
> The vote will remain open for at least 72 hours.
>
> If the vote passes, the intention is to create a formal 2.3.1 release
> from the RC1 tag.
>
> Here's my:
>
> +1
>
> sebb AT apache DOT org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 27/11/2007, Henri Yandell <ba...@apache.org> wrote:
> +1, with various minor notes.

Thanks!

> Signatures are good. MD5s are good.
>
> The src tgz contains:
>
> > jakarta-jmeter-2.3.1RC1/bin/jmeter
> > jakarta-jmeter-2.3.1RC1/bin/jmeter-server
> > jakarta-jmeter-2.3.1RC1/bin/jmeter.sh
>
> but the src zip does not.
>

Oops! Those are run-time only files, and should not be in either source archive.

> Otherwise the archives seem the same.
>
> The build fails for just the source. I know the README says to unpack
> both source and binary, but it would be good if the build.xml could
> state that too. It's an odd thing to do.

It's because of the number and size of the libraries - there are some
8Mb of them.
They obviously have to be in the binary distribution; seems wasteful
and unnecessary to include them in the source as well.

I'll add some checks/messages to build.xml to make it clearer.

> =-=-=-=
> Buildfile: build.xml
>
> clean:
>   [delete] DEPRECATED - Use of the implicit FileSet is deprecated.
> Use a nested fileset element instead.
>
> BUILD FAILED
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/build.xml:1349:
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/lib/ext not found.
> =-=-=-=-=
> The build succeeds once I follow the instructions correctly; and
> JMeter started happily (though I didn't test actually using it).
>
> "ant test" fails; there are two failures and one error. I'm running on
> OS X 10.4, JDK 1.5, Ant 1.6.5.
>
> Error: 1) org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception:
> Could not start mirror server

This is intermittent. I've fixed it for future releases.

> Failure: 1) BSH1(org.apache.jmeter.functions.PackageTest)junit.framework.AssertionFailedError:
> BeanShell not present
> Failure: 2) testTimerBSH(org.apache.jmeter.timers.PackageTest)junit.framework.AssertionFailedError:
> expected:<60> but was:<0>

These are both because BeanShell is not present.

The test output needs to make this clearer.

> Website wise, the download binary and download source links should be
> changed to a single Download link pointing to:
>
> http://jakarta.apache.org/site/downloads/downloads_jmeter.cgi

OK, I'll fix that for later releases.

> The bugs page has a typo (Bugzilla + BugZilla).

OK.

> Hen
>
> On Nov 24, 2007 2:45 PM, sebb <se...@gmail.com> wrote:
> > I've created JMeter 2.3.1 RC1 in the directory:
> >
> > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> >
> > Site/Docs are here:
> > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> >
> > Tag:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> >
> > Keys are here:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > also
> > http://www.apache.org/dist/jakarta/jmeter/KEYS
> >
> > All feedback (and votes!) welcome.
> >
> > [ ]+1 - the release candidate is OK
> > [ ]-1 - there is a problem (please indicate what it is)
> >
> > The vote will remain open for at least 72 hours.
> >
> > If the vote passes, the intention is to create a formal 2.3.1 release
> > from the RC1 tag.
> >
> > Here's my:
> >
> > +1
> >
> > sebb AT apache DOT org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: general-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: general-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 27/11/2007, Henri Yandell <ba...@apache.org> wrote:
> +1, with various minor notes.

Thanks!

> Signatures are good. MD5s are good.
>
> The src tgz contains:
>
> > jakarta-jmeter-2.3.1RC1/bin/jmeter
> > jakarta-jmeter-2.3.1RC1/bin/jmeter-server
> > jakarta-jmeter-2.3.1RC1/bin/jmeter.sh
>
> but the src zip does not.
>

Oops! Those are run-time only files, and should not be in either source archive.

> Otherwise the archives seem the same.
>
> The build fails for just the source. I know the README says to unpack
> both source and binary, but it would be good if the build.xml could
> state that too. It's an odd thing to do.

It's because of the number and size of the libraries - there are some
8Mb of them.
They obviously have to be in the binary distribution; seems wasteful
and unnecessary to include them in the source as well.

I'll add some checks/messages to build.xml to make it clearer.

> =-=-=-=
> Buildfile: build.xml
>
> clean:
>   [delete] DEPRECATED - Use of the implicit FileSet is deprecated.
> Use a nested fileset element instead.
>
> BUILD FAILED
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/build.xml:1349:
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/lib/ext not found.
> =-=-=-=-=
> The build succeeds once I follow the instructions correctly; and
> JMeter started happily (though I didn't test actually using it).
>
> "ant test" fails; there are two failures and one error. I'm running on
> OS X 10.4, JDK 1.5, Ant 1.6.5.
>
> Error: 1) org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception:
> Could not start mirror server

This is intermittent. I've fixed it for future releases.

> Failure: 1) BSH1(org.apache.jmeter.functions.PackageTest)junit.framework.AssertionFailedError:
> BeanShell not present
> Failure: 2) testTimerBSH(org.apache.jmeter.timers.PackageTest)junit.framework.AssertionFailedError:
> expected:<60> but was:<0>

These are both because BeanShell is not present.

The test output needs to make this clearer.

> Website wise, the download binary and download source links should be
> changed to a single Download link pointing to:
>
> http://jakarta.apache.org/site/downloads/downloads_jmeter.cgi

OK, I'll fix that for later releases.

> The bugs page has a typo (Bugzilla + BugZilla).

OK.

> Hen
>
> On Nov 24, 2007 2:45 PM, sebb <se...@gmail.com> wrote:
> > I've created JMeter 2.3.1 RC1 in the directory:
> >
> > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> >
> > Site/Docs are here:
> > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> >
> > Tag:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> >
> > Keys are here:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > also
> > http://www.apache.org/dist/jakarta/jmeter/KEYS
> >
> > All feedback (and votes!) welcome.
> >
> > [ ]+1 - the release candidate is OK
> > [ ]-1 - there is a problem (please indicate what it is)
> >
> > The vote will remain open for at least 72 hours.
> >
> > If the vote passes, the intention is to create a formal 2.3.1 release
> > from the RC1 tag.
> >
> > Here's my:
> >
> > +1
> >
> > sebb AT apache DOT org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: general-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: general-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
For additional commands, e-mail: general-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by Henri Yandell <ba...@apache.org>.
+1, with various minor notes.

Signatures are good. MD5s are good.

The src tgz contains:

> jakarta-jmeter-2.3.1RC1/bin/jmeter
> jakarta-jmeter-2.3.1RC1/bin/jmeter-server
> jakarta-jmeter-2.3.1RC1/bin/jmeter.sh

but the src zip does not.

Otherwise the archives seem the same.

The build fails for just the source. I know the README says to unpack
both source and binary, but it would be good if the build.xml could
state that too. It's an odd thing to do.

=-=-=-=
Buildfile: build.xml

clean:
   [delete] DEPRECATED - Use of the implicit FileSet is deprecated.
Use a nested fileset element instead.

BUILD FAILED
/Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/build.xml:1349:
/Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/lib/ext not found.
=-=-=-=-=

The build succeeds once I follow the instructions correctly; and
JMeter started happily (though I didn't test actually using it).

"ant test" fails; there are two failures and one error. I'm running on
OS X 10.4, JDK 1.5, Ant 1.6.5.

Error: 1) org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception:
Could not start mirror server
Failure: 1) BSH1(org.apache.jmeter.functions.PackageTest)junit.framework.AssertionFailedError:
BeanShell not present
Failure: 2) testTimerBSH(org.apache.jmeter.timers.PackageTest)junit.framework.AssertionFailedError:
expected:<60> but was:<0>

Website wise, the download binary and download source links should be
changed to a single Download link pointing to:

http://jakarta.apache.org/site/downloads/downloads_jmeter.cgi

The bugs page has a typo (Bugzilla + BugZilla).

Hen

On Nov 24, 2007 2:45 PM, sebb <se...@gmail.com> wrote:
> I've created JMeter 2.3.1 RC1 in the directory:
>
> http://people.apache.org/~sebb/jmeter-2.3.1/dist
>
> Site/Docs are here:
> http://people.apache.org/~sebb/jmeter-2.3.1/docs
>
> Tag:
> http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
>
> Keys are here:
> http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> also
> http://www.apache.org/dist/jakarta/jmeter/KEYS
>
> All feedback (and votes!) welcome.
>
> [ ]+1 - the release candidate is OK
> [ ]-1 - there is a problem (please indicate what it is)
>
> The vote will remain open for at least 72 hours.
>
> If the vote passes, the intention is to create a formal 2.3.1 release
> from the RC1 tag.
>
> Here's my:
>
> +1
>
> sebb AT apache DOT org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: general-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
For additional commands, e-mail: general-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sun, 2007-11-25 at 16:12 +0000, sebb wrote:
> On 25/11/2007, sebb <se...@gmail.com> wrote:
> > On 25/11/2007, sebb <se...@gmail.com> wrote:
> > > On 25/11/2007, Oleg Kalnichevski <ol...@apache.org> wrote:
> > > > Sebastian,
> > > >
> > > > All looks good save one test case that is failing on me
> > > >
> > > >     [java] There was 1 error:
> > > >     [java] 1)
> > > > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception: Could not start mirror server
> > > >     [java]     at
> > > > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer$1.setUp(TestHTTPSamplersAgainstHttpMirrorServer.java:96)
> > > >     [java]     at junit.extensions.TestSetup
> > > > $1.protect(TestSetup.java:20)
> > > >     [java]     at junit.extensions.TestSetup.run(TestSetup.java:25)
> > > >     [java]     at
> > > > org.apache.jorphan.test.AllTests.main(AllTests.java:218)
> > > >
> > > >     [java] FAILURES!!!
> > > >     [java] Tests run: 1328,  Failures: 0,  Errors: 1
> > > >
> > > > Probably a more descriptive message would help. Is there anything I may
> > > > be doing wrong?
> > >
> > > Oops, I'd forgotten about that - it's an intermittent error.
> > >
> > > Seems to be a timing problem - the mirror server is run a few times,
> > > and sometimes it seems the invocations overlap, causing the problem.
> 
> True, but in different test suites.
> 
> >
> > Sorry, just rechecked and that's not true - it now only runs once.
> 
> True - each suite runs the server once.
> 
> > The error occurs if the server takes longer than expected to start up.
> 
> False.
> 
> > I will fix it to wait a bit longer (and improve the error message) for
> > future releases.
> 
> The previous replies were not totally correct...
> 
> The mirror server is used in two test suites. In each suite, the
> server is only started once. But sometimes the server from the
> previous suite has not had time to release all its resources, which is
> what causes the error that you saw.
> 
> I've updated the code in SVN to use different ports for the two test suites.
> The test code now also detects and reports errors better.
> 

The problem was not a release blocker, anyways.

+1 from me.

Oleg


> > Is it necessary to include the fix in the current release?
> > I'll happily add it.
> >
> > > If you try running the test again, hopefully it will run OK next time.
> > >
> > > You can skip the batch tests by running:
> > >
> > > ant _test
> > >
> > > Thanks for looking at the release.
> > >
> > > S
> > > > Oleg
> > > >
> > > >
> > > > On Sat, 2007-11-24 at 22:45 +0000, sebb wrote:
> > > > > I've created JMeter 2.3.1 RC1 in the directory:
> > > > >
> > > > > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> > > > >
> > > > > Site/Docs are here:
> > > > > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> > > > >
> > > > > Tag:
> > > > > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> > > > >
> > > > > Keys are here:
> > > > > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > > > > also
> > > > > http://www.apache.org/dist/jakarta/jmeter/KEYS
> > > > >
> > > > > All feedback (and votes!) welcome.
> > > > >
> > > > > [ ]+1 - the release candidate is OK
> > > > > [ ]-1 - there is a problem (please indicate what it is)
> > > > >
> > > > > The vote will remain open for at least 72 hours.
> > > > >
> > > > > If the vote passes, the intention is to create a formal 2.3.1 release
> > > > > from the RC1 tag.
> > > > >
> > > > > Here's my:
> > > > >
> > > > > +1
> > > > >
> > > > > sebb AT apache DOT org
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > > > > For additional commands, e-mail: general-help@jakarta.apache.org
> > > > >
> > > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> > > > For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> > > >
> > > >
> > >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 25/11/2007, sebb <se...@gmail.com> wrote:
> On 25/11/2007, sebb <se...@gmail.com> wrote:
> > On 25/11/2007, Oleg Kalnichevski <ol...@apache.org> wrote:
> > > Sebastian,
> > >
> > > All looks good save one test case that is failing on me
> > >
> > >     [java] There was 1 error:
> > >     [java] 1)
> > > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception: Could not start mirror server
> > >     [java]     at
> > > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer$1.setUp(TestHTTPSamplersAgainstHttpMirrorServer.java:96)
> > >     [java]     at junit.extensions.TestSetup
> > > $1.protect(TestSetup.java:20)
> > >     [java]     at junit.extensions.TestSetup.run(TestSetup.java:25)
> > >     [java]     at
> > > org.apache.jorphan.test.AllTests.main(AllTests.java:218)
> > >
> > >     [java] FAILURES!!!
> > >     [java] Tests run: 1328,  Failures: 0,  Errors: 1
> > >
> > > Probably a more descriptive message would help. Is there anything I may
> > > be doing wrong?
> >
> > Oops, I'd forgotten about that - it's an intermittent error.
> >
> > Seems to be a timing problem - the mirror server is run a few times,
> > and sometimes it seems the invocations overlap, causing the problem.

True, but in different test suites.

>
> Sorry, just rechecked and that's not true - it now only runs once.

True - each suite runs the server once.

> The error occurs if the server takes longer than expected to start up.

False.

> I will fix it to wait a bit longer (and improve the error message) for
> future releases.

The previous replies were not totally correct...

The mirror server is used in two test suites. In each suite, the
server is only started once. But sometimes the server from the
previous suite has not had time to release all its resources, which is
what causes the error that you saw.

I've updated the code in SVN to use different ports for the two test suites.
The test code now also detects and reports errors better.

> Is it necessary to include the fix in the current release?
> I'll happily add it.
>
> > If you try running the test again, hopefully it will run OK next time.
> >
> > You can skip the batch tests by running:
> >
> > ant _test
> >
> > Thanks for looking at the release.
> >
> > S
> > > Oleg
> > >
> > >
> > > On Sat, 2007-11-24 at 22:45 +0000, sebb wrote:
> > > > I've created JMeter 2.3.1 RC1 in the directory:
> > > >
> > > > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> > > >
> > > > Site/Docs are here:
> > > > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> > > >
> > > > Tag:
> > > > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> > > >
> > > > Keys are here:
> > > > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > > > also
> > > > http://www.apache.org/dist/jakarta/jmeter/KEYS
> > > >
> > > > All feedback (and votes!) welcome.
> > > >
> > > > [ ]+1 - the release candidate is OK
> > > > [ ]-1 - there is a problem (please indicate what it is)
> > > >
> > > > The vote will remain open for at least 72 hours.
> > > >
> > > > If the vote passes, the intention is to create a formal 2.3.1 release
> > > > from the RC1 tag.
> > > >
> > > > Here's my:
> > > >
> > > > +1
> > > >
> > > > sebb AT apache DOT org
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > > > For additional commands, e-mail: general-help@jakarta.apache.org
> > > >
> > > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> > >
> > >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 25/11/2007, sebb <se...@gmail.com> wrote:
> On 25/11/2007, Oleg Kalnichevski <ol...@apache.org> wrote:
> > Sebastian,
> >
> > All looks good save one test case that is failing on me
> >
> >     [java] There was 1 error:
> >     [java] 1)
> > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception: Could not start mirror server
> >     [java]     at
> > org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer$1.setUp(TestHTTPSamplersAgainstHttpMirrorServer.java:96)
> >     [java]     at junit.extensions.TestSetup
> > $1.protect(TestSetup.java:20)
> >     [java]     at junit.extensions.TestSetup.run(TestSetup.java:25)
> >     [java]     at
> > org.apache.jorphan.test.AllTests.main(AllTests.java:218)
> >
> >     [java] FAILURES!!!
> >     [java] Tests run: 1328,  Failures: 0,  Errors: 1
> >
> > Probably a more descriptive message would help. Is there anything I may
> > be doing wrong?
>
> Oops, I'd forgotten about that - it's an intermittent error.
>
> Seems to be a timing problem - the mirror server is run a few times,
> and sometimes it seems the invocations overlap, causing the problem.

Sorry, just rechecked and that's not true - it now only runs once.
The error occurs if the server takes longer than expected to start up.
I will fix it to wait a bit longer (and improve the error message) for
future releases.

Is it necessary to include the fix in the current release?
I'll happily add it.

> If you try running the test again, hopefully it will run OK next time.
>
> You can skip the batch tests by running:
>
> ant _test
>
> Thanks for looking at the release.
>
> S
> > Oleg
> >
> >
> > On Sat, 2007-11-24 at 22:45 +0000, sebb wrote:
> > > I've created JMeter 2.3.1 RC1 in the directory:
> > >
> > > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> > >
> > > Site/Docs are here:
> > > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> > >
> > > Tag:
> > > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> > >
> > > Keys are here:
> > > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > > also
> > > http://www.apache.org/dist/jakarta/jmeter/KEYS
> > >
> > > All feedback (and votes!) welcome.
> > >
> > > [ ]+1 - the release candidate is OK
> > > [ ]-1 - there is a problem (please indicate what it is)
> > >
> > > The vote will remain open for at least 72 hours.
> > >
> > > If the vote passes, the intention is to create a formal 2.3.1 release
> > > from the RC1 tag.
> > >
> > > Here's my:
> > >
> > > +1
> > >
> > > sebb AT apache DOT org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: general-help@jakarta.apache.org
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by sebb <se...@gmail.com>.
On 25/11/2007, Oleg Kalnichevski <ol...@apache.org> wrote:
> Sebastian,
>
> All looks good save one test case that is failing on me
>
>     [java] There was 1 error:
>     [java] 1)
> org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception: Could not start mirror server
>     [java]     at
> org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer$1.setUp(TestHTTPSamplersAgainstHttpMirrorServer.java:96)
>     [java]     at junit.extensions.TestSetup
> $1.protect(TestSetup.java:20)
>     [java]     at junit.extensions.TestSetup.run(TestSetup.java:25)
>     [java]     at
> org.apache.jorphan.test.AllTests.main(AllTests.java:218)
>
>     [java] FAILURES!!!
>     [java] Tests run: 1328,  Failures: 0,  Errors: 1
>
> Probably a more descriptive message would help. Is there anything I may
> be doing wrong?

Oops, I'd forgotten about that - it's an intermittent error.

Seems to be a timing problem - the mirror server is run a few times,
and sometimes it seems the invocations overlap, causing the problem.

If you try running the test again, hopefully it will run OK next time.

You can skip the batch tests by running:

ant _test

Thanks for looking at the release.

S
> Oleg
>
>
> On Sat, 2007-11-24 at 22:45 +0000, sebb wrote:
> > I've created JMeter 2.3.1 RC1 in the directory:
> >
> > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> >
> > Site/Docs are here:
> > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> >
> > Tag:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> >
> > Keys are here:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > also
> > http://www.apache.org/dist/jakarta/jmeter/KEYS
> >
> > All feedback (and votes!) welcome.
> >
> > [ ]+1 - the release candidate is OK
> > [ ]-1 - there is a problem (please indicate what it is)
> >
> > The vote will remain open for at least 72 hours.
> >
> > If the vote passes, the intention is to create a formal 2.3.1 release
> > from the RC1 tag.
> >
> > Here's my:
> >
> > +1
> >
> > sebb AT apache DOT org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: general-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


Re: [VOTE] JMeter 2.3.1RC1

Posted by Oleg Kalnichevski <ol...@apache.org>.
Sebastian,

All looks good save one test case that is failing on me

     [java] There was 1 error:
     [java] 1)
org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception: Could not start mirror server
     [java]     at
org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServer$1.setUp(TestHTTPSamplersAgainstHttpMirrorServer.java:96)
     [java]     at junit.extensions.TestSetup
$1.protect(TestSetup.java:20)
     [java]     at junit.extensions.TestSetup.run(TestSetup.java:25)
     [java]     at
org.apache.jorphan.test.AllTests.main(AllTests.java:218)

     [java] FAILURES!!!
     [java] Tests run: 1328,  Failures: 0,  Errors: 1

Probably a more descriptive message would help. Is there anything I may
be doing wrong?

Oleg


On Sat, 2007-11-24 at 22:45 +0000, sebb wrote:
> I've created JMeter 2.3.1 RC1 in the directory:
> 
> http://people.apache.org/~sebb/jmeter-2.3.1/dist
> 
> Site/Docs are here:
> http://people.apache.org/~sebb/jmeter-2.3.1/docs
> 
> Tag:
> http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> 
> Keys are here:
> http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> also
> http://www.apache.org/dist/jakarta/jmeter/KEYS
> 
> All feedback (and votes!) welcome.
> 
> [ ]+1 - the release candidate is OK
> [ ]-1 - there is a problem (please indicate what it is)
> 
> The vote will remain open for at least 72 hours.
> 
> If the vote passes, the intention is to create a formal 2.3.1 release
> from the RC1 tag.
> 
> Here's my:
> 
> +1
> 
> sebb AT apache DOT org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: general-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org