You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/31 06:23:58 UTC

[GitHub] [flink] leonardBang opened a new pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

leonardBang opened a new pull request #13283:
URL: https://github.com/apache/flink/pull/13283


   ## What is the purpose of the change
   
   * This pull request adding readme.md for TPC-DS tools to help user understand the test better.
   
   
   ## Brief change log
   
     - Add readme.md in `tpcds-tool`
     - Minor cleanup in `tpcds-tool/data_generator.sh `
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #13283:
URL: https://github.com/apache/flink/pull/13283#discussion_r485486141



##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -11,13 +11,28 @@ Scripts to download the TPC-DS data generator and generate test data, the suppor
 * generator_dir: directory to save TPC-DS data generator.
 * scale_factor: scale factor indicates raw data size in GB, we use the validation scale factor 1 (1G) by default.
 * data_dir: directory to save TPC-DS test data.
-* common_scripts_dir: directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  
+* common_scripts_dir: directory which contains some common scripts for Flink end to end tests, the retry scripts `retry_times_with_backoff_and_cleanup()` will be used when download the TPC-DS data generator from the Internet.
+
+The scripts is internally used in Flink end to end tests, give an example to specific how the scripts works:
+```
+$ cd /Users/demo/flink                                                                                   # go to the fFink project

Review comment:
       typo: `fFink`

##########
File path: flink-end-to-end-tests/flink-tpcds-test/README.md
##########
@@ -0,0 +1,12 @@
+# Flink [TPC-DS]( http://www.tpc.org/tpcds) test
+
+You can run the Flink TPC-DS test in your local environment as following commands:
+
+```
+$ cd /Users/demo/flink                                                                               # go to the Flink project   

Review comment:
       nit: use `<your_workspace_dir>` instead of `/Users/demo` ?

##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -11,13 +11,28 @@ Scripts to download the TPC-DS data generator and generate test data, the suppor
 * generator_dir: directory to save TPC-DS data generator.
 * scale_factor: scale factor indicates raw data size in GB, we use the validation scale factor 1 (1G) by default.
 * data_dir: directory to save TPC-DS test data.
-* common_scripts_dir: directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  
+* common_scripts_dir: directory which contains some common scripts for Flink end to end tests, the retry scripts `retry_times_with_backoff_and_cleanup()` will be used when download the TPC-DS data generator from the Internet.
+
+The scripts is internally used in Flink end to end tests, give an example to specific how the scripts works:
+```
+$ cd /Users/demo/flink                                                                                   # go to the fFink project
+$ mvn compile -DskipTests=true                                                                          # compile the Flink source code
+$ export FLINK_DIR=/Users/demo/flink/flink-dist/target/flink-${flink-version}-bin/flink-${flink-version}      # set Flink distribution directory, the ${flink-version} is the compiled Flink version
+$ export END_TO_END_DIR=/Users/demo/flink/flink-end-to-end-tests                                          # set end to end tests directory
+$ mkdir -p /Users/demo/dir_to_save_genarator
+$ mkdir -p /Users/demo/dir_to_save_data
+$ cd /Users/demo/flink/flink-end-to-end-tests/tpcds-tool
+$ sh data_generator.sh /Users/demo/dir_to_save_genarator 1 /Users/demo/dir_to_save_data /Users/demo/flink/flink-end-to-end-tests/test-scripts
+```
+The downloaded generator will be saved to `/Users/demo/dir_to_save_genarator`, the generated data will be saved to `Users/demo/dir_to_save_data`.

Review comment:
       typo: `Users/demo`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315) 
   * 4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389) 
   * 62f40cd28a36147d84a77b499e63b6224df8b038 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6426",
       "triggerID" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389) 
   * 62f40cd28a36147d84a77b499e63b6224df8b038 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6426) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683585889


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 (Mon Aug 31 06:26:45 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18759).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #13283:
URL: https://github.com/apache/flink/pull/13283#discussion_r484426654



##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -0,0 +1,28 @@
+# TPC-DS tool
+
+This directory contains the necessary scripts/files to run a TPC-DS test.
+
+## data_generator.sh scripts
+
+Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.

Review comment:
       data_generator.sh <generator_dir> <scale_factor> < data_dir> <retry_scripts_dir>
   
   <generator_dir>, the directory to save TPC-DS data generator.
   ....

##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -0,0 +1,28 @@
+# TPC-DS tool
+
+This directory contains the necessary scripts/files to run a TPC-DS test.
+
+## data_generator.sh scripts
+
+Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
+
+* parameter 1: generator_dir, the directory to save TPC-DS data generator.
+* parameter 2: scale_factor, the TPC-DS test scale factor, we use the validation scale factor 1 (1G) by default.

Review comment:
       Scale factor indicates raw data size in GB,  we use the validation scale factor 1 (1G) by default.

##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -0,0 +1,28 @@
+# TPC-DS tool
+
+This directory contains the necessary scripts/files to run a TPC-DS test.

Review comment:
       add an official link: http://www.tpc.org/tpcds ?

##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -0,0 +1,28 @@
+# TPC-DS tool
+
+This directory contains the necessary scripts/files to run a TPC-DS test.
+
+## data_generator.sh scripts
+
+Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
+
+* parameter 1: generator_dir, the directory to save TPC-DS data generator.
+* parameter 2: scale_factor, the TPC-DS test scale factor, we use the validation scale factor 1 (1G) by default.
+* parameter 3: data_dir, the directory to save TPC-DS test data.
+* parameter 4: retry_scripts_dir, the directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  
+    
+## query directory
+
+Directory that contains all TPC-DS queries (103 queries in total), the corresponding data scale factor is 1G, these queries comes from TPC-DS standard specification v2.11.0 [1].
+
+*Note:* The scale factor of queries should match with test data's scale factor.
+    
+## answer_set directory
+
+Directory that contains all answers for per query, the answer content of query may has different order according to the system's null order.
+
+* (1) Flink SQL keeps null first in ASC order, keeps null last in DESC order, we choose corresponding answer file when compare the answer.
+* (2) For query 8, 14a, 18, 70 and 77, the decimal precision of answer set is too low and unreasonable, we compare result with result from SQL server, they can strictly match.

Review comment:
       improve this line ?

##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -0,0 +1,28 @@
+# TPC-DS tool
+
+This directory contains the necessary scripts/files to run a TPC-DS test.
+
+## data_generator.sh scripts
+
+Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
+
+* parameter 1: generator_dir, the directory to save TPC-DS data generator.
+* parameter 2: scale_factor, the TPC-DS test scale factor, we use the validation scale factor 1 (1G) by default.
+* parameter 3: data_dir, the directory to save TPC-DS test data.
+* parameter 4: retry_scripts_dir, the directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  

Review comment:
       this is an optional argument ? btw, the name and the description do not match




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff1e832bb5c332e75ae0ce1033e873cba9aa936e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #13283:
URL: https://github.com/apache/flink/pull/13283#discussion_r484895757



##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -1,19 +1,21 @@
 # TPC-DS tool
 
-This directory contains the necessary scripts/files to run a TPC-DS test.
+This directory contains the necessary scripts/files to run a [TPC-DS]( http://www.tpc.org/tpcds ) benchmark.
 
 ## data_generator.sh scripts
 
-Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
-
-* parameter 1: generator_dir, the directory to save TPC-DS data generator.
-* parameter 2: scale_factor, the TPC-DS test scale factor, we use the validation scale factor 1 (1G) by default.
-* parameter 3: data_dir, the directory to save TPC-DS test data.
-* parameter 4: retry_scripts_dir, the directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  
+Scripts to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
+```
+ data_generator.sh <generatorDir> <scaleFactor> <outputDataDir> <commonScriptsDir>

Review comment:
       give some examples?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe merged pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #13283:
URL: https://github.com/apache/flink/pull/13283


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005) 
   * ff1e832bb5c332e75ae0ce1033e873cba9aa936e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     }, {
       "hash" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6426",
       "triggerID" : "62f40cd28a36147d84a77b499e63b6224df8b038",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 62f40cd28a36147d84a77b499e63b6224df8b038 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6426) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005) 
   * ff1e832bb5c332e75ae0ce1033e873cba9aa936e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683585889


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 62f40cd28a36147d84a77b499e63b6224df8b038 (Fri Feb 19 07:28:18 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-685278264


   cc @godfreyhe could you help review this pr?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff1e832bb5c332e75ae0ce1033e873cba9aa936e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300) 
   * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8637f1ba5ea426d9f20777bc03b6d15cd78f8d06 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389",
       "triggerID" : "4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315) 
   * 4c078749f1c8dbf8dccb6a4fbb909bdd35bb0900 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6389) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13283:
URL: https://github.com/apache/flink/pull/13283#issuecomment-683593514


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6005",
       "triggerID" : "8637f1ba5ea426d9f20777bc03b6d15cd78f8d06",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300",
       "triggerID" : "ff1e832bb5c332e75ae0ce1033e873cba9aa936e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315",
       "triggerID" : "abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ff1e832bb5c332e75ae0ce1033e873cba9aa936e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6300) 
   * abfff20f6cd4a23f96bdfefbd3a7b8fa8c8adc84 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6315) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on a change in pull request #13283: [FLINK-18759][tests] Add readme.md for TPC-DS tools

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13283:
URL: https://github.com/apache/flink/pull/13283#discussion_r484912329



##########
File path: flink-end-to-end-tests/flink-tpcds-test/tpcds-tool/README.md
##########
@@ -1,19 +1,21 @@
 # TPC-DS tool
 
-This directory contains the necessary scripts/files to run a TPC-DS test.
+This directory contains the necessary scripts/files to run a [TPC-DS]( http://www.tpc.org/tpcds ) benchmark.
 
 ## data_generator.sh scripts
 
-Scripts that to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
-
-* parameter 1: generator_dir, the directory to save TPC-DS data generator.
-* parameter 2: scale_factor, the TPC-DS test scale factor, we use the validation scale factor 1 (1G) by default.
-* parameter 3: data_dir, the directory to save TPC-DS test data.
-* parameter 4: retry_scripts_dir, the directory which contains some common scripts for end-to end tests, the retry scripts will be used when download the TPC-DS data generator.  
+Scripts to download the TPC-DS data generator and generate test data, the supported OS including GNU/Linux OS and Mac OS.
+```
+ data_generator.sh <generatorDir> <scaleFactor> <outputDataDir> <commonScriptsDir>

Review comment:
       `data_generator.sh` scripts is internally used by `test_tpcds.sh`, and it's only used by `test_tpcds.sh`.
   It's still difficult for users to run a TPC-DS bench mark without `test_tpcds.sh` even I give an example.
   So, I give an example of `test_tpcds.sh` and also post the use position in` test_tpcds.sh`, HDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org