You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/06/07 10:19:41 UTC
[PR] [SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations [spark]
zhengruifeng opened a new pull request, #46915:
URL: https://github.com/apache/spark/pull/46915
### What changes were proposed in this pull request?
Propagate cached schema in set operations
### Why are the changes needed?
to avoid extra RPC to get the schema of result data frame
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
added tests
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #46915: [SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations
URL: https://github.com/apache/spark/pull/46915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #46915:
URL: https://github.com/apache/spark/pull/46915#discussion_r1632101801
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -1131,24 +1131,33 @@ def observe(
def show(self, n: int = 20, truncate: Union[bool, int] = True, vertical: bool = False) -> None:
print(self._show_string(n, truncate, vertical))
+ def _merge_cached_schema(self, other: ParentDataFrame) -> Optional[StructType]:
+ # to avoid type coercion, only propagate the schema
+ # when the cached schemas are exactly the same
+ if self._cached_schema is not None and self._cached_schema == other._cached_schema:
+ return self.schema
+ return None
Review Comment:
you can just remove this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46915:
URL: https://github.com/apache/spark/pull/46915#issuecomment-2158780167
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org