You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/04/27 03:16:54 UTC

[GitHub] [incubator-heron] nicknezis commented on a diff in pull request #3819: Fix HealthManager

nicknezis commented on code in PR #3819:
URL: https://github.com/apache/incubator-heron/pull/3819#discussion_r859337667


##########
heron/healthmgr/src/java/org/apache/heron/healthmgr/HealthManager.java:
##########
@@ -153,7 +152,6 @@ public HealthManager(Config config, AbstractModule baseModule) {
   }
 
   public static void main(String[] args) throws Exception {
-    Slf4jUtils.installSLF4JBridge();

Review Comment:
   This is no longer needed?



##########
heron/tools/tracker/src/python/query_operators.py:
##########
@@ -20,13 +20,17 @@
 
 ''' query_operators.py '''
 import asyncio
+import logging
 import math
 
 from typing import Any, Dict, List, Optional, Union
 
+from heron.common.src.python.utils import log
 from heron.proto.tmanager_pb2 import TManagerLocation
 from heron.tools.tracker.src.python.metricstimeline import get_metrics_timeline
 
+Log = log.Log

Review Comment:
   Were these lines added for your debugging, or was this to correct a deficiency in the logging behavior? Does the `--verbose` flag on the Tracker process not work in this module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org