[jira] [Commented] (MNG-5863) default pom's release-profile should invoke source plugin with goal "jar-no-fork" instead of "jar"

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935012#comment-14935012 ] 

Michael Osipov commented on MNG-5863:
-------------------------------------

The release profile is deprecated anyway. I do not think that this is worth fixing, escpecially the side effects it migh cause.

> default pom's release-profile should invoke source plugin with goal "jar-no-fork" instead of "jar"
> --------------------------------------------------------------------------------------------------
>
>                 Key: MNG-5863
>                 URL: https://issues.apache.org/jira/browse/MNG-5863
>             Project: Maven
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 3.3.3
>            Reporter: Petr Kozelka
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> in maven-model-builder, the file pom-4.0.0.xml defines  "release-profile" which binds some executions to the lifecycle.
> One of them is source:jar - which forks the build. That can be a problem in some configurations, and the forking is probably not necessary.
> One situation where the forked build hurts is this:
> - I have checkstyle:check attached to phase "validate"
> - some of my modules generate code, obviously not compliant to the checkstyle
> The problem is that, inside forked build, the checkstyle:check is called again, but now it checks also the generated code (because target/ is no longer empty). And of course fails.
> Even worse: during normal development iterations, everything is fine. But when I have to issue a release (usually under some pressure), I hit this problem.
> Fortunately, there _is_ a workaround: override the execution "attach-sources" and assign it to a non-existing phase, and define execution with different id for that.
> But it is too ugly and I believe that the simple fix would solve it - for the meantime before the whole profile is removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)