[GitHub] [iceberg] jun-he commented on a change in pull request #2454: Fix describing v1 table with void transform partitions.

[GitBox <gi...@apache.org>]

jun-he commented on a change in pull request #2454:
URL: https://github.com/apache/iceberg/pull/2454#discussion_r628822284



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -292,6 +292,12 @@ public Transform hour(String sourceName, int sourceId) {
             return Expressions.hours(sourceName);
           }
 
+          @Override
+          public Transform alwaysNull(int fieldId, String sourceName, int sourceId) {
+            // do nothing for alwaysNull, it doesn't need to be converted to a transform
+            return null;

Review comment:
       👌   Updated the PR and `Spark3Util` returns `null` to avoid create dummy objects.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org