You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by sanjaydasgupta <gi...@git.apache.org> on 2018/06/01 13:28:54 UTC

[GitHub] zeppelin pull request #2998: [ZEPPELIN-3522] String "defaultValue" instead o...

GitHub user sanjaydasgupta opened a pull request:

    https://github.com/apache/zeppelin/pull/2998

    [ZEPPELIN-3522] String "defaultValue" instead of boolean in some "interpreter-settings.json" files

    ### What is this PR for?
    The _interpreter-settings.json_ file for each interpreter has details of each configurable parameter for that interpreter. Each parameter also has a _defaultValue_ setting. For boolean-typed parameters the _defaultValue_ must be set to _true_ or _false_.
    
    But in some _interpreter-settings.json_ files, the _defaultValue_ has been set to the string values _"true"_ or _"false"_ (the quote marks are included in the value provided). 
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3522
    
    ### How should this be tested?
    CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaydasgupta/zeppelin zepp-3522-string-default-value

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2998
    
----
commit 9bdb0f35bf1967985e607afcc6ba06b955c587c7
Author: Sanjay Dasgupta <sa...@...>
Date:   2018-06-01T13:21:46Z

    zepp-3522-string-default-value: Initial updates

----


---

[GitHub] zeppelin issue #2998: [ZEPPELIN-3522] String "defaultValue" instead of boole...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2998
  
    @sanjaydasgupta  Travis is broken recently, need to wait for travis back to verify this PR 


---

[GitHub] zeppelin issue #2998: [ZEPPELIN-3522] String "defaultValue" instead of boole...

Posted by sanjaydasgupta <gi...@git.apache.org>.

Github user sanjaydasgupta commented on the issue:

    https://github.com/apache/zeppelin/pull/2998
  
    I had to recycle my fork, and had forgotten to link up Travis again.
    It's been done now. The errors appear unrelated to the changes in this PR.
    
    Thanks.


---

[GitHub] zeppelin pull request #2998: [ZEPPELIN-3522] String "defaultValue" instead o...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2998


---