You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/12/08 00:26:10 UTC
[PR] Support array literal functions [pinot]
xiangfu0 opened a new pull request, #12118:
URL: https://github.com/apache/pinot/pull/12118
Support array literal in thrift and ObjectSerde.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1422823809
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
Can you add more context on the code path requiring ser/de of these arrays? Based on my understanding this class is only used for ser/de the intermediate result of aggregation, so trying to understand why these changes are needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431970432
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java:
##########
@@ -66,6 +66,12 @@ public static Object convert(Object value, ColumnDataType storedType) {
if (value instanceof FloatArrayList) {
// For ArrayAggregationFunction
return ((FloatArrayList) value).elements();
+ } else if (value instanceof double[]) {
Review Comment:
Yes, `[0.1, 0.2, 0.3]` is parsed as `FLOAT_ARRAY` but internal representation is a `double[]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1427418306
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
This is also used by `BaseDataTableBuilder.setColumn(...)` which is used by all the agg/groupby/selection queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431972919
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java:
##########
@@ -56,6 +56,10 @@ public void init(List<TransformFunction> arguments, Map<String, ColumnContext> c
TransformFunction castFormatTransformFunction = arguments.get(1);
if (castFormatTransformFunction instanceof LiteralTransformFunction) {
String targetType = ((LiteralTransformFunction) castFormatTransformFunction).getStringLiteral().toUpperCase();
+ if ("OBJECT".equals(targetType)) {
Review Comment:
This happens when scalar function is not explicitly registered for the return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1428438510
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
We do have `BaseDataTableBuilder.setColumn()` for array types, and it should not go over the general handling of `Object`. Can you double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431978111
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java:
##########
@@ -171,13 +180,70 @@ private static RexNode evaluateLiteralOnlyFunction(RexCall rexCall, RexBuilder r
"Caught exception while converting result value: " + resultValue + " to type: " + rexNodeType, e);
}
try {
+ if (rexNodeType instanceof ArraySqlType) {
+ List<Object> resultValues = new ArrayList<>();
+ assert resultValue != null;
Review Comment:
moved the null check to above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1430765003
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
You are right, int[], long[], float[], double[] are already implemented. Just need to implement `StringArray`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431875567
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -1512,6 +1517,30 @@ private void computeResultsForLiteral(Literal literal, List<String> columnNames,
columnTypes.add(DataSchema.ColumnDataType.UNKNOWN);
row.add(null);
break;
+ case BIG_DECIMAL_VALUE:
Review Comment:
(nit) Move this after `DOUBLE_VALUE`
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -163,6 +166,37 @@ public static Expression getLiteralExpression(boolean value) {
return expression;
}
+ public static Expression getLiteralExpression(int[] value) {
Review Comment:
(nit) Move them after the single value methods
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java:
##########
@@ -56,6 +56,10 @@ public void init(List<TransformFunction> arguments, Map<String, ColumnContext> c
TransformFunction castFormatTransformFunction = arguments.get(1);
if (castFormatTransformFunction instanceof LiteralTransformFunction) {
String targetType = ((LiteralTransformFunction) castFormatTransformFunction).getStringLiteral().toUpperCase();
+ if ("OBJECT".equals(targetType)) {
Review Comment:
Hmm, what does `CAST to OBJECT` mean?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java:
##########
@@ -66,6 +66,12 @@ public static Object convert(Object value, ColumnDataType storedType) {
if (value instanceof FloatArrayList) {
// For ArrayAggregationFunction
return ((FloatArrayList) value).elements();
+ } else if (value instanceof double[]) {
Review Comment:
Why do we need this special handling?
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotEvaluateLiteralRule.java:
##########
@@ -171,13 +180,70 @@ private static RexNode evaluateLiteralOnlyFunction(RexCall rexCall, RexBuilder r
"Caught exception while converting result value: " + resultValue + " to type: " + rexNodeType, e);
}
try {
+ if (rexNodeType instanceof ArraySqlType) {
+ List<Object> resultValues = new ArrayList<>();
+ assert resultValue != null;
Review Comment:
Why?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -1512,6 +1517,30 @@ private void computeResultsForLiteral(Literal literal, List<String> columnNames,
columnTypes.add(DataSchema.ColumnDataType.UNKNOWN);
row.add(null);
break;
+ case BIG_DECIMAL_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.BIG_DECIMAL);
+ row.add(BigDecimalUtils.deserialize(literal.getBigDecimalValue()));
+ break;
+ case INT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.INT_ARRAY);
+ row.add(literal.getIntArrayValue());
+ break;
+ case LONG_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.LONG_ARRAY);
+ row.add(literal.getLongArrayValue());
+ break;
+ case FLOAT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.FLOAT_ARRAY);
+ row.add(literal.getFloatArrayValue().stream().map(Float::intBitsToFloat).collect(Collectors.toList()));
+ break;
+ case DOUBLE_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.DOUBLE_ARRAY);
+ row.add(literal.getDoubleArrayValue());
+ break;
+ case STRING_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.STRING_ARRAY);
+ row.add(literal.getStringArrayValue());
+ break;
default:
Review Comment:
Not introduced in this PR, but should we throw exception here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1430849697
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
`String[]` is also supported natively within `DataTableBuilder`. Check the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431984479
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/TypeUtils.java:
##########
@@ -66,6 +66,12 @@ public static Object convert(Object value, ColumnDataType storedType) {
if (value instanceof FloatArrayList) {
// For ArrayAggregationFunction
return ((FloatArrayList) value).elements();
+ } else if (value instanceof double[]) {
Review Comment:
Add some comment explaining this
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -1512,8 +1521,28 @@ private void computeResultsForLiteral(Literal literal, List<String> columnNames,
columnTypes.add(DataSchema.ColumnDataType.UNKNOWN);
row.add(null);
break;
- default:
+ case INT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.INT_ARRAY);
+ row.add(literal.getIntArrayValue());
+ break;
+ case LONG_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.LONG_ARRAY);
+ row.add(literal.getLongArrayValue());
break;
+ case FLOAT_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.FLOAT_ARRAY);
+ row.add(literal.getFloatArrayValue().stream().map(Float::intBitsToFloat).collect(Collectors.toList()));
+ break;
+ case DOUBLE_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.DOUBLE_ARRAY);
+ row.add(literal.getDoubleArrayValue());
+ break;
+ case STRING_ARRAY_VALUE:
+ columnTypes.add(DataSchema.ColumnDataType.STRING_ARRAY);
+ row.add(literal.getStringArrayValue());
+ break;
+ default:
+ throw new IllegalStateException("No able to compute results for literal - " + literal);
Review Comment:
```suggestion
throw new IllegalStateException("Unsupported literal: " + literal);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1431967330
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
The issue is we didn't register the return type for v2 engine for `split` function. So it was `OBJECT` in desired return type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12118:
URL: https://github.com/apache/pinot/pull/12118#issuecomment-1863566998
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `42 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`fd45c1b`)](https://app.codecov.io/gh/apache/pinot/commit/fd45c1bbd273dab29aebe4576cf0475d219e2fca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.47% compared to head [(`869af38`)](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.47%.
> Report is 5 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pache/pinot/common/utils/request/RequestUtils.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | 0.00% | [21 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ator/transform/function/CastTransformFunction.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../pinot/query/runtime/operator/utils/TypeUtils.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci91dGlscy9UeXBlVXRpbHMuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/pinot/common/function/TransformFunctionType.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vVHJhbnNmb3JtRnVuY3Rpb25UeXBlLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12118 +/- ##
=============================================
- Coverage 61.47% 46.47% -15.01%
+ Complexity 1147 945 -202
=============================================
Files 2407 1809 -598
Lines 130912 95207 -35705
Branches 20225 15353 -4872
=============================================
- Hits 80483 44246 -36237
- Misses 44542 47809 +3267
+ Partials 5887 3152 -2735
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.47% <4.54%> (-15.01%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <4.54%> (+11.67%)` | :arrow_up: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <4.54%> (-15.02%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.47% <4.54%> (-15.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.47% <4.54%> (-15.01%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.47% <4.54%> (-0.04%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12118:
URL: https://github.com/apache/pinot/pull/12118#issuecomment-1846338479
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `115 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`45d9a4b`)](https://app.codecov.io/gh/apache/pinot/commit/45d9a4b8cf46e902314b1ed237742d42206f2edb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.61% compared to head [(`b025e44`)](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.45%.
> Report is 4 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...org/apache/pinot/core/common/ObjectSerDeUtils.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vT2JqZWN0U2VyRGVVdGlscy5qYXZh) | 15.68% | [81 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/pinot/common/utils/request/RequestUtils.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | 0.00% | [21 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ator/transform/function/CastTransformFunction.java](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | 0.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12118 +/- ##
=============================================
- Coverage 61.61% 46.45% -15.16%
+ Complexity 1153 944 -209
=============================================
Files 2406 1808 -598
Lines 130810 95256 -35554
Branches 20204 15367 -4837
=============================================
- Hits 80595 44250 -36345
- Misses 44340 47840 +3500
+ Partials 5875 3166 -2709
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <12.21%> (-15.05%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <12.21%> (-15.14%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <12.21%> (-15.16%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <12.21%> (-15.16%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.45% <12.21%> (-0.26%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #12118:
URL: https://github.com/apache/pinot/pull/12118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Support array literal functions [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #12118:
URL: https://github.com/apache/pinot/pull/12118#discussion_r1427470866
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -156,7 +156,12 @@ public enum ObjectType {
FloatArrayList(44),
StringArrayList(45),
UltraLogLog(46),
- ThetaSketchAccumulator(47);
+ ThetaSketchAccumulator(47),
+ IntArray(48),
Review Comment:
Array Literal is pushed down to worker in v2 engine, so need to wire it all the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org