[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6374: Prepare for object_store 0.6

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1196852806


##########
datafusion-cli/src/object_storage.rs:
##########
@@ -36,10 +42,29 @@ pub fn get_s3_object_store_builder(
         builder = builder
             .with_access_key_id(access_key_id)
             .with_secret_access_key(secret_access_key);
-    }
 
-    if let Some(session_token) = cmd.options.get("session_token") {
-        builder = builder.with_token(session_token);
+        if let Some(session_token) = cmd.options.get("session_token") {
+            builder = builder.with_token(session_token);
+        }
+    } else {
+        let config = aws_config::from_env().load().await;

Review Comment:
   Unlike before, this now ensures that users get the full coherent configuration experience that they might expect from a CLI tool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org