You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/20 10:56:06 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5307: Filter disk / service offerings by domain at DB level

davidjumani commented on a change in pull request #5307:
URL: https://github.com/apache/cloudstack/pull/5307#discussion_r692856802



##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -346,14 +345,17 @@
     private DiskOfferingJoinDao _diskOfferingJoinDao;
 
     @Inject
-    private DiskOfferingDetailsDao diskOfferingDetailsDao;
+    private DiskOfferingDetailsDao _diskOfferingDetailsDao;

Review comment:
       Consistency in the file, unless you'd like me to rename all the class variables ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org