You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/12/25 20:56:46 UTC
[jira] Created: (HADOOP-4948) ant test-patch does not work
ant test-patch does not work
----------------------------
Key: HADOOP-4948
URL: https://issues.apache.org/jira/browse/HADOOP-4948
Project: Hadoop Core
Issue Type: Bug
Components: scripts
Affects Versions: 0.21.0
Reporter: Tsz Wo (Nicholas), SZE
ant test-patch is reporting "Trunk compilation is broken?" for any patch.
{noformat}
...
[exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
[exec] Trunk compilation is broken?
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4948) ant test-patch does not work
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659558#action_12659558 ]
Hudson commented on HADOOP-4948:
--------------------------------
Integrated in Hadoop-trunk #703 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/703/])
. Add parameters java5.home and forrest.home to the ant commands in test-patch.sh. (Giridharan Kesavan via szetszwo)
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.20.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4948) ant test-patch does not work
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-4948:
---------------------------------------
Attachment: HADOOP-4948.patch
I'm able to reproduce the failure.
After the the fix for HADOOP-4920, the package target depends on docs target, with inturn depends on forrest.home and java5.home
When we call the test-patch target through ant though we pass the forrest.home & java5.home the test-patch.sh script doesn't seem to pass the 2 env variables when calling the tar and findbugs target, which is causing the ant test-pach failure.
This patch *HADOOP-4849.patch cannot be tested, as it modifies the test-patch.sh itself.*
this patch is tested manually , here is the test-patch result:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Thanks,
Giri
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.21.0
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4948) ant test-patch does not work
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659528#action_12659528 ]
Amareshwari Sriramadasu commented on HADOOP-4948:
-------------------------------------------------
I still see the issue on the trunk, even with empty patch.
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.20.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-4948) ant test-patch does not
work
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659456#action_12659456 ]
gkesavan edited comment on HADOOP-4948 at 12/28/08 11:17 AM:
-----------------------------------------------------------------------
I'm able to reproduce the failure.
After the the fix for HADOOP-4920, the package target depends on docs target, with inturn depends on forrest.home and java5.home
When we call the test-patch target through ant though, we pass the forrest.home & java5.home the test-patch.sh
script doesn't seem to pass the 2 env variables while calling the tar and findbugs target, which is causing the ant test-pach failure.
This patch *HADOOP-4849.patch cannot be tested, as it modifies the test-patch.sh itself.*
This patch is tested manually , here is the test-patch result:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Thanks,
Giri
was (Author: gkesavan):
I'm able to reproduce the failure.
After the the fix for HADOOP-4920, the package target depends on docs target, with inturn depends on forrest.home and java5.home
When we call the test-patch target through ant though we pass the forrest.home & java5.home the test-patch.sh script doesn't seem to pass the 2 env variables when calling the tar and findbugs target, which is causing the ant test-pach failure.
This patch *HADOOP-4849.patch cannot be tested, as it modifies the test-patch.sh itself.*
this patch is tested manually , here is the test-patch result:
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
Thanks,
Giri
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.21.0
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-4948) ant test-patch does not work
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-4948.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
I just committed this to trunk. Thanks, Giri!
If HADOOP-4920 is committed to 0.20, this one also should be.
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.20.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-4948) ant test-patch does not
work
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659438#action_12659438 ]
gkesavan edited comment on HADOOP-4948 at 12/28/08 7:30 AM:
----------------------------------------------------------------------
I'm trying to reproduce, could you please paste the info from the log file */home/tsz/tmp/trunkJavacWarnings.txt*
Thanks,
Giri
was (Author: gkesavan):
I'm trying to reproduce, could you please paste here the reason for the failure from the log file */home/tsz/tmp/trunkJavacWarnings.txt*
Thanks,
Giri
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.21.0
> Reporter: Tsz Wo (Nicholas), SZE
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4948) ant test-patch does not work
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4948:
-------------------------------------------
Affects Version/s: (was: 0.21.0)
0.20.0
Assignee: Giridharan Kesavan
Hadoop Flags: [Reviewed]
+1 patch looks good.
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.20.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4948) ant test-patch does not work
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659531#action_12659531 ]
Amareshwari Sriramadasu commented on HADOOP-4948:
-------------------------------------------------
Looks like problem was with the environment variables on my machine. Thanks Giri for helping it out.
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.20.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-4948.patch
>
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4948) ant test-patch does not work
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659438#action_12659438 ]
Giridharan Kesavan commented on HADOOP-4948:
--------------------------------------------
I'm trying to reproduce, could you please paste here the reason for the failure from the log file */home/tsz/tmp/trunkJavacWarnings.txt*
Thanks,
Giri
> ant test-patch does not work
> ----------------------------
>
> Key: HADOOP-4948
> URL: https://issues.apache.org/jira/browse/HADOOP-4948
> Project: Hadoop Core
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.21.0
> Reporter: Tsz Wo (Nicholas), SZE
>
> ant test-patch is reporting "Trunk compilation is broken?" for any patch.
> {noformat}
> ...
> [exec] /home/tsz/apache-ant-1.7.1/bin/ant -Dversion=PATCH-a.patch -Djavac.args=-Xlint -Xmaxwarns 1000 -DHadoopPatchProcess= clean tar > /home/tsz/tmp/trunkJavacWarnings.txt 2>&1
> [exec] Trunk compilation is broken?
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.