[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #9596: [IOTDB-5773] fix set space quota problem

["xingtanzjr (via GitHub)" <gi...@apache.org>]

xingtanzjr commented on code in PR #9596:
URL: https://github.com/apache/iotdb/pull/9596#discussion_r1164930093


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/config/sys/quota/ShowSpaceQuotaTask.java:
##########
@@ -75,12 +75,13 @@ public static void buildTSBlock(TSpaceQuotaResp resp, SettableFuture<ConfigTaskR
                   Binary.valueOf(
                       spaceQuotaEntry.getValue().getDiskSize() == 0
                           ? IoTDBConstant.QUOTA_UNLIMITED
-                          : spaceQuotaEntry.getValue().getDiskSize() + "M"));
+                          : spaceQuotaEntry.getValue().getDiskSize() / 1024.0 + "G"));

Review Comment:
   Suggest to use static const rather than hard code string value here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org