[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7182: Remove obsolete cdn_ HttpTransact vars

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on a change in pull request #7182:
URL: https://github.com/apache/trafficserver/pull/7182#discussion_r487585485



##########
File path: proxy/http/HttpTransact.cc
##########
@@ -757,15 +757,15 @@ how_to_open_connection(HttpTransact::State *s)
     break;
   }
 
-  s->cdn_saved_next_action = HttpTransact::SM_ACTION_ORIGIN_SERVER_OPEN;
+  HttpTransact::StateMachineAction_t connect_next_action = HttpTransact::SM_ACTION_ORIGIN_SERVER_OPEN;
 
   // Setting up a direct CONNECT tunnel enters OriginServerRawOpen. We always do that if we
   // are not forwarding CONNECT and are not going to a parent proxy.
   if (s->method == HTTP_WKSIDX_CONNECT) {
     if (s->txn_conf->forward_connect_method == 1 || s->parent_result.result == PARENT_SPECIFIED) {
-      s->cdn_saved_next_action = HttpTransact::SM_ACTION_ORIGIN_SERVER_OPEN;
+      connect_next_action = HttpTransact::SM_ACTION_ORIGIN_SERVER_OPEN;

Review comment:
       Isn't it already that value? Shouldn't this check only for having to change to `SM_ACTION_ORIGIN_SERVER_RAW_OPEN`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org