[GitHub] [commons-numbers] aherbert commented on pull request #130: [NUMBERS]: implemented method that determines if 2 integers are relat…

["aherbert (via GitHub)" <gi...@apache.org>]

aherbert commented on PR #130:
URL: https://github.com/apache/commons-numbers/pull/130#issuecomment-1634514221

   These are simply pass through methods for `ArithmeticUtils.gcd` where gcd == 1.
   
   The new methods do not include a link to `gcd` and also lose all the javadoc on the special cases for that method, including exception cases. Adding these methods brings in the dependency on the core module and bloats the primes module. I believe it better to add javadoc to the Primes class to sign post users to ArithmeticUtils, e.g. in the class javadoc:
   
   ```
    * <p>Additional methods for integer arithmetic can be found in the Numbers core module in
    * {@code o.a.c.numbers.core.ArithmeticUtils}. This includes a method to obtain the
    * greatest common divisor (GCD) of two integers which can be used to determine if two numbers
    * are relatively prime.
   ```
   
   Thus users can bring in that dependency if they require.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org