[GitHub] [hudi] nsivabalan commented on a diff in pull request #6830: [HUDI-2118] Skip checking corrupt log blocks for transactional write file systems

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #6830:
URL: https://github.com/apache/hudi/pull/6830#discussion_r1086040536


##########
hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java:
##########
@@ -97,4 +104,12 @@ public static boolean isAppendSupported(String scheme) {
     }
     return Arrays.stream(StorageSchemes.values()).anyMatch(s -> s.supportsAppend() && s.scheme.equals(scheme));
   }
+
+  public static boolean isWriteTransactional(String scheme) {
+    if (!isSchemeSupported(scheme)) {
+      throw new IllegalArgumentException("Unsupported scheme :" + scheme);
+    }
+
+    return Arrays.stream(StorageSchemes.values()).anyMatch(s -> s.isWriteTransactional() && s.scheme.equals(scheme));

Review Comment:
   ENUM could be named differently than "scheme". and hence we are doing it this way. if its a single field ENUM, we could do that you are suggesting. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org