You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/08/21 22:37:10 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin-254] getRegisteredInter...
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/240
[Zeppelin-254] getRegisteredInterpreterList add NULL to the list
InterpreterFactory register all interpreters by looping through the config interpreter class list and looking for them on the folder list.
Only interpreter which were found are registered.
BUT in the getRegisteredInterpreterList we are adding an item to the list for every class in the config list and null whenever the class is not registered.
This PR fixes that by testing the return value of findRegisteredInterpreterByClassName before adding it to the list.
This PR also include a Unit test for this case.
Ready for review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eranwitkon/incubator-zeppelin 254
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 4e1e4dcb0a2f2c4d6c1b150b2ab99a7444a166d0
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-18T07:27:44Z
Change getAvailableInterpreters test to pass when list of interpreters in the build does not match the list of interpreters in the default config
commit 31e0edcf742037cf21342fb3506518a9a3a28cdb
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-18T07:40:15Z
Add argument check for option and properties to protect from NPE.
Add equivalent test for this case
commit 1502cf965f0240e3606e33e4f4b080e06759df70
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-18T07:42:28Z
fix getAvailableInterpreters test for cases were the installed interpreters do not match the list of interpreters in the config.
commit b0b2488382224997ef2e69478a9eab95542c1644
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-19T05:56:37Z
Revert "fix getAvailableInterpreters test for cases were the installed interpreters do not match the list of interpreters in the config."
This reverts commit 1502cf965f0240e3606e33e4f4b080e06759df70.
commit fc8680d665731896815e46782ed37e1748af16e1
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-19T06:04:01Z
Revert "Add argument check for option and properties to protect from NPE."
This reverts commit 31e0edcf742037cf21342fb3506518a9a3a28cdb.
commit 39ac2c1c66d919e7b686e60104a3bf01ca021abd
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-19T07:51:44Z
Add argument check for option and properties to protect from NPE
commit c7cc45cd25d4c6db0d871a286b5946f974a3726a
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-20T12:57:43Z
Merge branch 'master' of https://github.com/eranwitkon/incubator-zeppelin
commit e40d9fe2adc5fc1191097ab3fb7be909dce8b8d7
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-20T13:03:41Z
Fix CI problem - add name to TODO
commit 776a3d1404cd75f2429e8bbbda6e0822cb90f585
Author: eranwitkon <go...@gmail.com>
Date: 2015-08-21T20:20:36Z
Fix getRegisteredInterpreterList,
avoid adding null to the list when class name from config is not registered
(only interpreters available on the disk (has interpreter folder) are registered.
findRegisteredInterpreterByClassName return null when class name not found.
(cherry picked from commit 6724e54)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-254] getRegisteredInter...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---