You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/03/20 21:36:38 UTC
cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
sebb 2004/03/20 12:36:38
Modified: src/monitor/components/org/apache/jmeter/visualizers
MonitorAccumModel.java
src/monitor/model/org/apache/jmeter/monitor/parser
ParserImpl.java MonitorHandler.java
src/monitor/components/org/apache/jmeter/monitor/util
Stats.java
Log:
Fix some Javadoc errors; comment out unused variables
Revision Changes Path
1.6 +5 -5 jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java
Index: MonitorAccumModel.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- MonitorAccumModel.java 16 Mar 2004 13:56:34 -0000 1.5
+++ MonitorAccumModel.java 20 Mar 2004 20:36:37 -0000 1.6
@@ -36,7 +36,7 @@
{
private HashMap MAP;
- private MonitorModel CURRENT;
+ //private MonitorModel CURRENT;
private List listeners;
/**
* By default, we set the default to 800
@@ -67,7 +67,7 @@
* @param model
*/
public void addSample(MonitorModel model){
- this.CURRENT = model;
+ //this.CURRENT = model;
if (MAP.containsKey(model.getURL())){
List newlist = updateArray(model,(List)MAP.get(model.getURL()));
MAP.put(model.getURL(),newlist);
@@ -134,7 +134,7 @@
if (sample instanceof HTTPSampleResult){
surl = ((HTTPSampleResult)sample).getURL();
}
- String rescontent = new String(sample.getResponseData());
+ //String rescontent = new String(sample.getResponseData());
if (sample.getResponseCode().equals("200") &&
((HTTPSampleResult)sample).isMonitor()){
ObjectFactory of = ObjectFactory.getInstance();
@@ -176,7 +176,7 @@
* with the given URL. This is used when the server
* fails to respond fully, or is dead.
* @param url
- * @return
+ * @return new MonitorModel
*/
public MonitorModel createNewMonitorModel(URL url){
MonitorStats stat = new MonitorStats(Stats.DEAD,
1.4 +4 -4 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
Index: ParserImpl.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ParserImpl.java 16 Mar 2004 03:28:49 -0000 1.3
+++ ParserImpl.java 20 Mar 2004 20:36:38 -0000 1.4
@@ -60,7 +60,7 @@
/**
* parse byte array and return Status object
- * @param byte[]
+ * @param bytes
* @return Status
*/
public Status parseBytes(byte[] bytes)
@@ -82,7 +82,7 @@
}
/**
- * @param String data
+ * @param content
* @return Status
*/
public Status parseString(String content)
@@ -91,7 +91,7 @@
}
/**
- * @param SampleResult result
+ * @param result
* @return Status
*/
public Status parseSampleResult(SampleResult result)
1.5 +17 -14 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java
Index: MonitorHandler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MonitorHandler.java 16 Mar 2004 03:28:49 -0000 1.4
+++ MonitorHandler.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -16,7 +16,7 @@
*/
package org.apache.jmeter.monitor.parser;
-import java.util.List;
+//import java.util.List;
import java.util.Stack;
import org.xml.sax.Attributes;
@@ -37,8 +37,8 @@
public class MonitorHandler extends DefaultHandler
{
- private boolean startDoc = false;
- private boolean endDoc = false;
+ //private boolean startDoc = false;
+ //private boolean endDoc = false;
private Stack stacktree = new Stack();
private ObjectFactory factory = null;
@@ -50,7 +50,7 @@
private RequestInfo requestinfo = null;
private Worker worker = null;
private Workers workers = null;
- private List workerslist = null;
+ //private List workerslist = null;
/**
*
@@ -71,14 +71,14 @@
public void startDocument ()
throws SAXException
{
- this.startDoc = true;
+ //this.startDoc = true;
}
public void endDocument ()
throws SAXException
{
- this.startDoc = false;
- this.endDoc = true;
+ //this.startDoc = false;
+ //this.endDoc = true;
}
/**
@@ -89,7 +89,9 @@
* each element (such as allocating a new tree node or writing
* output to a file).</p>
*
- * @param name The element type name.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName
* @param attributes The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
@@ -256,8 +258,9 @@
* each element (such as finalising a tree node or writing
* output to a file).</p>
*
- * @param name The element type name.
- * @param attributes The specified or defaulted attributes.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
* @see org.xml.sax.ContentHandler#endElement
@@ -327,7 +330,7 @@
* Convienance method for parsing long. If the string
* was not a number, the method returns zero.
* @param data
- * @return
+ * @return the value as a long
*/
public long parseLong(String data){
long val = 0;
@@ -344,7 +347,7 @@
/**
* Convienance method for parsing integers.
* @param data
- * @return
+ * @return the value as an integer
*/
public int parseInt(String data){
int val = 0;
@@ -360,7 +363,7 @@
/**
* method returns the status object.
- * @return
+ * @return the status
*/
public Status getContents(){
return this.status;
1.5 +3 -3 jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java
Index: Stats.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Stats.java 16 Mar 2004 03:49:53 -0000 1.4
+++ Stats.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -90,14 +90,14 @@
* <li> none of the above is dead
* </ol>
* @param stat
- * @return
+ * @return integer representing the status
*/
public static int calculateStatus(Status stat){
if (stat != null){
Connector cntr = (Connector)stat.getConnector().get(0);
int max = cntr.getThreadInfo().getMaxThreads();
int current = cntr.getThreadInfo().getCurrentThreadsBusy();
- int spare = cntr.getThreadInfo().getMaxSpareThreads();
+ //int spare = cntr.getThreadInfo().getMaxSpareThreads();
double per = (double)current/(double)max;
if (per > WARNING_PER){
return WARNING;
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
Posted by peter lin <jm...@yahoo.com>.
--- sebb@apache.org wrote:
> ----- Original Message -----
> From: "peter lin" <jm...@yahoo.com>
> To: "JMeter Developers List"
> <jm...@jakarta.apache.org>
> Sent: Sunday, March 21, 2004 4:41 PM
> Subject: Re: cvs commit:
>
jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util
> Stats.java
>
>
> >
> > oops on my part. I forgot that when I add a new
> httpsampler to the test plan, it defaults to
> "isMonitor".
I need to dig and test a bit further. if the preceding
thread group has a HTTPSampler that has "isMonitor"
checked, adding a new sampler to a new threadgroup
defaults to "isMonitor" true.
I'll test it out a bit tomorrow.
peter lin
>
> No problem.
>
> Not sure what you mean by defaulting to "isMonitor"
> - as far as I can see, the "Use as Monitor" checkbox
> defaults to un-selected -
> which is backwards compatible.
>
> >
> > the change to startDoc/endDoc is fine
>
> Just as well! I don't see how they could break
> anything...
>
> >
> > peter lin
> >
> >
__________________________________
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
http://taxes.yahoo.com/filing.html
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
Posted by se...@apache.org.
----- Original Message -----
From: "peter lin" <jm...@yahoo.com>
To: "JMeter Developers List" <jm...@jakarta.apache.org>
Sent: Sunday, March 21, 2004 4:41 PM
Subject: Re: cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
>
> oops on my part. I forgot that when I add a new httpsampler to the test plan, it defaults to "isMonitor".
No problem.
Not sure what you mean by defaulting to "isMonitor" - as far as I can see, the "Use as Monitor" checkbox defaults to un-selected -
which is backwards compatible.
>
> the change to startDoc/endDoc is fine
Just as well! I don't see how they could break anything...
>
> peter lin
>
>
> peter lin <jm...@yahoo.com> wrote:
>
> removing the startDoc and endDoc breaks the parser. Did you test the changes?
Yes and No - I ran the full test suite, but whether that includes parser tests, I don't know.
>
> peter lin
>
>
> sebb@apache.org wrote:
> sebb 2004/03/20 12:36:38
>
> Modified: src/monitor/components/org/apache/jmeter/visualizers
> MonitorAccumModel.java
> src/monitor/model/org/apache/jmeter/monitor/parser
> ParserImpl.java MonitorHandler.java
> src/monitor/components/org/apache/jmeter/monitor/util
> Stats.java
> Log:
> Fix some Javadoc errors; comment out unused variables
>
[...]
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
Posted by peter lin <jm...@yahoo.com>.
oops on my part. I forgot that when I add a new httpsampler to the test plan, it defaults to "isMonitor".
the change to startDoc/endDoc is fine
peter lin
peter lin <jm...@yahoo.com> wrote:
removing the startDoc and endDoc breaks the parser. Did you test the changes?
peter lin
sebb@apache.org wrote:
sebb 2004/03/20 12:36:38
Modified: src/monitor/components/org/apache/jmeter/visualizers
MonitorAccumModel.java
src/monitor/model/org/apache/jmeter/monitor/parser
ParserImpl.java MonitorHandler.java
src/monitor/components/org/apache/jmeter/monitor/util
Stats.java
Log:
Fix some Javadoc errors; comment out unused variables
Revision Changes Path
1.6 +5 -5 jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java
Index: MonitorAccumModel.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- MonitorAccumModel.java 16 Mar 2004 13:56:34 -0000 1.5
+++ MonitorAccumModel.java 20 Mar 2004 20:36:37 -0000 1.6
@@ -36,7 +36,7 @@
{
private HashMap MAP;
- private MonitorModel CURRENT;
+ //private MonitorModel CURRENT;
private List listeners;
/**
* By default, we set the default to 800
@@ -67,7 +67,7 @@
* @param model
*/
public void addSample(MonitorModel model){
- this.CURRENT = model;
+ //this.CURRENT = model;
if (MAP.containsKey(model.getURL())){
List newlist = updateArray(model,(List)MAP.get(model.getURL()));
MAP.put(model.getURL(),newlist);
@@ -134,7 +134,7 @@
if (sample instanceof HTTPSampleResult){
surl = ((HTTPSampleResult)sample).getURL();
}
- String rescontent = new String(sample.getResponseData());
+ //String rescontent = new String(sample.getResponseData());
if (sample.getResponseCode().equals("200") &&
((HTTPSampleResult)sample).isMonitor()){
ObjectFactory of = ObjectFactory.getInstance();
@@ -176,7 +176,7 @@
* with the given URL. This is used when the server
* fails to respond fully, or is dead.
* @param url
- * @return
+ * @return new MonitorModel
*/
public MonitorModel createNewMonitorModel(URL url){
MonitorStats stat = new MonitorStats(Stats.DEAD,
1.4 +4 -4 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
Index: ParserImpl.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ParserImpl.java 16 Mar 2004 03:28:49 -0000 1.3
+++ ParserImpl.java 20 Mar 2004 20:36:38 -0000 1.4
@@ -60,7 +60,7 @@
/**
* parse byte array and return Status object
- * @param byte[]
+ * @param bytes
* @return Status
*/
public Status parseBytes(byte[] bytes)
@@ -82,7 +82,7 @@
}
/**
- * @param String data
+ * @param content
* @return Status
*/
public Status parseString(String content)
@@ -91,7 +91,7 @@
}
/**
- * @param SampleResult result
+ * @param result
* @return Status
*/
public Status parseSampleResult(SampleResult result)
1.5 +17 -14 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java
Index: MonitorHandler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MonitorHandler.java 16 Mar 2004 03:28:49 -0000 1.4
+++ MonitorHandler.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -16,7 +16,7 @@
*/
package org.apache.jmeter.monitor.parser;
-import java.util.List;
+//import java.util.List;
import java.util.Stack;
import org.xml.sax.Attributes;
@@ -37,8 +37,8 @@
public class MonitorHandler extends DefaultHandler
{
- private boolean startDoc = false;
- private boolean endDoc = false;
+ //private boolean startDoc = false;
+ //private boolean endDoc = false;
private Stack stacktree = new Stack();
private ObjectFactory factory = null;
@@ -50,7 +50,7 @@
private RequestInfo requestinfo = null;
private Worker worker = null;
private Workers workers = null;
- private List workerslist = null;
+ //private List workerslist = null;
/**
*
@@ -71,14 +71,14 @@
public void startDocument ()
throws SAXException
{
- this.startDoc = true;
+ //this.startDoc = true;
}
public void endDocument ()
throws SAXException
{
- this.startDoc = false;
- this.endDoc = true;
+ //this.startDoc = false;
+ //this.endDoc = true;
}
/**
@@ -89,7 +89,9 @@
* each element (such as allocating a new tree node or writing
* output to a file).
*
- * @param name The element type name.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName
* @param attributes The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
@@ -256,8 +258,9 @@
* each element (such as finalising a tree node or writing
* output to a file).
*
- * @param name The element type name.
- * @param attributes The specified or defaulted attributes.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
* @see org.xml.sax.ContentHandler#endElement
@@ -327,7 +330,7 @@
* Convienance method for parsing long. If the string
* was not a number, the method returns zero.
* @param data
- * @return
+ * @return the value as a long
*/
public long parseLong(String data){
long val = 0;
@@ -344,7 +347,7 @@
/**
* Convienance method for parsing integers.
* @param data
- * @return
+ * @return the value as an integer
*/
public int parseInt(String data){
int val = 0;
@@ -360,7 +363,7 @@
/**
* method returns the status object.
- * @return
+ * @return the status
*/
public Status getContents(){
return this.status;
1.5 +3 -3 jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java
Index: Stats.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Stats.java 16 Mar 2004 03:49:53 -0000 1.4
+++ Stats.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -90,14 +90,14 @@
*
none of the above is dead
*
* @param stat
- * @return
+ * @return integer representing the status
*/
public static int calculateStatus(Status stat){
if (stat != null){
Connector cntr = (Connector)stat.getConnector().get(0);
int max = cntr.getThreadInfo().getMaxThreads();
int current = cntr.getThreadInfo().getCurrentThreadsBusy();
- int spare = cntr.getThreadInfo().getMaxSpareThreads();
+ //int spare = cntr.getThreadInfo().getMaxSpareThreads();
double per = (double)current/(double)max;
if (per > WARNING_PER){
return WARNING;
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.
Re: cvs commit: jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util Stats.java
Posted by peter lin <jm...@yahoo.com>.
removing the startDoc and endDoc breaks the parser. Did you test the changes?
peter lin
sebb@apache.org wrote:
sebb 2004/03/20 12:36:38
Modified: src/monitor/components/org/apache/jmeter/visualizers
MonitorAccumModel.java
src/monitor/model/org/apache/jmeter/monitor/parser
ParserImpl.java MonitorHandler.java
src/monitor/components/org/apache/jmeter/monitor/util
Stats.java
Log:
Fix some Javadoc errors; comment out unused variables
Revision Changes Path
1.6 +5 -5 jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java
Index: MonitorAccumModel.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/visualizers/MonitorAccumModel.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- MonitorAccumModel.java 16 Mar 2004 13:56:34 -0000 1.5
+++ MonitorAccumModel.java 20 Mar 2004 20:36:37 -0000 1.6
@@ -36,7 +36,7 @@
{
private HashMap MAP;
- private MonitorModel CURRENT;
+ //private MonitorModel CURRENT;
private List listeners;
/**
* By default, we set the default to 800
@@ -67,7 +67,7 @@
* @param model
*/
public void addSample(MonitorModel model){
- this.CURRENT = model;
+ //this.CURRENT = model;
if (MAP.containsKey(model.getURL())){
List newlist = updateArray(model,(List)MAP.get(model.getURL()));
MAP.put(model.getURL(),newlist);
@@ -134,7 +134,7 @@
if (sample instanceof HTTPSampleResult){
surl = ((HTTPSampleResult)sample).getURL();
}
- String rescontent = new String(sample.getResponseData());
+ //String rescontent = new String(sample.getResponseData());
if (sample.getResponseCode().equals("200") &&
((HTTPSampleResult)sample).isMonitor()){
ObjectFactory of = ObjectFactory.getInstance();
@@ -176,7 +176,7 @@
* with the given URL. This is used when the server
* fails to respond fully, or is dead.
* @param url
- * @return
+ * @return new MonitorModel
*/
public MonitorModel createNewMonitorModel(URL url){
MonitorStats stat = new MonitorStats(Stats.DEAD,
1.4 +4 -4 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java
Index: ParserImpl.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/ParserImpl.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- ParserImpl.java 16 Mar 2004 03:28:49 -0000 1.3
+++ ParserImpl.java 20 Mar 2004 20:36:38 -0000 1.4
@@ -60,7 +60,7 @@
/**
* parse byte array and return Status object
- * @param byte[]
+ * @param bytes
* @return Status
*/
public Status parseBytes(byte[] bytes)
@@ -82,7 +82,7 @@
}
/**
- * @param String data
+ * @param content
* @return Status
*/
public Status parseString(String content)
@@ -91,7 +91,7 @@
}
/**
- * @param SampleResult result
+ * @param result
* @return Status
*/
public Status parseSampleResult(SampleResult result)
1.5 +17 -14 jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java
Index: MonitorHandler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/model/org/apache/jmeter/monitor/parser/MonitorHandler.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- MonitorHandler.java 16 Mar 2004 03:28:49 -0000 1.4
+++ MonitorHandler.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -16,7 +16,7 @@
*/
package org.apache.jmeter.monitor.parser;
-import java.util.List;
+//import java.util.List;
import java.util.Stack;
import org.xml.sax.Attributes;
@@ -37,8 +37,8 @@
public class MonitorHandler extends DefaultHandler
{
- private boolean startDoc = false;
- private boolean endDoc = false;
+ //private boolean startDoc = false;
+ //private boolean endDoc = false;
private Stack stacktree = new Stack();
private ObjectFactory factory = null;
@@ -50,7 +50,7 @@
private RequestInfo requestinfo = null;
private Worker worker = null;
private Workers workers = null;
- private List workerslist = null;
+ //private List workerslist = null;
/**
*
@@ -71,14 +71,14 @@
public void startDocument ()
throws SAXException
{
- this.startDoc = true;
+ //this.startDoc = true;
}
public void endDocument ()
throws SAXException
{
- this.startDoc = false;
- this.endDoc = true;
+ //this.startDoc = false;
+ //this.endDoc = true;
}
/**
@@ -89,7 +89,9 @@
* each element (such as allocating a new tree node or writing
* output to a file).
*
- * @param name The element type name.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName
* @param attributes The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
@@ -256,8 +258,9 @@
* each element (such as finalising a tree node or writing
* output to a file).
*
- * @param name The element type name.
- * @param attributes The specified or defaulted attributes.
+ * @param uri
+ * @param localName The element type name.
+ * @param qName The specified or defaulted attributes.
* @exception org.xml.sax.SAXException Any SAX exception, possibly
* wrapping another exception.
* @see org.xml.sax.ContentHandler#endElement
@@ -327,7 +330,7 @@
* Convienance method for parsing long. If the string
* was not a number, the method returns zero.
* @param data
- * @return
+ * @return the value as a long
*/
public long parseLong(String data){
long val = 0;
@@ -344,7 +347,7 @@
/**
* Convienance method for parsing integers.
* @param data
- * @return
+ * @return the value as an integer
*/
public int parseInt(String data){
int val = 0;
@@ -360,7 +363,7 @@
/**
* method returns the status object.
- * @return
+ * @return the status
*/
public Status getContents(){
return this.status;
1.5 +3 -3 jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java
Index: Stats.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/monitor/components/org/apache/jmeter/monitor/util/Stats.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Stats.java 16 Mar 2004 03:49:53 -0000 1.4
+++ Stats.java 20 Mar 2004 20:36:38 -0000 1.5
@@ -90,14 +90,14 @@
*
none of the above is dead
*
* @param stat
- * @return
+ * @return integer representing the status
*/
public static int calculateStatus(Status stat){
if (stat != null){
Connector cntr = (Connector)stat.getConnector().get(0);
int max = cntr.getThreadInfo().getMaxThreads();
int current = cntr.getThreadInfo().getCurrentThreadsBusy();
- int spare = cntr.getThreadInfo().getMaxSpareThreads();
+ //int spare = cntr.getThreadInfo().getMaxSpareThreads();
double per = (double)current/(double)max;
if (per > WARNING_PER){
return WARNING;
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Do you Yahoo!?
Yahoo! Finance Tax Center - File online. File on time.