[GitHub] [airflow] NickYadance commented on issue #23664: Max dagrun limitation should not stop failed dagrun from retry

[GitBox <gi...@apache.org>]

NickYadance commented on issue #23664:
URL: https://github.com/apache/airflow/issues/23664#issuecomment-1173631483

   @spatocode Oh i didn't notice that default retry is set to 0. It's been a while so i re-test this in Airflow 2.3.2 with retry set to 3 and `max_active_runs_per_dag` to 4.
   
   The DAG:
   ```python
   from datetime import datetime, timedelta
   from textwrap import dedent
   import pendulum
   # The DAG object; we'll need this to instantiate a DAG
   from airflow import DAG
   
   # Operators; we need this to operate!
   from airflow.operators.bash import BashOperator
   with DAG(
           'test',
           default_args={
               'depends_on_past': True,
               'retries': 3,
           },
           description='Max dagrun limitation should not stop failed dagrun from retry',
           schedule_interval=timedelta(hours=1),
           start_date=pendulum.datetime(2022, 5, 11, tz='Asia/Singapore'),
           catchup=True,
           tags=['test'],
   ) as dag:
       task_error = BashOperator(task_id='error',
                                 bash_command='error')
       task_error
   ```
   
   Airflow spawns 4 dagruns and the first dagrun fails with retry. However i can manually clear the first dagrun and it will rerun as normal. This is actually the behavior that i expected. In real life case we can fix the problem and kick off the first dagrun so the rest won't stuck so there is no deadlock in the situation.
   <img width="1329" alt="image" src="https://user-images.githubusercontent.com/10060849/177131844-a5ed28f5-6c77-4860-a6b7-af9011be855d.png">
   
   Will close the issue since i can't reproduce it and i haven't experiencing similiar issues in real life. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org