You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by ictmalili <gi...@git.apache.org> on 2016/02/19 03:13:33 UTC
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
GitHub user ictmalili opened a pull request:
https://github.com/apache/incubator-hawq/pull/357
HAWQ-275. Add connection check when dispatcher wants to reuse the QE forked by former queries, and when dispather dispatches the detailed query command to QE
Add connection check when dispatcher wants to reuse the QE forked by former queries, and when dispather dispatches the detailed query command to QE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-275
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit f8dfd675e8aa11ac5a03a38f1d455f4090115794
Author: Lili Ma <lm...@pivotal.io>
Date: 2016-02-19T01:10:58Z
HAWQ-275. Add connection check when dispatcher wants to reuse the QE forked by former queries, and when dispather dispatches the detailed query command to QE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/357#issuecomment-186147787
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/357#issuecomment-186021695
+1 and it's better to reuse dispatcherAYT, because executormgr_validate_conn and dispatcherAYT have a lot of repeated code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the pull request:
https://github.com/apache/incubator-hawq/pull/357#issuecomment-186040416
Yes, function executormgr_validate_conn and dispatcherAYT have repeated code, but I'm not sure whether we can merge the two functions into one since dispatcherAYT is in ic_udp.c and interconnect seems a independent part. Shall we merge that? @changleicn
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the pull request:
https://github.com/apache/incubator-hawq/pull/357#issuecomment-186053153
Yes, I'll add that errno check errno == EWOULDBLOCK in the code. And seems that EAGAIN and EWOULDBLOCK often return same values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-275. Add connection check when d...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/357#issuecomment-186022236
One more thing, is there a need to consider errno == EWOULDBLOCK in your executormgr_validate_conn() if connection is nonblocking
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---