You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "alexr17 (via GitHub)" <gi...@apache.org> on 2025/09/23 00:34:48 UTC
[PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
alexr17 opened a new pull request, #13968:
URL: https://github.com/apache/hudi/pull/13968
### Describe the issue this Pull Request addresses
As suggested by @vinothchandar , should rename heartbeat poll secs to lock renewal secs
### Summary and Changelog
`hoodie.write.lock.storage.heartbeat.poll.secs` -> `hoodie.write.lock.storage.renew.interval.secs`
- will still keep heartbeat poll as alternative
### Impact
No impact
### Risk Level
None, maintains default behavior.
### Documentation Update
None
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13968:
URL: https://github.com/apache/hudi/pull/13968#issuecomment-3321998764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "01f8404a418925aff3d442962f87b07fba20de62",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "01f8404a418925aff3d442962f87b07fba20de62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01f8404a418925aff3d442962f87b07fba20de62 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #13968:
URL: https://github.com/apache/hudi/pull/13968#discussion_r2370795466
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/StorageBasedLockConfig.java:
##########
@@ -42,11 +42,12 @@ public class StorageBasedLockConfig extends HoodieConfig {
+ "The lock provider will attempt to renew its lock until it successfully extends the lock lease period "
+ "or the validity timeout is reached.");
- public static final ConfigProperty<Long> HEARTBEAT_POLL_SECONDS = ConfigProperty
- .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "heartbeat.poll.secs")
+ public static final ConfigProperty<Long> RENEW_INTERVAL_SECS = ConfigProperty
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "renew.interval.secs")
.defaultValue(30L)
.markAdvanced()
.sinceVersion(SINCE_VERSION_1_0_2)
+ .withAlternatives(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "heartbeat.poll.secs")
Review Comment:
Have you checked that there is no invocation of `RENEW_INTERVAL_SECS.key()` to get the config value? If so, the alternative config key is not going to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13968:
URL: https://github.com/apache/hudi/pull/13968#issuecomment-3322000945
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "01f8404a418925aff3d442962f87b07fba20de62",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8741",
"triggerID" : "01f8404a418925aff3d442962f87b07fba20de62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01f8404a418925aff3d442962f87b07fba20de62 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8741)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13968:
URL: https://github.com/apache/hudi/pull/13968#issuecomment-3322104832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "01f8404a418925aff3d442962f87b07fba20de62",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8741",
"triggerID" : "01f8404a418925aff3d442962f87b07fba20de62",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01f8404a418925aff3d442962f87b07fba20de62 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=8741)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9158] Rename heartbeat poll secs to lock renewal secs [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #13968:
URL: https://github.com/apache/hudi/pull/13968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org