You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/15 00:33:26 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
HyukjinKwon opened a new pull request #34902:
URL: https://github.com/apache/spark/pull/34902
### What changes were proposed in this pull request?
This PR proposes to switch default index to `distributed-sequence` by default.
### Why are the changes needed?
`sequence` type relies on sending all data to one executor that easily causes OOM.
We should better switch to `distributed-sequence` type that truly distributes the data.
### Does this PR introduce _any_ user-facing change?
Ideally no. Order might be affected but that's not already guaranteed.
### How was this patch tested?
Existing CI should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994183099
There are some places the default type in the docs, like:
https://github.com/apache/spark/blob/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c/python/docs/source/user_guide/pandas_on_spark/best_practices.rst#L238
https://github.com/apache/spark/blob/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c/python/docs/source/user_guide/pandas_on_spark/options.rst#L163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994200127
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50676/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994225543
All tests passed at https://github.com/HyukjinKwon/spark/actions/runs/1580641441.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994241965
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994177923
**[Test build #146202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146202/testReport)** for PR 34902 at commit [`3704d4d`](https://github.com/apache/spark/commit/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994253373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994176732
cc @ueshin @xinrong-databricks @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994197849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146202/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994226964
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50676/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994227341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin edited a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
ueshin edited a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994183099
There are some places mentioning the default type in the docs, like:
https://github.com/apache/spark/blob/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c/python/docs/source/user_guide/pandas_on_spark/best_practices.rst#L238
https://github.com/apache/spark/blob/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c/python/docs/source/user_guide/pandas_on_spark/options.rst#L163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994177923
**[Test build #146202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146202/testReport)** for PR 34902 at commit [`3704d4d`](https://github.com/apache/spark/commit/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994197849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146202/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994253373
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994221190
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50678/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34902:
URL: https://github.com/apache/spark/pull/34902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994198737
**[Test build #146204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146204/testReport)** for PR 34902 at commit [`969911a`](https://github.com/apache/spark/commit/969911a816d99b527b60a27c05254f30231212d2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994211770
**[Test build #146204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146204/testReport)** for PR 34902 at commit [`969911a`](https://github.com/apache/spark/commit/969911a816d99b527b60a27c05254f30231212d2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994198737
**[Test build #146204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146204/testReport)** for PR 34902 at commit [`969911a`](https://github.com/apache/spark/commit/969911a816d99b527b60a27c05254f30231212d2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994191493
**[Test build #146202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146202/testReport)** for PR 34902 at commit [`3704d4d`](https://github.com/apache/spark/commit/3704d4d6e7bd7f5f05db05a6a281f8015ad6ae1c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34902: [SPARK-37649][PYTHON] Switch default index to distributed-sequence by default in pandas API on Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34902:
URL: https://github.com/apache/spark/pull/34902#issuecomment-994227341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org