You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/07 07:21:46 UTC
[GitHub] [shardingsphere] taojintianxia opened a new pull request, #23393: Refactor : refactor the agent packging structure (#23392)
taojintianxia opened a new pull request, #23393:
URL: https://github.com/apache/shardingsphere/pull/23393
Fixes #23392
Changes proposed in this pull request:
- refactor the agent packging structure
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #23393: Refactor : refactor the agent packging structure (#23392)
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23393:
URL: https://github.com/apache/shardingsphere/pull/23393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on pull request #23393: Refactor : refactor the agent packging structure (#23392)
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on PR #23393:
URL: https://github.com/apache/shardingsphere/pull/23393#issuecomment-1374678478
> How about use `Files.walkFileTree` to simplify the impl
Refactored.
but I found the guava Files seems more simple
this is the guava implementation:
<img width="874" alt="image" src="https://user-images.githubusercontent.com/4112856/211176291-dd37c2ed-291f-47e2-8d98-d36228e92d64.png">
this is the nio Files implementation:
<img width="1075" alt="image" src="https://user-images.githubusercontent.com/4112856/211176308-bd9aadb4-6575-4007-b47f-bc0acebcaf97.png">
the nio Files need to declear an IOException.
the guava Files has a Beta annotation from guava 19, that's why it has a yellow warning in IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23393: Refactor : refactor the agent packging structure (#23392)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23393:
URL: https://github.com/apache/shardingsphere/pull/23393#issuecomment-1374408148
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23393](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (231c00e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0b4aacdc9244319a463eaded610b1f6883029113?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b4aacd) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #23393 +/- ##
=========================================
Coverage 49.79% 49.79%
Complexity 2459 2459
=========================================
Files 4071 4071
Lines 58230 58230
Branches 9245 9245
=========================================
+ Hits 28993 28995 +2
+ Misses 26682 26681 -1
+ Partials 2555 2554 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...core/transformer/builder/MethodAdvisorBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL01ldGhvZEFkdmlzb3JCdWlsZGVyLmphdmE=) | | |
| [...core/transformer/builder/advise/AdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9idWlsZGVyL2FkdmlzZS9BZHZpY2VGYWN0b3J5LmphdmE=) | | |
| [...phere/agent/core/transformer/AgentTransformer.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9BZ2VudFRyYW5zZm9ybWVyLmphdmE=) | | |
| [...ngsphere/agent/core/transformer/AgentJunction.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS90cmFuc2Zvcm1lci9BZ2VudEp1bmN0aW9uLmphdmE=) | | |
| [...ardingsphere/agent/core/builder/AdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9idWlsZGVyL0FkdmljZUZhY3RvcnkuamF2YQ==) | `83.33% <0.00%> (ø)` | |
| [...phere/agent/core/builder/MethodAdvisorBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9idWlsZGVyL01ldGhvZEFkdmlzb3JCdWlsZGVyLmphdmE=) | `86.36% <0.00%> (ø)` | |
| [...ingsphere/agent/core/builder/AgentTransformer.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9idWlsZGVyL0FnZW50VHJhbnNmb3JtZXIuamF2YQ==) | `75.00% <0.00%> (ø)` | |
| [...ardingsphere/agent/core/builder/AgentJunction.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9idWlsZGVyL0FnZW50SnVuY3Rpb24uamF2YQ==) | `50.00% <0.00%> (ø)` | |
| [...ontend/executor/ConnectionThreadExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/23393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvQ29ubmVjdGlvblRocmVhZEV4ZWN1dG9yR3JvdXAuamF2YQ==) | `86.66% <0.00%> (+13.33%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org