You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/01 20:27:57 UTC
[GitHub] [ozone] jojochuang commented on a diff in pull request #3430: HDDS-6705 Add metrics for volume statistics including disk capacity, usage, Reserved
jojochuang commented on code in PR #3430:
URL: https://github.com/apache/ozone/pull/3430#discussion_r887251507
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -332,19 +352,22 @@ public void shutdown() {
if (volumeIOStats != null) {
volumeIOStats.unregister();
}
+ if (volumeInfoMetrics != null) {
+ volumeInfoMetrics.unregister();
+ }
}
/**
* VolumeState represents the different states a HddsVolume can be in.
* NORMAL => Volume can be used for storage
* FAILED => Volume has failed due and can no longer be used for
- * storing containers.
Review Comment:
This is fine but please refrain from updating code style in unrelated code next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org