You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 14:34:14 UTC

[GitHub] [pulsar] fantapsody opened a new pull request #14517: [es-sink] Fix the config document for `indexName` in es sink

fantapsody opened a new pull request #14517:
URL: https://github.com/apache/pulsar/pull/14517


   ### Motivation
   
   A follow-up of https://github.com/apache/pulsar/pull/14383#discussion_r815613145.
   
   ### Modifications
   
   Fix the document at `site2/docs/io-elasticsearch-sink.md`.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] fantapsody commented on pull request #14517: [es-sink] Fix the config document for `indexName` in es sink

Posted by GitBox <gi...@apache.org>.
fantapsody commented on pull request #14517:
URL: https://github.com/apache/pulsar/pull/14517#issuecomment-1055512484


   @Anonymitaet PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #14517: [es-sink] Fix the config document for `indexName` in es sink

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14517:
URL: https://github.com/apache/pulsar/pull/14517#issuecomment-1055507781


   @fantapsody:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #14517: [es-sink] Fix the config document for `indexName` in es sink

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14517:
URL: https://github.com/apache/pulsar/pull/14517#issuecomment-1055515233


   @fantapsody:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet merged pull request #14517: [es-sink] Fix the config document for `indexName` in es sink

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #14517:
URL: https://github.com/apache/pulsar/pull/14517


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org